From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3F3F5740032 for ; Fri, 8 Dec 2023 12:23:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=aeUS6Tli33C792CQJLCv0yg6OktQzQA9mb3849dyEMA=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702038186; v=1; b=IsMafkzKZvDULBOPYpVgDye2xuWUpXScARaz0XSf1KrtWaiwzPQJ5/QyO1qyHgcyDTnkw/jR vBxBp5pthWUSwqTeq7AYEL4CG5ygF6CxljOCzA/bluEp5ZEhPUc9Lsx8o3POfp+rKg8cVX7XL9R +wIQ2cas0wuOthNotj9YgdCg= X-Received: by 127.0.0.2 with SMTP id gXquYY7687511xczaWf994hl; Fri, 08 Dec 2023 04:23:06 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.30823.1702038186209816487 for ; Fri, 08 Dec 2023 04:23:06 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-245-55u2VZt1PYiM45v2niXGqA-1; Fri, 08 Dec 2023 07:23:01 -0500 X-MC-Unique: 55u2VZt1PYiM45v2niXGqA-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 52F0F3806701; Fri, 8 Dec 2023 12:23:01 +0000 (UTC) X-Received: from [10.39.193.124] (unknown [10.39.193.124]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 11DCA111E404; Fri, 8 Dec 2023 12:22:58 +0000 (UTC) Message-ID: Date: Fri, 8 Dec 2023 13:22:57 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/MemEncryptSevLib: Fix address overflow during PVALIDATE To: devel@edk2.groups.io, kraxel@redhat.com Cc: Michael Roth , Ray Ni , Erdem Aktas , Jiewen Yao , Min Xu , Tom Lendacky , "Liming Gao (Byosoft address)" , Michael Kinney References: <20231115175153.813213-1-michael.roth@amd.com> <6f62e3d2-cf82-a23b-174a-fa24dd94fbe1@redhat.com> <57te454l357zkcgohbee4afjsyyllvvhh4dcc3rfde54se6pvh@q2rcfktmjvc6> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: a4I26F1l9Y12fmOBB7MlKEXbx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=IsMafkzK; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/20/23 08:55, Gerd Hoffmann wrote: > On Fri, Nov 17, 2023 at 10:39:13PM +0100, Laszlo Ersek wrote: >> On 11/17/23 12:42, Gerd Hoffmann wrote: >>> On Fri, Nov 17, 2023 at 10:16:10AM +0100, Laszlo Ersek wrote: >>>> (+Liming +Mike) >>>> >>>> On 11/16/23 10:01, Gerd Hoffmann wrote: >>>>> On Wed, Nov 15, 2023 at 11:51:53AM -0600, Michael Roth wrote: >>>>>> The struct used for GHCB-based page-state change requests uses a 40-= bit >>>>>> bit-field for the GFN, which is shifted by PAGE_SHIFT to generate a >>>>>> 64-bit address. However, anything beyond 40-bits simply gets shifted= off >>>>>> when doing this, which will cause issues when dealing with 1TB+ >>>>>> addresses. Fix this by casting the 40-bit GFN values to 64-bit ones >>>>>> prior to shifting it by PAGE_SHIFT. >>>>>> >>>>>> Fixes: ade62c18f474 ("OvmfPkg/MemEncryptSevLib: add support to valid= ate system RAM") >>>>>> Signed-off-by: Michael Roth >>>>> >>>>> Reviewed-by: Gerd Hoffmann >>>>> >>>>> take care, >>>>> Gerd >>>> >>>> Is this hard feature freeze material? >>> >>> It is a clear bugfix, so IMHO it qualifies. >>> >>>> Also, the patch looks garbled to me on-list (superfluous line breaks). >>> >>> Patch applies fine here. I see mutt breaking the long line, but >>> that is just the local display rendering, the mail good. >> >> Can you check the raw message? I did that and it seems broken. >> Superfluous newlines. I see *double* CRLFs. >=20 > Hmm, everything looks fine here, and 'git am' accepts the mail without > problems. Pushed a branch: >=20 > https://github.com/kraxel/edk2/commits/b4/v2-20231115-michael-roth-ovmfpk= g-memencryptsevlib-fix-address-overflow-during-pvalidate This branch contains whitespace damage. The new lines coming from the patch are terminated with LF, not CRLF. (Doesn't matter much, just wanted to clarify that mutt wasn't doing the right thing on your end. The patch, as posted, does contain multiple CRLFs, and while mutt seems to mitigate that for you, it overshoots. Anyway, I'm picking this up now; I've cleaned up the double CRLFs manually.= ) Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112227): https://edk2.groups.io/g/devel/message/112227 Mute This Topic: https://groups.io/mt/102610323/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-