From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7180C7803D8 for ; Tue, 20 Aug 2024 02:04:57 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YMn0G4u1Bm3UumjW3QSErXRWDQQ4ORrJCwb87OtfEy4=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1724119497; v=1; b=ihX9WSIg28CTdXPYS4P5Ej1ZnEUF7Rbt15uAMxQ834Oae+uZuZFAJfVeiqNKkfdLUA5tWrrJ 8xSNzyVxFK5j/kAjDu4GOJoiAGmEUVG+z9IlPOZtAr8X3wWiSWfH9e8GRc7GBmEzHuGlchzp9Ot yj5FyTVOmXy2AFsdbzMJx7dj/zY+86mU6Yzs86Y2HVgagXjPc+kMwA+IxnWtdtG91ON8dl2JTJC /bIsFXj0u/ClSfel7bVaRTRrGJcDaJBl91D3QbGG2IM3VjNsWWymNb5A8agsFdhQh+8r4LHe8Kb gxKFoDooQAW+wEGSxjbyNF/goXoLeINVsgmMhqLfcTXvA== X-Received: by 127.0.0.2 with SMTP id NmqyYY7687511xtAtxcLCuM9; Mon, 19 Aug 2024 19:04:55 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.9462.1724119495293592439 for ; Mon, 19 Aug 2024 19:04:55 -0700 X-Received: from [10.6.0.181] (unknown [20.39.63.4]) by linux.microsoft.com (Postfix) with ESMTPSA id 56C6720B7165; Mon, 19 Aug 2024 19:04:54 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 56C6720B7165 Message-ID: Date: Mon, 19 Aug 2024 22:04:53 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the GitHub Pull Request workflow To: devel@edk2.groups.io, michael.d.kinney@intel.com, Rebecca Cran , Leif Lindholm , "Kubacki, Michael" References: <17E7B8D5FB5780B0.20637@groups.io> <7e5041db-8d35-4369-9bf9-863eb85601c6@bsdio.com> <3b96e475-3d47-4cc6-8359-917f0ef7f09a@bsdio.com> From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 19 Aug 2024 19:04:55 -0700 Resent-From: mikuback@linux.microsoft.com Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: q2ES14UbkrZXiGcrp0X0DBLfx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=ihX9WSIg; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io For simplicity of testing on the fork, I'd just create a PAT in your=20 repo with the necessary permissions and use that as the secret there.=20 Then, substitute it with the app secret in the edk2-platforms PR. You can test almost everything that way except the app token generation=20 itself. But, that's mostly copy/paste. Here's an example of the change=20 to switch from a normal secret token, whether the default token as shown=20 there, or a PAT secret, to an app token: https://github.com/tianocore/edk2/commit/1b37b3659b5098f764dee5b893e4eb1749= 49f40a On 8/19/2024 9:58 PM, Michael D Kinney wrote: > Here is the guide I used that includes the GitHub App approach >=20 > * https://michaelheap.com/ultimate-guide-github-actions-authentication/ >=20 > Mike >=20 >> -----Original Message----- >> From: Rebecca Cran >> Sent: Monday, August 19, 2024 4:31 PM >> To: Kinney, Michael D ; devel@edk2.groups.io= ; >> Leif Lindholm ; Kubacki, Michael >> >> Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the GitH= ub >> Pull Request workflow >> >> Sorry, I should have explained: I'd like to set it up on >> https://github.com/bcran/edk2-platforms to test it before having the >> changes merged into https://github.com/tianocore/edk2-platforms. >> >> >> -- >> >> Rebecca >> >> >> On 8/19/2024 5:01 PM, Kinney, Michael D wrote: >>> You do not need a new app. >>> >>> We can use the app that is already available. >>> >>> The main update that is needed is adding secrets to edk2-platforms repo >>> >>> Mike >>> >>>> -----Original Message----- >>>> From: Rebecca Cran >>>> Sent: Monday, August 19, 2024 3:15 PM >>>> To: Kinney, Michael D ; >> devel@edk2.groups.io; >>>> Leif Lindholm ; Kubacki, Michael >>>> >>>> Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the >> GitHub >>>> Pull Request workflow >>>> >>>> Could you explain what you entered into the New GitHub App page when >>>> setting up tianocore to use >>>> https://github.com/marketplace/actions/create-github-app-token please? >>>> >>>> >>>> -- >>>> >>>> Rebecca >>>> >>>> >>>> On 8/6/24 1:14 PM, Kinney, Michael D wrote: >>>>> I suspect you will run into the same permissions issues that required >>>>> the use of a GitHub App credentials to run the AssignReviewers.yml. >>>>> >>>>> See this change for reference: >>>>> >>>>> https://github.com/tianocore/edk2/pull/6050 >>>>> >>>>> >>>>> Mike >>>>> >>>>>> -----Original Message----- >>>>>> From: Rebecca Cran >>>>>> Sent: Tuesday, August 6, 2024 10:36 AM >>>>>> To: devel@edk2.groups.io; Leif Lindholm ; >>>> Kinney, >>>>>> Michael D >>>>>> Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the >>>> GitHub >>>>>> Pull Request workflow >>>>>> >>>>>> Could I get some reviews on this please? >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> Rebecca >>>>>> >>>>>> >>>>>> On 8/1/24 3:43 PM, Rebecca Cran wrote: >>>>>>> Changes from v2 to v3: >>>>>>> >>>>>>> Added note to AssignReviewers.yml to say where it was copied from. >>>>>>> >>>>>>> Sorted platforms in CODEOWNERS and REVIEWERS alphabetically. >>>>>>> Sorted entries in CONTRIBUTORS.md by first name. >>>>>>> >>>>>>> Updated CONTRIBUTORS.md with some more GitHub usernames. >>>>>>> Updated Readme.md to clarify that people own _areas_ of the repo, n= ot >>>>>>> specifically packages. >>>>>>> >>>>>>> Rebecca Cran (1): >>>>>>> Move to the GitHub Pull Request workflow >>>>>>> >>>>>>> .github/workflows/AssignReviewers.yml | 31 ++ >>>>>>> CODEOWNERS | 146 +++++++ >>>>>>> CONTRIBUTORS.md | 68 +++ >>>>>>> Maintainers.txt | 445 ------------------= -- >>>>>>> REVIEWERS | 92 ++++ >>>>>>> Readme.md | 33 +- >>>>>>> 6 files changed, 365 insertions(+), 450 deletions(-) >>>>>>> create mode 100644 .github/workflows/AssignReviewers.yml >>>>>>> create mode 100644 CODEOWNERS >>>>>>> create mode 100644 CONTRIBUTORS.md >>>>>>> delete mode 100644 Maintainers.txt >>>>>>> create mode 100644 REVIEWERS >>>>>>> >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120373): https://edk2.groups.io/g/devel/message/120373 Mute This Topic: https://groups.io/mt/107675097/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-