From: "Laszlo Ersek" <lersek@redhat.com>
To: gaoliming <gaoliming@byosoft.com.cn>,
devel@edk2.groups.io, jiewen.yao@intel.com, "'Guptha,
Soumya K'" <soumya.k.guptha@intel.com>,
announce@edk2.groups.io
Cc: "'Leif Lindholm (Nuvia address)'" <leif@nuviainc.com>,
"'Kinney, Michael D'" <michael.d.kinney@intel.com>,
'Andrew Fish' <afish@apple.com>
Subject: Re: 回复: [edk2-devel] Tianocore community page on who we are - please review
Date: Mon, 28 Sep 2020 19:15:16 +0200 [thread overview]
Message-ID: <a44d9feb-837f-e8e1-75fe-ba873233b7df@redhat.com> (raw)
In-Reply-To: <005f01d69476$81768bd0$8463a370$@byosoft.com.cn>
Hi Liming,
On 09/27/20 04:32, gaoliming wrote:
> Guidelines for a Maintainer. Never let a pending request get older than a
> calendar week. This requirement is too strict to the maintainer or reviewer.
> The maintainer or reviewer should try to give the response in one week. But,
> they may not fully review one patch set in one week, es for the feature or
> the complex change.
This requirement is about providing initial feedback. In other words,
about starting the review.
It's very important to provide initial feedback within a week.
I agree that more time than a week may be necessary for finishing /
completing a review.
"Letting a pending request get older than a week" means that there is
zero response within a week. If there is some response (albeit possibly
incomplete), then things are good.
Thanks
Laszlo
next prev parent reply other threads:[~2020-09-28 17:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 22:35 Tianocore community page on who we are - please review Soumya Guptha
2020-09-26 5:09 ` Yao, Jiewen
[not found] ` <16383D375E5994D7.27235@groups.io>
2020-09-26 5:32 ` [edk2-devel] " Yao, Jiewen
2020-09-27 2:32 ` 回复: " gaoliming
2020-09-27 3:25 ` [edk2-announce] " Yao, Jiewen
2020-09-28 12:01 ` [EXTERNAL] " Leif Lindholm
2020-09-30 2:11 ` Yao, Jiewen
2020-09-30 9:25 ` 回复: " gaoliming
2020-09-30 10:13 ` Leif Lindholm
2020-10-01 8:44 ` Laszlo Ersek
2020-10-01 8:45 ` Laszlo Ersek
2020-10-01 10:22 ` Leif Lindholm
2020-10-01 23:52 ` Soumya Guptha
2020-10-02 8:25 ` Laszlo Ersek
2020-10-01 8:29 ` 回复: [EXTERNAL] RE: [edk2-announce] 回复: [edk2-devel] " Laszlo Ersek
2020-10-01 8:26 ` Laszlo Ersek
2020-09-28 11:56 ` Leif Lindholm
2020-09-28 16:19 ` Soumya Guptha
2020-09-29 1:05 ` 回复: " gaoliming
2020-09-28 17:15 ` Laszlo Ersek [this message]
2020-09-29 1:03 ` gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a44d9feb-837f-e8e1-75fe-ba873233b7df@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox