Re: [PATCH 08/10] MdePkg/UefiRuntimeLib: Support more module types.

["Zeng, Star" <star.zeng@intel.com>]

On 2018/2/2 14:45, Ruiyu Ni wrote:
> Because DxeResetSystemLib links to this library to provide
> reset system services, change UefiRuntimeLib to support
> the same set of module types as what DxeResetSystemLib does.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>

Do you think it is ok or not to let DxeResetSystemLib consume 
UefiRuntimeServicesTableLib and use gRT->ResetSystem? Then this patch 
will be not needed.

If we still prefer to let DxeResetSystemLib consume UefiRuntimeLib, I am 
also ok. Reviewed-by: Star Zeng <star.zeng@intel.com>

Thanks,
Star

> ---
>   MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf b/MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> index 8f46495fc5..d053da545a 100644
> --- a/MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> +++ b/MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> @@ -5,7 +5,7 @@
>   #  EVT_SIGNAL_EXIT_BOOT_SERVICES event, to provide runtime services.
>   # This instance also supports SAL drivers for better performance.
>   #
> -# Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>   #
>   #  This program and the accompanying materials
>   #  are licensed and made available under the terms and conditions of the BSD License
> @@ -24,7 +24,7 @@ [Defines]
>     FILE_GUID                      = b1ee6c28-54aa-4d17-b705-3e28ccb27b2e
>     MODULE_TYPE                    = DXE_RUNTIME_DRIVER
>     VERSION_STRING                 = 1.0
> -  LIBRARY_CLASS                  = UefiRuntimeLib|DXE_RUNTIME_DRIVER DXE_SAL_DRIVER
> +  LIBRARY_CLASS                  = UefiRuntimeLib|DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_CORE DXE_DRIVER DXE_SMM_DRIVER
>   
>     CONSTRUCTOR                    = RuntimeDriverLibConstruct
>     DESTRUCTOR                     = RuntimeDriverLibDeconstruct
>