From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1798D21E256B5 for ; Wed, 7 Feb 2018 04:19:46 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Feb 2018 04:25:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,473,1511856000"; d="scan'208";a="28109847" Received: from shzintpr01.sh.intel.com (HELO [10.253.24.48]) ([10.239.4.80]) by fmsmga004.fm.intel.com with ESMTP; 07 Feb 2018 04:25:29 -0800 To: Ruiyu Ni , edk2-devel@lists.01.org Cc: Michael D Kinney , Liming Gao , star.zeng@intel.com References: <20180202064530.407028-1-ruiyu.ni@intel.com> <20180202064530.407028-9-ruiyu.ni@intel.com> From: "Zeng, Star" Message-ID: Date: Wed, 7 Feb 2018 20:24:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180202064530.407028-9-ruiyu.ni@intel.com> Subject: Re: [PATCH 08/10] MdePkg/UefiRuntimeLib: Support more module types. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 12:19:47 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2018/2/2 14:45, Ruiyu Ni wrote: > Because DxeResetSystemLib links to this library to provide > reset system services, change UefiRuntimeLib to support > the same set of module types as what DxeResetSystemLib does. > > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Star Zeng > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni Do you think it is ok or not to let DxeResetSystemLib consume UefiRuntimeServicesTableLib and use gRT->ResetSystem? Then this patch will be not needed. If we still prefer to let DxeResetSystemLib consume UefiRuntimeLib, I am also ok. Reviewed-by: Star Zeng Thanks, Star > --- > MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf b/MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf > index 8f46495fc5..d053da545a 100644 > --- a/MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf > +++ b/MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf > @@ -5,7 +5,7 @@ > # EVT_SIGNAL_EXIT_BOOT_SERVICES event, to provide runtime services. > # This instance also supports SAL drivers for better performance. > # > -# Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > @@ -24,7 +24,7 @@ [Defines] > FILE_GUID = b1ee6c28-54aa-4d17-b705-3e28ccb27b2e > MODULE_TYPE = DXE_RUNTIME_DRIVER > VERSION_STRING = 1.0 > - LIBRARY_CLASS = UefiRuntimeLib|DXE_RUNTIME_DRIVER DXE_SAL_DRIVER > + LIBRARY_CLASS = UefiRuntimeLib|DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_CORE DXE_DRIVER DXE_SMM_DRIVER > > CONSTRUCTOR = RuntimeDriverLibConstruct > DESTRUCTOR = RuntimeDriverLibDeconstruct >