From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4E566AC0931 for ; Wed, 13 Mar 2024 02:01:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=XNEoiUmksp3/zr4rsjSXgQYT61I+P4Ygs+vFqMNzJjI=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710295265; v=1; b=c7QFFu4Ys5gfrbFXRdIOaRVdMEiIZFMbrGedFjap0B4VIv2MRrpr5l3vgV+5wXWcLeKGLH4o anh/xQpeOsEQqiETwR+qcoc2OI+ustnklvkamL1ZAgwzjTU8jhAaRYHTBubiaFY92wYJDqQioUo hI9Rnzb3GKPE6liuxHgpOBQyhcvFu/TY5L0s/KNI2vq9zCaNdxWF2IH0nk9+lgqEbXkaCGKWL68 GOqL40YF3Ghx+7XMbu3y/ImGQ+Bk0oKHzdB4t8WUhFB6krZjLJ5ayubJ2ely+ZO31Tp/P6/u/nl YxuED7yGWaxv4M0RArwdKjnhkt3kRyrAnp9xlCiqXNkpQ== X-Received: by 127.0.0.2 with SMTP id 7PItYY7687511xN6jRCdJkjq; Tue, 12 Mar 2024 19:01:05 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.6853.1710295264614884488 for ; Tue, 12 Mar 2024 19:01:04 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 168351007; Tue, 12 Mar 2024 19:01:41 -0700 (PDT) X-Received: from [192.168.20.13] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 943A93F73F; Tue, 12 Mar 2024 19:01:03 -0700 (PDT) Message-ID: Date: Tue, 12 Mar 2024 21:01:02 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/RPI4: Grow FV size to accommodate DEBUG build To: Ard Biesheuvel , Ard Biesheuvel Cc: devel@edk2.groups.io, quic_llindhol@quicinc.com References: <20240312102923.2053815-1-ardb+git@google.com> From: "Jeremy Linton" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 12 Mar 2024 19:01:04 -0700 Reply-To: devel@edk2.groups.io,jeremy.linton@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8sE1BnotSRbjGUGeuZpHRENGx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=c7QFFu4Y; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, On 3/12/24 05:43, Ard Biesheuvel wrote: > On Tue, 12 Mar 2024 at 11:29, Ard Biesheuvel wrote: >> >> From: Ard Biesheuvel >> >> The DEBUG build no longer fits when all build options used by the >> release script on github.com/pftf are used, presumably due to the >> OpenSSL upgrade. >> >> So bump the size for all builds. >> >> Signed-off-by: Ard Biesheuvel >> --- >> Platform/RaspberryPi/RPi4/RPi4.fdf | 14 +++++++------- >> 1 file changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf b/Platform/RaspberryPi/R= Pi4/RPi4.fdf >> index 816927761513..951488260ed4 100644 >> --- a/Platform/RaspberryPi/RPi4/RPi4.fdf >> +++ b/Platform/RaspberryPi/RPi4/RPi4.fdf >> @@ -25,11 +25,11 @@ >> >> [FD.RPI_EFI] >> BaseAddress =3D 0x00000000|gArmTokenSpaceGuid.PcdFdBaseAddress >> -Size =3D 0x001f0000|gArmTokenSpaceGuid.PcdFdSize >> +Size =3D 0x00210000|gArmTokenSpaceGuid.PcdFdSize >> ErasePolarity =3D 1 >> >=20 > Ugh just realized that this breaks DT loading from TFA, which places > the DT at a fixed offset of 0x1f0000 Right, which can be changed within the config.txt file but its probably=20 better not to. I hit this a few months back and have a version on my=20 github which moves it too, along with the TFA fixes, but really we=20 should be able to move one of the other regions around the DT, which=20 IIRC may be pushed to one of my branches on github along with the CPPC=20 patches for TFA/etc too. That was set 4 or 5 that i've not posted because all the stuff in front=20 of it is still up in the air. I can probably pick off just this bit and post it next week if its still=20 a problem, since i'm away from the rpi's at the moment. >=20 >=20 >> BlockSize =3D 0x00001000|gRaspberryPiTokenSpaceGuid.PcdFirmwareBlo= ckSize >> -NumBlocks =3D 0x1f0 >> +NumBlocks =3D 0x210 >> >> ######################################################################= ########## >> # >> @@ -56,7 +56,7 @@ [FD.RPI_EFI] >> # >> # UEFI image >> # >> -0x00020000|0x001b0000 >> +0x00020000|0x001d0000 >> gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize >> FV =3D FVMAIN_COMPACT >> >> @@ -70,7 +70,7 @@ [FD.RPI_EFI] >> # >> >> # NV_VARIABLE_STORE >> -0x001d0000|0x0000e000 >> +0x001f0000|0x0000e000 >> gRaspberryPiTokenSpaceGuid.PcdNvStorageVariableBase|gEfiMdeModulePkgTo= kenSpaceGuid.PcdFlashNvStorageVariableSize >> >> DATA =3D { >> @@ -113,11 +113,11 @@ [FD.RPI_EFI] >> } >> >> # NV_EVENT_LOG >> -0x001de000|0x00001000 >> +0x001fe000|0x00001000 >> gRaspberryPiTokenSpaceGuid.PcdNvStorageEventLogBase|gRaspberryPiTokenS= paceGuid.PcdNvStorageEventLogSize >> >> # NV_FTW_WORKING header >> -0x001df000|0x00001000 >> +0x001ff000|0x00001000 >> gRaspberryPiTokenSpaceGuid.PcdNvStorageFtwWorkingBase|gEfiMdeModulePkg= TokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize >> >> DATA =3D { >> @@ -132,7 +132,7 @@ [FD.RPI_EFI] >> } >> >> # NV_FTW_WORKING data >> -0x001e0000|0x00010000 >> +0x00200000|0x00010000 >> gRaspberryPiTokenSpaceGuid.PcdNvStorageFtwSpareBase|gEfiMdeModulePkgTo= kenSpaceGuid.PcdFlashNvStorageFtwSpareSize >> >> # >> -- >> 2.44.0.278.ge034bb2e1d-goog >> -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116701): https://edk2.groups.io/g/devel/message/116701 Mute This Topic: https://groups.io/mt/104882052/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-