From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 01D58223E0B8F for ; Fri, 23 Mar 2018 07:25:33 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 76DAF4074CA8; Fri, 23 Mar 2018 14:32:06 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-180.rdu2.redhat.com [10.10.120.180]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9B30810B2B26; Fri, 23 Mar 2018 14:32:05 +0000 (UTC) To: "Zeng, Star" , Guo Heyi , "edk2-devel@lists.01.org" Cc: "Ni, Ruiyu" , "Dong, Eric" References: <20180322113942.GC53577@SZX1000114654> <20180322114307.GD53577@SZX1000114654> <0C09AFA07DD0434D9E2A0C6AEB0483103BA72963@shsmsx102.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: Date: Fri, 23 Mar 2018 15:32:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BA72963@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Fri, 23 Mar 2018 14:32:06 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Fri, 23 Mar 2018 14:32:06 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Mar 2018 14:25:34 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03/23/18 01:50, Zeng, Star wrote: > I agree. Wasn't there a problem with the default timeout being 1 second, and that 1 second slowing down terminal I/O on some platform? I don't remember more precisely. Thanks Laszlo > -----Original Message----- > From: Guo Heyi [mailto:heyi.guo@linaro.org] > Sent: Thursday, March 22, 2018 7:43 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Dong, Eric ; Ni, Ruiyu > Subject: Re: MdeModulePkg/SerialDxe: SetAttributes() not follow UEFI spec > > +cc Maintainers of MdeModulePkg. > > On Thu, Mar 22, 2018 at 07:39:42PM +0800, Guo Heyi wrote: >> Hi folks, >> >> The SetAttributes() interface of generic SerialDxe driver in >> MdeModulePkg/Universal does not fully follow UEFI spec. The spec >> requires to use default time out value when the input "Timeout" is 0, >> but the current implementation will set timeout to 0 directly. It >> tries to pass "Timeout" to SerialPortSetAttributes(), but none of >> SerialPortLib instances in edk2 tree will deal with this parameter. >> What's more, Timeout is actually a software parameter and is only used >> in SerialDxe itself, not in SerialPortLib instances, so I think it >> makes more sense to set Timeout in SerialDxe directly instead of in SerialPortLib. >> >> Please advise. >> >> Thanks and regards, >> >> Heyi > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >