From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.1140.1587142950441603699 for ; Fri, 17 Apr 2020 10:02:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GE0FmJ2Y; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587142947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y1shb+dc/zLdcVKsGdgQXx1NvWJqlRsDOB8T86g6Waw=; b=GE0FmJ2YxcJs/4Pz9pre6oa4SY2sJszrV+8P5J7+fmOmfSy78KsEbmGeBnH8IhfxcN06cM PClh8FwrUnJS0dpDnHYusy8WYuqxuWF9X0XpE/uajlZl14tEnntkNFIptIABFNNCGs8a7T htO6pGPHndNdxweLR8oChNFrAoXqdbg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-391-SmocHeHSMcOu-i7mThhDUg-1; Fri, 17 Apr 2020 13:02:23 -0400 X-MC-Unique: SmocHeHSMcOu-i7mThhDUg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AECB214E0D3; Fri, 17 Apr 2020 17:01:52 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-253.ams2.redhat.com [10.36.113.253]) by smtp.corp.redhat.com (Postfix) with ESMTP id B6BF4116D92; Fri, 17 Apr 2020 17:01:51 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 07/13] OvmfPkg: add QemuFwCfgS3LibNull To: devel@edk2.groups.io, rebecca@bsdio.com Cc: Jordan Justen , Ard Biesheuvel References: <4bcc9055d068dadb3dac66d72fb463bb37472251.1586991816.git.rebecca@bsdio.com> From: "Laszlo Ersek" Message-ID: Date: Fri, 17 Apr 2020 19:01:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4bcc9055d068dadb3dac66d72fb463bb37472251.1586991816.git.rebecca@bsdio.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 04/16/20 01:09, Rebecca Cran wrote: > Add a null implementation of QemuFwCfgS3Lib, for bhyve. > > Signed-off-by: Rebecca Cran > --- > .../PeiQemuFwCfgS3LibFwCfgNull.inf | 39 ++++ > .../QemuFwCfgS3BasePeiNull.c | 221 ++++++++++++++++++ > .../QemuFwCfgS3LibNull/QemuFwCfgS3PeiNull.c | 80 +++++++ > 3 files changed, 340 insertions(+) > create mode 100644 OvmfPkg/Library/QemuFwCfgS3LibNull/PeiQemuFwCfgS3LibFwCfgNull.inf > create mode 100644 OvmfPkg/Library/QemuFwCfgS3LibNull/QemuFwCfgS3BasePeiNull.c > create mode 100644 OvmfPkg/Library/QemuFwCfgS3LibNull/QemuFwCfgS3PeiNull.c My comment under patch#4 applies; just use OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.inf please. Thanks Laszlo