From: rebecca@bsdio.com
To: Andrew Fish <afish@apple.com>
Cc: devel@edk2.groups.io, vit9696@protonmail.com,
Mike Kinney <michael.d.kinney@intel.com>,
"lersek@redhat.com" <lersek@redhat.com>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>
Subject: Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro
Date: Fri, 16 Aug 2019 18:09:52 -0600 [thread overview]
Message-ID: <a4a8089e-de36-60e3-ddc4-173d32f6bcc8@bsdio.com> (raw)
In-Reply-To: <49AA4A1C-696C-478C-BECC-398B8B7A3534@apple.com>
On 2019-08-16 18:03, Andrew Fish wrote:
> It is also interesting in the context of our CI as we could pick oldest and newest version from every compiler family for the CI build test.
Yes, that's going to be important. Given
https://docs.microsoft.com/en-us/cpp/porting/visual-cpp-change-history-2003-2015?view=vs-2019,
I suspect support for VS2008 might already have been broken, since it
reports that "static_assert" was introduced in Visual Studio 2010 - and
we use it in BaseTools/Source/C/Common/PcdValueCommon.h (the
_STATIC_ASSERT was added in September 2018):
#if defined(_MSC_EXTENSIONS)
#define __STATIC_ASSERT static_assert
#else
#define __STATIC_ASSERT _Static_assert
#endif
--
Rebecca Cran
next prev parent reply other threads:[~2019-08-17 0:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 8:16 [PATCH v2 0/1] MdePkg: Add STATIC_ASSERT macro vit9696
2019-08-13 8:16 ` [PATCH v2 1/1] " vit9696
2019-08-14 13:50 ` [edk2-devel] " Liming Gao
2019-08-14 15:47 ` Michael D Kinney
2019-08-14 16:22 ` Vitaly Cheptosv
2019-08-15 1:05 ` Yao, Jiewen
2019-08-15 1:59 ` Liming Gao
2019-08-15 2:22 ` Vitaly Cheptosv
2019-08-15 7:36 ` Yao, Jiewen
2019-08-16 16:33 ` Laszlo Ersek
2019-08-16 17:23 ` Vitaly Cheptsov
2019-08-16 19:38 ` Laszlo Ersek
2019-08-16 20:19 ` Laszlo Ersek
2019-08-16 21:04 ` Michael D Kinney
2019-08-16 21:40 ` Vitaly Cheptsov
2019-08-16 22:23 ` rebecca
2019-08-16 22:58 ` Andrew Fish
2019-08-16 23:34 ` Vitaly Cheptsov
2019-08-17 0:01 ` rebecca
2019-08-17 0:03 ` Andrew Fish
2019-08-17 0:09 ` rebecca [this message]
[not found] ` <15BB8D3E51450F1C.5853@groups.io>
2019-08-21 21:41 ` rebecca
2019-08-16 21:32 ` Vitaly Cheptsov
2019-08-16 16:28 ` Laszlo Ersek
2019-08-15 16:08 ` Michael D Kinney
2019-08-16 19:40 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4a8089e-de36-60e3-ddc4-173d32f6bcc8@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox