public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel] [PATCH v2 1/1] ReadMe.rst: Add Apache License 2.0 and update submodule list
@ 2023-11-02 15:59 Michael Kubacki
  2023-11-02 16:27 ` Pedro Falcato
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Michael Kubacki @ 2023-11-02 15:59 UTC (permalink / raw)
  To: devel
  Cc: Andrew Fish, Laszlo Ersek, Leif Lindholm, Michael D Kinney,
	Pedro Falcato, Sean Brogan

From: Michael Kubacki <michael.kubacki@microsoft.com>

- Adds Apache License 2.0 as an acceptable source license per
  discussion in https://edk2.groups.io/g/devel/message/110226
- Updates the URL for existing licenses to match the current path
  used by opensource.org.
- The submodule list in this file is stale and is very prone to
  being forgotten. The list of submodules in the submodules setion
  is replaced with a link to .gitmodules which has an active list
  of submodules at any given time.

Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Pedro Falcato <pedro.falcato@gmail.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Acked-by: Pedro Falcato <pedro.falcato@gmail.com>
---

Notes:
    v2 changes:
    
    - Add R-b and A-b tags
    - Update exisitng license URLs from http to https
    - Rework submodule section to remove unnecessary text and
      move the ArmSoftFloatLib note to the bottom of the section.

 ReadMe.rst | 31 ++++++++------------
 1 file changed, 13 insertions(+), 18 deletions(-)

diff --git a/ReadMe.rst b/ReadMe.rst
index ed1d4822459b..06fb122ef382 100644
--- a/ReadMe.rst
+++ b/ReadMe.rst
@@ -134,11 +134,12 @@ To make a contribution to a TianoCore project, follow these steps.
     copyright license as the base project. When that is not possible,
     then contributions using the following licenses can be accepted:
 
--  BSD (2-clause): http://opensource.org/licenses/BSD-2-Clause
--  BSD (3-clause): http://opensource.org/licenses/BSD-3-Clause
--  MIT: http://opensource.org/licenses/MIT
--  Python-2.0: http://opensource.org/licenses/Python-2.0
--  Zlib: http://opensource.org/licenses/Zlib
+-  Apache License, Version 2.0: https://opensource.org/license/apache-2-0/
+-  BSD (2-clause): https://opensource.org/license/BSD-2-Clause
+-  BSD (3-clause): https://opensource.org/license/BSD-3-Clause
+-  MIT: https://opensource.org/license/MIT
+-  Python-2.0: https://opensource.org/license/Python-2.0
+-  Zlib: https://opensource.org/license/Zlib
 
 For documentation:
 
@@ -243,19 +244,7 @@ Definitions for sample patch email
 Submodules
 ----------
 
-Submodule in EDK II is allowed but submodule chain should be avoided
-as possible as we can. Currently EDK II contains the following submodules
-
--  CryptoPkg/Library/OpensslLib/openssl
--  ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
--  MdeModulePkg/Universal/RegularExpressionDxe/oniguruma
--  MdeModulePkg/Library/BrotliCustomDecompressLib/brotli
--  BaseTools/Source/C/BrotliCompress/brotli
-
-ArmSoftFloatLib is actually required by OpensslLib. It's inevitable
-in openssl-1.1.1 (since stable201905) for floating point parameter
-conversion, but should be dropped once there's no such need in future
-release of openssl.
+The current submodules used in EDK II are in `.gitmodules <.gitmodules>`__.
 
 To get a full, buildable EDK II repository, use following steps of git
 command
@@ -283,6 +272,12 @@ dependency on being able to reach servers we do not actually want
 any code from, as well as needlessly downloading code we will not
 use.
 
+**Submodule Notes**
+
+ArmSoftFloatLib is required by OpensslLib. It's inevitable in openssl-1.1.1
+(since stable201905) for floating point parameter conversion, but should be
+dropped once there's no such need in future release of openssl.
+
 .. ===================================================================
 .. This is a bunch of directives to make the README file more readable
 .. ===================================================================
-- 
2.42.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110560): https://edk2.groups.io/g/devel/message/110560
Mute This Topic: https://groups.io/mt/102345483/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] [PATCH v2 1/1] ReadMe.rst: Add Apache License 2.0 and update submodule list
  2023-11-02 15:59 [edk2-devel] [PATCH v2 1/1] ReadMe.rst: Add Apache License 2.0 and update submodule list Michael Kubacki
@ 2023-11-02 16:27 ` Pedro Falcato
  2023-11-02 16:41 ` Michael D Kinney
  2023-11-03  6:00 ` Laszlo Ersek
  2 siblings, 0 replies; 5+ messages in thread
From: Pedro Falcato @ 2023-11-02 16:27 UTC (permalink / raw)
  To: mikuback
  Cc: devel, Andrew Fish, Laszlo Ersek, Leif Lindholm, Michael D Kinney,
	Sean Brogan

On Thu, Nov 2, 2023 at 3:59 PM <mikuback@linux.microsoft.com> wrote:
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> - Adds Apache License 2.0 as an acceptable source license per
>   discussion in https://edk2.groups.io/g/devel/message/110226
> - Updates the URL for existing licenses to match the current path
>   used by opensource.org.
> - The submodule list in this file is stale and is very prone to
>   being forgotten. The list of submodules in the submodules setion
>   is replaced with a link to .gitmodules which has an active list
>   of submodules at any given time.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Pedro Falcato <pedro.falcato@gmail.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Acked-by: Pedro Falcato <pedro.falcato@gmail.com>
> ---
>
> Notes:
>     v2 changes:
>
>     - Add R-b and A-b tags
>     - Update exisitng license URLs from http to https
>     - Rework submodule section to remove unnecessary text and
>       move the ArmSoftFloatLib note to the bottom of the section.
>
>  ReadMe.rst | 31 ++++++++------------
>  1 file changed, 13 insertions(+), 18 deletions(-)
>
> diff --git a/ReadMe.rst b/ReadMe.rst
> index ed1d4822459b..06fb122ef382 100644
> --- a/ReadMe.rst
> +++ b/ReadMe.rst
> @@ -134,11 +134,12 @@ To make a contribution to a TianoCore project, follow these steps.
>      copyright license as the base project. When that is not possible,
>      then contributions using the following licenses can be accepted:
>
> --  BSD (2-clause): http://opensource.org/licenses/BSD-2-Clause
> --  BSD (3-clause): http://opensource.org/licenses/BSD-3-Clause
> --  MIT: http://opensource.org/licenses/MIT
> --  Python-2.0: http://opensource.org/licenses/Python-2.0
> --  Zlib: http://opensource.org/licenses/Zlib
> +-  Apache License, Version 2.0: https://opensource.org/license/apache-2-0/
> +-  BSD (2-clause): https://opensource.org/license/BSD-2-Clause
> +-  BSD (3-clause): https://opensource.org/license/BSD-3-Clause
> +-  MIT: https://opensource.org/license/MIT
> +-  Python-2.0: https://opensource.org/license/Python-2.0
> +-  Zlib: https://opensource.org/license/Zlib
>
>  For documentation:
>
> @@ -243,19 +244,7 @@ Definitions for sample patch email
>  Submodules
>  ----------
>
> -Submodule in EDK II is allowed but submodule chain should be avoided
> -as possible as we can. Currently EDK II contains the following submodules
> -
> --  CryptoPkg/Library/OpensslLib/openssl
> --  ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
> --  MdeModulePkg/Universal/RegularExpressionDxe/oniguruma
> --  MdeModulePkg/Library/BrotliCustomDecompressLib/brotli
> --  BaseTools/Source/C/BrotliCompress/brotli
> -
> -ArmSoftFloatLib is actually required by OpensslLib. It's inevitable
> -in openssl-1.1.1 (since stable201905) for floating point parameter
> -conversion, but should be dropped once there's no such need in future
> -release of openssl.
> +The current submodules used in EDK II are in `.gitmodules <.gitmodules>`__.
>
>  To get a full, buildable EDK II repository, use following steps of git
>  command
> @@ -283,6 +272,12 @@ dependency on being able to reach servers we do not actually want
>  any code from, as well as needlessly downloading code we will not
>  use.
>
> +**Submodule Notes**
> +
> +ArmSoftFloatLib is required by OpensslLib. It's inevitable in openssl-1.1.1
> +(since stable201905) for floating point parameter conversion, but should be
> +dropped once there's no such need in future release of openssl.
> +
>  .. ===================================================================
>  .. This is a bunch of directives to make the README file more readable
>  .. ===================================================================
> --
> 2.42.0.windows.2
>

Looks great, thanks!

-- 
Pedro


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110562): https://edk2.groups.io/g/devel/message/110562
Mute This Topic: https://groups.io/mt/102345483/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] [PATCH v2 1/1] ReadMe.rst: Add Apache License 2.0 and update submodule list
  2023-11-02 15:59 [edk2-devel] [PATCH v2 1/1] ReadMe.rst: Add Apache License 2.0 and update submodule list Michael Kubacki
  2023-11-02 16:27 ` Pedro Falcato
@ 2023-11-02 16:41 ` Michael D Kinney
  2023-11-03  6:00 ` Laszlo Ersek
  2 siblings, 0 replies; 5+ messages in thread
From: Michael D Kinney @ 2023-11-02 16:41 UTC (permalink / raw)
  To: mikuback@linux.microsoft.com, devel@edk2.groups.io
  Cc: Andrew Fish, Laszlo Ersek, Leif Lindholm, Pedro Falcato,
	Sean Brogan, Kinney, Michael D

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>


> -----Original Message-----
> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> Sent: Thursday, November 2, 2023 8:59 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>;
> Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Pedro Falcato <pedro.falcato@gmail.com>;
> Sean Brogan <sean.brogan@microsoft.com>
> Subject: [PATCH v2 1/1] ReadMe.rst: Add Apache License 2.0 and update
> submodule list
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> - Adds Apache License 2.0 as an acceptable source license per
>   discussion in https://edk2.groups.io/g/devel/message/110226
> - Updates the URL for existing licenses to match the current path
>   used by opensource.org.
> - The submodule list in this file is stale and is very prone to
>   being forgotten. The list of submodules in the submodules setion
>   is replaced with a link to .gitmodules which has an active list
>   of submodules at any given time.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Pedro Falcato <pedro.falcato@gmail.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Acked-by: Pedro Falcato <pedro.falcato@gmail.com>
> ---
> 
> Notes:
>     v2 changes:
> 
>     - Add R-b and A-b tags
>     - Update exisitng license URLs from http to https
>     - Rework submodule section to remove unnecessary text and
>       move the ArmSoftFloatLib note to the bottom of the section.
> 
>  ReadMe.rst | 31 ++++++++------------
>  1 file changed, 13 insertions(+), 18 deletions(-)
> 
> diff --git a/ReadMe.rst b/ReadMe.rst
> index ed1d4822459b..06fb122ef382 100644
> --- a/ReadMe.rst
> +++ b/ReadMe.rst
> @@ -134,11 +134,12 @@ To make a contribution to a TianoCore project,
> follow these steps.
>      copyright license as the base project. When that is not possible,
>      then contributions using the following licenses can be accepted:
> 
> --  BSD (2-clause): http://opensource.org/licenses/BSD-2-Clause
> --  BSD (3-clause): http://opensource.org/licenses/BSD-3-Clause
> --  MIT: http://opensource.org/licenses/MIT
> --  Python-2.0: http://opensource.org/licenses/Python-2.0
> --  Zlib: http://opensource.org/licenses/Zlib
> +-  Apache License, Version 2.0:
> https://opensource.org/license/apache-2-0/
> +-  BSD (2-clause): https://opensource.org/license/BSD-2-Clause
> +-  BSD (3-clause): https://opensource.org/license/BSD-3-Clause
> +-  MIT: https://opensource.org/license/MIT
> +-  Python-2.0: https://opensource.org/license/Python-2.0
> +-  Zlib: https://opensource.org/license/Zlib
> 
>  For documentation:
> 
> @@ -243,19 +244,7 @@ Definitions for sample patch email
>  Submodules
>  ----------
> 
> -Submodule in EDK II is allowed but submodule chain should be avoided
> -as possible as we can. Currently EDK II contains the following
> submodules
> -
> --  CryptoPkg/Library/OpensslLib/openssl
> --  ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
> --  MdeModulePkg/Universal/RegularExpressionDxe/oniguruma
> --  MdeModulePkg/Library/BrotliCustomDecompressLib/brotli
> --  BaseTools/Source/C/BrotliCompress/brotli
> -
> -ArmSoftFloatLib is actually required by OpensslLib. It's inevitable
> -in openssl-1.1.1 (since stable201905) for floating point parameter
> -conversion, but should be dropped once there's no such need in future
> -release of openssl.
> +The current submodules used in EDK II are in `.gitmodules
> <.gitmodules>`__.
> 
>  To get a full, buildable EDK II repository, use following steps of
> git
>  command
> @@ -283,6 +272,12 @@ dependency on being able to reach servers we do
> not actually want
>  any code from, as well as needlessly downloading code we will not
>  use.
> 
> +**Submodule Notes**
> +
> +ArmSoftFloatLib is required by OpensslLib. It's inevitable in
> openssl-1.1.1
> +(since stable201905) for floating point parameter conversion, but
> should be
> +dropped once there's no such need in future release of openssl.
> +
>  ..
> ===================================================================
>  .. This is a bunch of directives to make the README file more
> readable
>  ..
> ===================================================================
> --
> 2.42.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110563): https://edk2.groups.io/g/devel/message/110563
Mute This Topic: https://groups.io/mt/102345483/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] [PATCH v2 1/1] ReadMe.rst: Add Apache License 2.0 and update submodule list
       [not found] <1793D9A65F755370.11290@groups.io>
@ 2023-11-02 19:00 ` Michael Kubacki
  0 siblings, 0 replies; 5+ messages in thread
From: Michael Kubacki @ 2023-11-02 19:00 UTC (permalink / raw)
  To: devel
  Cc: Andrew Fish, Laszlo Ersek, Leif Lindholm, Michael D Kinney,
	Pedro Falcato, Sean Brogan

Commit 8da978bf68535ec9fc41f400f22f09b033dd535a

On 11/2/2023 11:59 AM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> - Adds Apache License 2.0 as an acceptable source license per
>    discussion in https://edk2.groups.io/g/devel/message/110226
> - Updates the URL for existing licenses to match the current path
>    used by opensource.org.
> - The submodule list in this file is stale and is very prone to
>    being forgotten. The list of submodules in the submodules setion
>    is replaced with a link to .gitmodules which has an active list
>    of submodules at any given time.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Pedro Falcato <pedro.falcato@gmail.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Acked-by: Pedro Falcato <pedro.falcato@gmail.com>
> ---
> 
> Notes:
>      v2 changes:
>      
>      - Add R-b and A-b tags
>      - Update exisitng license URLs from http to https
>      - Rework submodule section to remove unnecessary text and
>        move the ArmSoftFloatLib note to the bottom of the section.
> 
>   ReadMe.rst | 31 ++++++++------------
>   1 file changed, 13 insertions(+), 18 deletions(-)
> 
> diff --git a/ReadMe.rst b/ReadMe.rst
> index ed1d4822459b..06fb122ef382 100644
> --- a/ReadMe.rst
> +++ b/ReadMe.rst
> @@ -134,11 +134,12 @@ To make a contribution to a TianoCore project, follow these steps.
>       copyright license as the base project. When that is not possible,
>       then contributions using the following licenses can be accepted:
>   
> --  BSD (2-clause): http://opensource.org/licenses/BSD-2-Clause
> --  BSD (3-clause): http://opensource.org/licenses/BSD-3-Clause
> --  MIT: http://opensource.org/licenses/MIT
> --  Python-2.0: http://opensource.org/licenses/Python-2.0
> --  Zlib: http://opensource.org/licenses/Zlib
> +-  Apache License, Version 2.0: https://opensource.org/license/apache-2-0/
> +-  BSD (2-clause): https://opensource.org/license/BSD-2-Clause
> +-  BSD (3-clause): https://opensource.org/license/BSD-3-Clause
> +-  MIT: https://opensource.org/license/MIT
> +-  Python-2.0: https://opensource.org/license/Python-2.0
> +-  Zlib: https://opensource.org/license/Zlib
>   
>   For documentation:
>   
> @@ -243,19 +244,7 @@ Definitions for sample patch email
>   Submodules
>   ----------
>   
> -Submodule in EDK II is allowed but submodule chain should be avoided
> -as possible as we can. Currently EDK II contains the following submodules
> -
> --  CryptoPkg/Library/OpensslLib/openssl
> --  ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
> --  MdeModulePkg/Universal/RegularExpressionDxe/oniguruma
> --  MdeModulePkg/Library/BrotliCustomDecompressLib/brotli
> --  BaseTools/Source/C/BrotliCompress/brotli
> -
> -ArmSoftFloatLib is actually required by OpensslLib. It's inevitable
> -in openssl-1.1.1 (since stable201905) for floating point parameter
> -conversion, but should be dropped once there's no such need in future
> -release of openssl.
> +The current submodules used in EDK II are in `.gitmodules <.gitmodules>`__.
>   
>   To get a full, buildable EDK II repository, use following steps of git
>   command
> @@ -283,6 +272,12 @@ dependency on being able to reach servers we do not actually want
>   any code from, as well as needlessly downloading code we will not
>   use.
>   
> +**Submodule Notes**
> +
> +ArmSoftFloatLib is required by OpensslLib. It's inevitable in openssl-1.1.1
> +(since stable201905) for floating point parameter conversion, but should be
> +dropped once there's no such need in future release of openssl.
> +
>   .. ===================================================================
>   .. This is a bunch of directives to make the README file more readable
>   .. ===================================================================


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110564): https://edk2.groups.io/g/devel/message/110564
Mute This Topic: https://groups.io/mt/102345483/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] [PATCH v2 1/1] ReadMe.rst: Add Apache License 2.0 and update submodule list
  2023-11-02 15:59 [edk2-devel] [PATCH v2 1/1] ReadMe.rst: Add Apache License 2.0 and update submodule list Michael Kubacki
  2023-11-02 16:27 ` Pedro Falcato
  2023-11-02 16:41 ` Michael D Kinney
@ 2023-11-03  6:00 ` Laszlo Ersek
  2 siblings, 0 replies; 5+ messages in thread
From: Laszlo Ersek @ 2023-11-03  6:00 UTC (permalink / raw)
  To: mikuback, devel
  Cc: Andrew Fish, Leif Lindholm, Michael D Kinney, Pedro Falcato,
	Sean Brogan

On 11/2/23 16:59, mikuback@linux.microsoft.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> - Adds Apache License 2.0 as an acceptable source license per
>   discussion in https://edk2.groups.io/g/devel/message/110226
> - Updates the URL for existing licenses to match the current path
>   used by opensource.org.
> - The submodule list in this file is stale and is very prone to
>   being forgotten. The list of submodules in the submodules setion
>   is replaced with a link to .gitmodules which has an active list
>   of submodules at any given time.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Pedro Falcato <pedro.falcato@gmail.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Acked-by: Pedro Falcato <pedro.falcato@gmail.com>
> ---
> 
> Notes:
>     v2 changes:
>     
>     - Add R-b and A-b tags
>     - Update exisitng license URLs from http to https
>     - Rework submodule section to remove unnecessary text and
>       move the ArmSoftFloatLib note to the bottom of the section.
> 
>  ReadMe.rst | 31 ++++++++------------
>  1 file changed, 13 insertions(+), 18 deletions(-)
> 
> diff --git a/ReadMe.rst b/ReadMe.rst
> index ed1d4822459b..06fb122ef382 100644
> --- a/ReadMe.rst
> +++ b/ReadMe.rst
> @@ -134,11 +134,12 @@ To make a contribution to a TianoCore project, follow these steps.
>      copyright license as the base project. When that is not possible,
>      then contributions using the following licenses can be accepted:
>  
> --  BSD (2-clause): http://opensource.org/licenses/BSD-2-Clause
> --  BSD (3-clause): http://opensource.org/licenses/BSD-3-Clause
> --  MIT: http://opensource.org/licenses/MIT
> --  Python-2.0: http://opensource.org/licenses/Python-2.0
> --  Zlib: http://opensource.org/licenses/Zlib
> +-  Apache License, Version 2.0: https://opensource.org/license/apache-2-0/
> +-  BSD (2-clause): https://opensource.org/license/BSD-2-Clause
> +-  BSD (3-clause): https://opensource.org/license/BSD-3-Clause
> +-  MIT: https://opensource.org/license/MIT
> +-  Python-2.0: https://opensource.org/license/Python-2.0
> +-  Zlib: https://opensource.org/license/Zlib
>  
>  For documentation:
>  
> @@ -243,19 +244,7 @@ Definitions for sample patch email
>  Submodules
>  ----------
>  
> -Submodule in EDK II is allowed but submodule chain should be avoided
> -as possible as we can. Currently EDK II contains the following submodules
> -
> --  CryptoPkg/Library/OpensslLib/openssl
> --  ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
> --  MdeModulePkg/Universal/RegularExpressionDxe/oniguruma
> --  MdeModulePkg/Library/BrotliCustomDecompressLib/brotli
> --  BaseTools/Source/C/BrotliCompress/brotli
> -
> -ArmSoftFloatLib is actually required by OpensslLib. It's inevitable
> -in openssl-1.1.1 (since stable201905) for floating point parameter
> -conversion, but should be dropped once there's no such need in future
> -release of openssl.
> +The current submodules used in EDK II are in `.gitmodules <.gitmodules>`__.
>  
>  To get a full, buildable EDK II repository, use following steps of git
>  command
> @@ -283,6 +272,12 @@ dependency on being able to reach servers we do not actually want
>  any code from, as well as needlessly downloading code we will not
>  use.
>  
> +**Submodule Notes**
> +
> +ArmSoftFloatLib is required by OpensslLib. It's inevitable in openssl-1.1.1
> +(since stable201905) for floating point parameter conversion, but should be
> +dropped once there's no such need in future release of openssl.
> +
>  .. ===================================================================
>  .. This is a bunch of directives to make the README file more readable
>  .. ===================================================================

Looks good, thanks.

I would have preserved the stated preference against "submodule chains",
but I'm unsure how much that preference has mattered in practice thus
far, so don't send v3 just because of that. My R-b stands.

Thanks!
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110607): https://edk2.groups.io/g/devel/message/110607
Mute This Topic: https://groups.io/mt/102345483/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-11-03  6:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-02 15:59 [edk2-devel] [PATCH v2 1/1] ReadMe.rst: Add Apache License 2.0 and update submodule list Michael Kubacki
2023-11-02 16:27 ` Pedro Falcato
2023-11-02 16:41 ` Michael D Kinney
2023-11-03  6:00 ` Laszlo Ersek
     [not found] <1793D9A65F755370.11290@groups.io>
2023-11-02 19:00 ` Michael Kubacki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox