From: "Laszlo Ersek" <lersek@redhat.com>
To: Hao Wu <hao.a.wu@intel.com>, devel@edk2.groups.io
Cc: Jordan Justen <jordan.l.justen@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
David Woodhouse <dwmw2@infradead.org>, Ray Ni <ray.ni@intel.com>
Subject: Re: [PATCH v2 0/8] Duplicate 8259/8254 components in OvmfPkg
Date: Wed, 10 Apr 2019 18:25:39 +0200 [thread overview]
Message-ID: <a4be5e63-41a2-5b37-5b39-ee90466e5578@redhat.com> (raw)
In-Reply-To: <20190410010628.19708-1-hao.a.wu@intel.com>
On 04/10/19 03:06, Hao Wu wrote:
> This series is also available at:
> https://github.com/hwu25/edk2/tree/ovmf_8259_8254_v2
>
>
> V2 changes:
>
> Due to the file license change, rebase the whole series onto the tip of
> the master branch. The 'Contributed-under' tag is removed from the log
> messages as well.
>
> The V2 series keeps all the 'Reviewed-by' tags from Laszlo from the
> previous version of the series.
I skimmed this version briefly, with an eye towards my v1 requests. The
v2 series looks fine to me, ready for pushing.
Thanks!
Laszlo
>
>
> V1 history:
>
> As a sub-task to remove the IntelFrameworkPkg (BZ-1604),
>
> 8259InterruptControllerDxe driver (PcAtChipsetPkg)
> Legacy8259 protocol (IntelFrameworkPkg)
> 8254TimerDxe driver (PcAtChipsetPkg)
>
> will be removed in the near future. Meanwhile, OVMF will still require
> those components (due to CSM support & HPET emulation stability concern).
>
> Thus, the series will copy the below 8259/8254 components:
>
> A. 8259InterruptControllerDxe driver (PcAtChipsetPkg)
> B. Two 8259 related PCDs (PcAtChipsetPkg)
> C. Legacy8259 protocol (IntelFrameworkPkg)
> D. 8254TimerDxe driver (PcAtChipsetPkg)
>
> in the OvmfPkg to address the above-mentioned issue.
>
>
> Tests done for the proposed series:
>
> A. OvmfPkg build pass for VS2015 & GCC5 tool chains;
> B. Boot to Shell with commands:
> qemu-system-x86_64.exe -pflash <SOME_PATH>\OVMF.fd -debugcon file:boot.log -global isa-debugcon.iobase=0x402
> qemu-system-x86_64.exe -machine q35 -pflash <SOME_PATH>\OVMF.fd -debugcon file:boot.log -global isa-debugcon.iobase=0x402
> C. 'stall X' command under Shell to verify the timer is working properly.
>
>
> (Please note that there will be a subsequent patch to remove the 8259/8254
> components after platforms dropping the dependencies on them.)
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Ray Ni <ray.ni@intel.com>
>
>
> Hao Wu (8):
> OvmfPkg: Copy 8259InterruptControllerDxe driver from PcAtChipsetPkg
> OvmfPkg: Copy Legacy8259 protocol definitions from IntelFrameworkPkg
> OvmfPkg/OvmfPkg.dec: Add 8259-related PCDs in OVMF DEC file
> OvmfPkg/8259InterruptControllerDxe: Update to make it build for OVMF
> OvmfPkg/AcpiPlatformDxe: Consume the 8259 PCD defined in OvmfPkg
> OvmfPkg: Copy 8254TimerDxe driver from PcAtChipsetPkg
> OvmfPkg/8254TimerDxe: Update to make it build for OVMF
> OvmfPkg: Update DSC/FDF files to consume 8259/8254 drivers in OvmfPkg
>
> OvmfPkg/OvmfPkg.dec | 29 +-
> OvmfPkg/OvmfPkgIa32.dsc | 6 +-
> OvmfPkg/OvmfPkgIa32X64.dsc | 6 +-
> OvmfPkg/OvmfPkgX64.dsc | 6 +-
> OvmfPkg/OvmfPkgIa32.fdf | 4 +-
> OvmfPkg/OvmfPkgIa32X64.fdf | 4 +-
> OvmfPkg/OvmfPkgX64.fdf | 4 +-
> OvmfPkg/8254TimerDxe/8254Timer.inf | 42 ++
> OvmfPkg/8259InterruptControllerDxe/8259.inf | 45 ++
> OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 5 +-
> OvmfPkg/8254TimerDxe/Timer.h | 185 ++++++
> OvmfPkg/8259InterruptControllerDxe/8259.h | 218 +++++++
> OvmfPkg/Include/Protocol/Legacy8259.h | 291 +++++++++
> OvmfPkg/8254TimerDxe/Timer.c | 401 +++++++++++++
> OvmfPkg/8259InterruptControllerDxe/8259.c | 622 ++++++++++++++++++++
> OvmfPkg/8254TimerDxe/Timer.uni | 16 +
> OvmfPkg/8254TimerDxe/TimerExtra.uni | 14 +
> OvmfPkg/8259InterruptControllerDxe/Legacy8259.uni | 16 +
> OvmfPkg/8259InterruptControllerDxe/Legacy8259Extra.uni | 14 +
> 19 files changed, 1909 insertions(+), 19 deletions(-)
> create mode 100644 OvmfPkg/8254TimerDxe/8254Timer.inf
> create mode 100644 OvmfPkg/8259InterruptControllerDxe/8259.inf
> create mode 100644 OvmfPkg/8254TimerDxe/Timer.h
> create mode 100644 OvmfPkg/8259InterruptControllerDxe/8259.h
> create mode 100644 OvmfPkg/Include/Protocol/Legacy8259.h
> create mode 100644 OvmfPkg/8254TimerDxe/Timer.c
> create mode 100644 OvmfPkg/8259InterruptControllerDxe/8259.c
> create mode 100644 OvmfPkg/8254TimerDxe/Timer.uni
> create mode 100644 OvmfPkg/8254TimerDxe/TimerExtra.uni
> create mode 100644 OvmfPkg/8259InterruptControllerDxe/Legacy8259.uni
> create mode 100644 OvmfPkg/8259InterruptControllerDxe/Legacy8259Extra.uni
>
next prev parent reply other threads:[~2019-04-10 16:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 1:06 [PATCH v2 0/8] Duplicate 8259/8254 components in OvmfPkg Wu, Hao A
2019-04-10 1:06 ` [PATCH v2 1/8] OvmfPkg: Copy 8259InterruptControllerDxe driver from PcAtChipsetPkg Wu, Hao A
2019-04-10 1:06 ` [PATCH v2 2/8] OvmfPkg: Copy Legacy8259 protocol definitions from IntelFrameworkPkg Wu, Hao A
2019-04-10 1:06 ` [PATCH v2 3/8] OvmfPkg/OvmfPkg.dec: Add 8259-related PCDs in OVMF DEC file Wu, Hao A
2019-04-10 16:16 ` [edk2-devel] " Laszlo Ersek
2019-04-10 1:06 ` [PATCH v2 4/8] OvmfPkg/8259InterruptControllerDxe: Update to make it build for OVMF Wu, Hao A
2019-04-10 16:19 ` [edk2-devel] " Laszlo Ersek
2019-04-10 1:06 ` [PATCH v2 5/8] OvmfPkg/AcpiPlatformDxe: Consume the 8259 PCD defined in OvmfPkg Wu, Hao A
2019-04-10 1:06 ` [PATCH v2 6/8] OvmfPkg: Copy 8254TimerDxe driver from PcAtChipsetPkg Wu, Hao A
2019-04-10 1:06 ` [PATCH v2 7/8] OvmfPkg/8254TimerDxe: Update to make it build for OVMF Wu, Hao A
2019-04-10 16:22 ` [edk2-devel] " Laszlo Ersek
2019-04-10 1:06 ` [PATCH v2 8/8] OvmfPkg: Update DSC/FDF files to consume 8259/8254 drivers in OvmfPkg Wu, Hao A
2019-04-10 16:25 ` Laszlo Ersek [this message]
2019-04-11 1:05 ` [PATCH v2 0/8] Duplicate 8259/8254 components " Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4be5e63-41a2-5b37-5b39-ee90466e5578@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox