[PATCH 1/1] OvmfPkg/OvmfPkg.dec: Adjust PcdMptScsiStallPerPollUsec

[PATCH 1/1] OvmfPkg/OvmfPkg.dec: Adjust PcdMptScsiStallPerPollUsec

[Gary Lin]

The toke value of PcdMptScsiStallPerPollUsec should be 0x3a since the
previous toke value is 0x39.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Liran Alon <liran.alon@oracle.com>
Cc: Nikita Leshenko <nikita.leshchenko@oracle.com>
Signed-off-by: Gary Lin <glin@suse.com>
---
 OvmfPkg/OvmfPkg.dec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
index 65bb2bb0eb4c..2b0f137cbcce 100644
--- a/OvmfPkg/OvmfPkg.dec
+++ b/OvmfPkg/OvmfPkg.dec
@@ -172,7 +172,7 @@ [PcdsFixedAtBuild]
   gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiMaxTargetLimit|7|UINT8|0x39
 
   ## Microseconds to stall between polling for MptScsi request result
-  gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiStallPerPollUsec|5|UINT32|0x40
+  gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiStallPerPollUsec|5|UINT32|0x3a
 
   gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageEventLogBase|0x0|UINT32|0x8
   gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageEventLogSize|0x0|UINT32|0x9
-- 
2.25.1

Re: [PATCH 1/1] OvmfPkg/OvmfPkg.dec: Adjust PcdMptScsiStallPerPollUsec

[Liran Alon]

On 15/07/2020 11:20, Gary Lin wrote:
> The toke value of PcdMptScsiStallPerPollUsec should be 0x3a since the
> previous toke value is 0x39.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Liran Alon <liran.alon@oracle.com>
> Cc: Nikita Leshenko <nikita.leshchenko@oracle.com>
> Signed-off-by: Gary Lin <glin@suse.com>
> ---
Reviewed-by: Liran Alon <liran.alon@oracle.com>
>   OvmfPkg/OvmfPkg.dec | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
> index 65bb2bb0eb4c..2b0f137cbcce 100644
> --- a/OvmfPkg/OvmfPkg.dec
> +++ b/OvmfPkg/OvmfPkg.dec
> @@ -172,7 +172,7 @@ [PcdsFixedAtBuild]
>     gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiMaxTargetLimit|7|UINT8|0x39
>   
>     ## Microseconds to stall between polling for MptScsi request result
> -  gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiStallPerPollUsec|5|UINT32|0x40
> +  gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiStallPerPollUsec|5|UINT32|0x3a
>   
>     gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageEventLogBase|0x0|UINT32|0x8
>     gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageEventLogSize|0x0|UINT32|0x9

Re: [PATCH 1/1] OvmfPkg/OvmfPkg.dec: Adjust PcdMptScsiStallPerPollUsec

[Laszlo Ersek]

On 07/15/20 10:20, Gary Lin wrote:
> The toke value of PcdMptScsiStallPerPollUsec should be 0x3a since the
> previous toke value is 0x39.
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Liran Alon <liran.alon@oracle.com>
> Cc: Nikita Leshenko <nikita.leshchenko@oracle.com>
> Signed-off-by: Gary Lin <glin@suse.com>
> ---
>  OvmfPkg/OvmfPkg.dec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
> index 65bb2bb0eb4c..2b0f137cbcce 100644
> --- a/OvmfPkg/OvmfPkg.dec
> +++ b/OvmfPkg/OvmfPkg.dec
> @@ -172,7 +172,7 @@ [PcdsFixedAtBuild]
>    gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiMaxTargetLimit|7|UINT8|0x39
>  
>    ## Microseconds to stall between polling for MptScsi request result
> -  gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiStallPerPollUsec|5|UINT32|0x40
> +  gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiStallPerPollUsec|5|UINT32|0x3a
>  
>    gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageEventLogBase|0x0|UINT32|0x8
>    gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageEventLogSize|0x0|UINT32|0x9
> 

Thank you for the patch!

I've updated the subject:

  OvmfPkg/OvmfPkg.dec: Adjust PcdMptScsiStallPerPollUsec token value

I've also fixed two typos in the commit message (s/toke value/token
value/, twice).

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

I'm trying to merge this via <https://github.com/tianocore/edk2/pull/797>.

But, the PR seems stalled -- github appears unable to find the very
commit that I just pushed with the branch.

And this time even <https://www.githubstatus.com/> seems to confirm the
issue -- it says "Some services are degraded". ... Oh wait, it's
progressed to an "incident" even:

https://www.githubstatus.com/incidents/phnch1rww464

Really frustrating. I've got stuff to do, and now I get to cirle back to
this merge request... when exactly? Sigh.

Laszlo

Re: [PATCH 1/1] OvmfPkg/OvmfPkg.dec: Adjust PcdMptScsiStallPerPollUsec

[Laszlo Ersek]

On 07/15/20 17:45, Laszlo Ersek wrote:
> On 07/15/20 10:20, Gary Lin wrote:
>> The toke value of PcdMptScsiStallPerPollUsec should be 0x3a since the
>> previous toke value is 0x39.
>>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Cc: Liran Alon <liran.alon@oracle.com>
>> Cc: Nikita Leshenko <nikita.leshchenko@oracle.com>
>> Signed-off-by: Gary Lin <glin@suse.com>
>> ---
>>  OvmfPkg/OvmfPkg.dec | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
>> index 65bb2bb0eb4c..2b0f137cbcce 100644
>> --- a/OvmfPkg/OvmfPkg.dec
>> +++ b/OvmfPkg/OvmfPkg.dec
>> @@ -172,7 +172,7 @@ [PcdsFixedAtBuild]
>>    gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiMaxTargetLimit|7|UINT8|0x39
>>  
>>    ## Microseconds to stall between polling for MptScsi request result
>> -  gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiStallPerPollUsec|5|UINT32|0x40
>> +  gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiStallPerPollUsec|5|UINT32|0x3a
>>  
>>    gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageEventLogBase|0x0|UINT32|0x8
>>    gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageEventLogSize|0x0|UINT32|0x9
>>
> 
> Thank you for the patch!
> 
> I've updated the subject:
> 
>   OvmfPkg/OvmfPkg.dec: Adjust PcdMptScsiStallPerPollUsec token value
> 
> I've also fixed two typos in the commit message (s/toke value/token
> value/, twice).
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> I'm trying to merge this via <https://github.com/tianocore/edk2/pull/797>.

Commit d9269d691388.

Thanks!
Laszlo