From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E2FDF78003C for ; Tue, 27 Feb 2024 16:02:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=h7knpfm8ZfWd+CawOXDBqVfJ9V6JaIUwbUPrhGrEKls=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709049761; v=1; b=T0eccXUsSbygRONF+0xXyKGn+NLglNuHezriJx5Su//1sYpiNcjHXZvJtLr6ptio1c07KkJG ioUwj95VrTWgaX9YGnxdTY48sPO4qiGvAo03axkkgShWIv57ROiKZIV99+IuXwkZMaSWmncdh8H 5JozGgicBGZlws7eIlRNGrn0= X-Received: by 127.0.0.2 with SMTP id l79dYY7687511xwJdkl3m1fw; Tue, 27 Feb 2024 08:02:41 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.15933.1709049760785994892 for ; Tue, 27 Feb 2024 08:02:40 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E7048DA7; Tue, 27 Feb 2024 08:03:18 -0800 (PST) X-Received: from [192.168.1.13] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6F1C33F762; Tue, 27 Feb 2024 08:02:39 -0800 (PST) Message-ID: Date: Tue, 27 Feb 2024 17:02:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 2/3] DynamicTablesPkg: Adds ACPI HPET Table generator To: Abdul Lateef Attar , devel@edk2.groups.io Cc: Abdul Lateef Attar , Sami Mujawar References: <2990ed3964382d88df2aed092a25fc796c5705b5.1708411357.git.AbdulLateef.Attar@amd.com> From: "PierreGondois" In-Reply-To: <2990ed3964382d88df2aed092a25fc796c5705b5.1708411357.git.AbdulLateef.Attar@amd.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: i8JtmtKi9V4klvX3UKslqIfqx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=T0eccXUs; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hello Abdul, From the HPET spec: """ For the case where there may be additional Event Timer Blocks implemented i= n the system, their base addresses would be described in ACPI Name space. """ So it seems it might be good (but not necessary) to to add a description in a SSDT/DSDT table of the object (with _HID=3DPNP0103). --- Same comment about than for the other patches about adding objects to the common Arch namespace.` On 2/20/24 07:48, Abdul Lateef Attar wrote: > From: Abdul Lateef Attar >=20 > Adds generic ACPI HPET table generator library. > Register/Deregister HPET table. > Update the HPET table during boot as per specification. >=20 > Cc: Sami Mujawar > Cc: Pierre Gondois > Signed-off-by: Abdul Lateef Attar > --- > DynamicTablesPkg/DynamicTables.dsc.inc | 2 + > DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 3 +- > DynamicTablesPkg/Include/AcpiTableGenerator.h | 1 + > .../Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf | 38 ++++ > .../Library/Acpi/AcpiHpetLib/HpetGenerator.c | 208 ++++++++++++++++++ > 5 files changed, 251 insertions(+), 1 deletion(-) > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLi= b.inf > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiHpetLib/HpetGenera= tor.c >=20 > diff --git a/DynamicTablesPkg/DynamicTables.dsc.inc b/DynamicTablesPkg/Dy= namicTables.dsc.inc > index 5ec9ffac06..af70785520 100644 > --- a/DynamicTablesPkg/DynamicTables.dsc.inc > +++ b/DynamicTablesPkg/DynamicTables.dsc.inc > @@ -35,6 +35,7 @@ > # Generators > # > DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf > + DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf > =20 > # > # Dynamic Table Factory Dxe > @@ -42,6 +43,7 @@ > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDx= e.inf { > > NULL|DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf > + NULL|DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf > } > =20 > [Components.ARM, Components.AARCH64] > diff --git a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml b/DynamicTablesPkg= /DynamicTablesPkg.ci.yaml > index 1ad5540e24..cacdaa1df6 100644 > --- a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml > +++ b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml > @@ -53,7 +53,8 @@ > "EmbeddedPkg/EmbeddedPkg.dec", > "DynamicTablesPkg/DynamicTablesPkg.dec", > "MdeModulePkg/MdeModulePkg.dec", > - "MdePkg/MdePkg.dec" > + "MdePkg/MdePkg.dec", > + "PcAtChipsetPkg/PcAtChipsetPkg.dec" > ], > # For host based unit tests > "AcceptableDependencies-HOST_APPLICATION":[ > diff --git a/DynamicTablesPkg/Include/AcpiTableGenerator.h b/DynamicTable= sPkg/Include/AcpiTableGenerator.h > index d0eda011c3..18b5f99f47 100644and=20 > --- a/DynamicTablesPkg/Include/AcpiTableGenerator.h > +++ b/DynamicTablesPkg/Include/AcpiTableGenerator.h > @@ -99,6 +99,7 @@ typedef enum StdAcpiTableId { > EStdAcpiTableIdSsdtCpuTopology, ///< SSDT Cpu Topology > EStdAcpiTableIdSsdtPciExpress, ///< SSDT Pci Express G= enerator > EStdAcpiTableIdPcct, ///< PCCT Generator > + EStdAcpiTableIdHpet, ///< HPET Generator > EStdAcpiTableIdMax > } ESTD_ACPI_TABLE_ID; > =20 > diff --git a/DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf b/= DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf > new file mode 100644 > index 0000000000..74a1358ffe > --- /dev/null > +++ b/DynamicTablesPkg/Library/Acpi/AcpiHpetLib/AcpiHpetLib.inf > @@ -0,0 +1,38 @@ > +## @file > +# HPET Table Generator > +# > +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved. > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > + > +[Defines] > + INF_VERSION =3D 1.27 > + BASE_NAME =3D AcpiHpetLib > + FILE_GUID =3D 4E75F653-C356-48B3-B32C-D1B901ECF90A > + VERSION_STRING =3D 1.0 > + MODULE_TYPE =3D DXE_DRIVER > + LIBRARY_CLASS =3D NULL|DXE_DRIVER > + CONSTRUCTOR =3D AcpiHpetLibConstructor > + DESTRUCTOR =3D AcpiHpetLibDestructor > + > +[Sources] > + HpetGenerator.c > + > +[Packages] > + DynamicTablesPkg/DynamicTablesPkg.dec > + EmbeddedPkg/EmbeddedPkg.dec I think the dependency could be deleted, along with: HpetGenerator.c:19:#include > + MdeModulePkg/MdeModulePkg.dec > + MdePkg/MdePkg.dec > + PcAtChipsetPkg/PcAtChipsetPkg.dec (for Sami) A dependency over the PcAtChipsetPkg is introduced here. > + > +[LibraryClasses] > + BaseLib > + DebugLib > + IoLib > + PcdLib > + > +[Pcd] > + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorId > + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision > + gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress [snip] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116053): https://edk2.groups.io/g/devel/message/116053 Mute This Topic: https://groups.io/mt/104463460/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-