From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=ryszard.knop@linux.intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AE987211C2805 for ; Wed, 30 Jan 2019 08:39:39 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 08:39:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,541,1539673200"; d="scan'208";a="142772345" Received: from linux.intel.com ([10.54.29.200]) by fmsmga001.fm.intel.com with ESMTP; 30 Jan 2019 08:39:38 -0800 Received: from torii (torii.igk.intel.com [10.102.24.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id DF6C25806C8; Wed, 30 Jan 2019 08:39:36 -0800 (PST) Message-ID: From: Ryszard Knop To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: kamil.kacperski@intel.com, eric.jin@intel.com, pawel.orlowski@intel.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com Date: Wed, 30 Jan 2019 17:39:34 +0100 In-Reply-To: <20181115023353.20159-18-ard.biesheuvel@linaro.org> References: <20181115023353.20159-1-ard.biesheuvel@linaro.org> <20181115023353.20159-18-ard.biesheuvel@linaro.org> Organization: Intel Corporation User-Agent: Evolution 3.30.4 Mime-Version: 1.0 Subject: Re: [PATCH edk2-staging 17/20] IntelUndiPkg/XGigUndiDxe: drop unused variables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 16:39:39 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:39:39 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:39:39 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:39:39 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Reviewed-by: Ryszard Knop On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote: > Drop some variables that are defined, assigned but never referenced. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > IntelUndiPkg/XGigUndiDxe/Decode.c | 3 --- > IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c | 4 ---- > IntelUndiPkg/XGigUndiDxe/Xgbe.c | 2 -- > 3 files changed, 9 deletions(-) > > diff --git a/IntelUndiPkg/XGigUndiDxe/Decode.c > b/IntelUndiPkg/XGigUndiDxe/Decode.c > index 5f37ce254872..c8dc3f4eb659 100644 > --- a/IntelUndiPkg/XGigUndiDxe/Decode.c > +++ b/IntelUndiPkg/XGigUndiDxe/Decode.c > @@ -1454,14 +1454,11 @@ UndiStatus ( > ) > { > PXE_DB_GET_STATUS * DbPtr; > - UINT16 i; > UINT32 IntStatus; > UINT16 NumEntries; > struct ixgbe_legacy_rx_desc *RxPtr; > bool LinkUp; > > - i = 0; > - > if (XgbeAdapter->DriverBusy) { > > //DEBUGPRINT (CRITICAL, ("ERROR: UndiStatus called when driver > busy\n")); > diff --git a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c > b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c > index 2aacb63ca158..df5238a3b55a 100644 > --- a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c > +++ b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c > @@ -197,7 +197,6 @@ GetNextRequestElement ( > ) > { > EFI_STRING StringPtr; > - EFI_STRING TmpPtr; > EFI_STATUS Status; > UINTN Length; > UINT8 * TmpBuffer; > @@ -226,9 +225,6 @@ GetNextRequestElement ( > return NULL; > } > > - // Back up the header of one > - TmpPtr = StringPtr; > - > StringPtr += StrLen (L"OFFSET="); > > // Get Offset > diff --git a/IntelUndiPkg/XGigUndiDxe/Xgbe.c > b/IntelUndiPkg/XGigUndiDxe/Xgbe.c > index 6769f2dc72ab..b3dbbd2b1d08 100644 > --- a/IntelUndiPkg/XGigUndiDxe/Xgbe.c > +++ b/IntelUndiPkg/XGigUndiDxe/Xgbe.c > @@ -1399,12 +1399,10 @@ XgbeInitialize ( > XGBE_DRIVER_DATA *XgbeAdapter > ) > { > - UINT32 * TempBar; > PXE_STATCODE PxeStatcode; > EFI_STATUS Status; > > PxeStatcode = PXE_STATCODE_SUCCESS; > - TempBar = NULL; > > ZeroMem ( > (VOID *)(UINTN)XgbeAdapter->RxRing.UnmappedAddress,