From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.5103.1655973973509358935 for ; Thu, 23 Jun 2022 01:46:13 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2257112FC; Thu, 23 Jun 2022 01:46:13 -0700 (PDT) Received: from [10.57.39.116] (unknown [10.57.39.116]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C776C3F792; Thu, 23 Jun 2022 01:46:10 -0700 (PDT) Message-ID: Date: Thu, 23 Jun 2022 10:45:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 0/7] Fix ACPI Low Power Idle states for RD platforms To: Pranav Madhu , "devel@edk2.groups.io" , Thomas Abraham Cc: Sami Mujawar , Ard Biesheuvel , nd References: <20220609181955.3018033-1-pranav.madhu@arm.com> <20106.1654980363404827972@groups.io> <236fa6e3-3945-dc4a-cb9a-3441bbf0ddbb@arm.com> From: "PierreGondois" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/22/22 07:39, Pranav Madhu wrote: > Hi Pierre, > > Thanks for reviewing this patch series. Please find my reply inline. > > Regards, > Pranav > >> -----Original Message----- >> From: Pierre Gondois >> Sent: Tuesday, June 21, 2022 2:15 PM >> To: devel@edk2.groups.io; Pranav Madhu ; >> Thomas Abraham >> Cc: Sami Mujawar ; Ard Biesheuvel >> ; nd >> Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 0/7] Fix ACPI Low >> Power Idle states for RD platforms >> >> Hello Pranav, >> Would it be possible to extend this change to the Juno aswell as the platform >> has a Null Residency Counter and doesn't support OS Initiated LPI ? > > It can be changed for Juno as well, but I do not have access to any Juno boards and this patch series is focusing on RD platforms. The Juno board update can be posted as a separate patch. > Ok sure. >> >> Another remark is that for RdV1MC, RdN2, RdV1 and RdN2Cfg1 platforms, >> CPUs don't need to be encapsulated anymore in cluster objects >> Cf: >> Device (CL00) { // Cluster 0 >> Name (_HID, "ACPI0010") >> Name (_UID, 0) >> ... >> } >> since Clusters don't have any additional information. But keeping them is >> correct aswell. > > These platforms have a minimal cluster logic but does not support low power states. But the cluster encapsulation represents the platform topology accurately. So it would be better to keep the cluster encapsulation. Ok yes, this was just so other people are aware of this. Reviewed-by: Pierre Gondois Regards, Pierre >>> ---------- >>> Groups.io Links: >>> >>> You receive all messages sent to this group. >>> >>> View/Reply Online (#90633) >>> | | Mute This Topic >>> | New Topic >>> >>> Your Subscription | >>> Contact Group Owner | >> Unsubscribe >>> [pierre.gondois@arm.com] >>> >>> _._,_._,_