From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.2837.1588232532338567841 for ; Thu, 30 Apr 2020 00:42:12 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A7931063; Thu, 30 Apr 2020 00:42:11 -0700 (PDT) Received: from [192.168.1.81] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 488A33F305; Thu, 30 Apr 2020 00:42:10 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , devel@edk2.groups.io, driver1998@foxmail.com Cc: leif@nuviainc.com, pete@akeo.ie References: <20200428050840.223-1-driver1998@foxmail.com> From: "Ard Biesheuvel" Message-ID: Date: Thu, 30 Apr 2020 09:42:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 4/28/20 1:25 PM, Philippe Mathieu-Daud=E9 wrote: > On 4/28/20 7:08 AM, GH Cao wrote: >> The original comment incorrectly named the PWM controller as Power=20 >> Management >> Contoller, this commit fixes it. >> >> Signed-off-by: GH Cao >> --- >> =A0 Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2= +- >> =A0 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git=20 >> a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h=20 >> b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h >> index e2581b8..2d7da75 100644 >> --- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h >> +++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h >> @@ -11,7 +11,7 @@ >> =A0 #ifndef __BCM2836_PWM_H__ >> =A0 #define __BCM2836_PWM_H__ >> -/* Power Management constants */ >> +/* PWM controller constants */ >> =A0 #define BCM2836_PWM_DMA_OFFSET=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 0x00007B00 >> =A0 #define BCM2836_PWM_DMA_BASE_ADDRESS =20 >> (BCM2836_SOC_REGISTERS + BCM2836_PWM_DMA_OFFSET) >> >=20 > Reviewed-by: Philippe Mathieu-Daude >=20 Thanks all Series pushed as 6e4ebde90186..1b2461ea7f2f