From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 21BE3209831CE for ; Wed, 1 Aug 2018 14:55:36 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 67F29402243B; Wed, 1 Aug 2018 21:55:35 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-122-129.rdu2.redhat.com [10.10.122.129]) by smtp.corp.redhat.com (Postfix) with ESMTP id CA3DC2026D68; Wed, 1 Aug 2018 21:55:34 +0000 (UTC) To: edk2-lists@mc2research.org, edk2-devel@lists.01.org References: <019f01d429bf$f3cbd060$db637120$@mc2research.org> From: Laszlo Ersek Message-ID: Date: Wed, 1 Aug 2018 23:55:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <019f01d429bf$f3cbd060$db637120$@mc2research.org> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 01 Aug 2018 21:55:35 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 01 Aug 2018 21:55:35 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: Undefined types referenced in MdePkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 21:55:36 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/01/18 19:49, edk2-lists@mc2research.org wrote: > When including MdePkg/Include/Library/HobLib.h in my project I get errors > indicating that the following types are undefined: > > * EFI_RESOURCE_TYPE, lines 206 and 231 > * EFI_RESOURCE_ATTRIBUTE_TYPE, lines 207 and 232 > > > > A similar thing is happening with MdePkg/Include/Protocol/FirmwareVolume2.h. > > * EFI_FV_FILE_ATTRIBUTES, lines 309, 443, 612 > > > > I updated my EDK II tree then searched the entire tree for these types. They > only show up in the locations mentioned above; never defined. > > > > Am I missing something or are these really undefined? > > > > I don't want to just disable these errors since that could hide a bigger > problem. IMO, the header files you mention should include the following files, respectively: - MdePkg/Include/Library/HobLib.h --> MdePkg/Include/Pi/PiHob.h - MdePkg/Include/Protocol/FirmwareVolume2.h --> MdePkg/Include/Pi/PiFirmwareVolume.h I'm firmly in the camp that believes that developers should not have to hunt down themselves the dependencies of the main API header file that they are actually interested in. Thanks Laszlo