Re: [edk2-devel] [PATCH v4 4/9] OvmfPkg/PciHostBridgeUtilityLib: Extend parameter list of InitRootBridge

["Jiahui Cen" <cenjiahui@huawei.com>]

Hi Laszlo,

On 2021/1/13 9:51, Laszlo Ersek wrote:
> On 01/12/21 10:45, Jiahui Cen via groups.io wrote:
>> Extend parameter list of PciHostBridgeUtilityInitRootBridge() with
>> DmaAbove4G and NoExtendedConfigSpace to prepare for support of ArmVirtPkg.
>>
>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059
>>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Cc: Anthony Perard <anthony.perard@citrix.com>
>> Cc: Julien Grall <julien@xen.org>
>> Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
>> Signed-off-by: Yubo Miao <miaoyubo@huawei.com>
>> ---
>>  OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf               |  1 +
>>  OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf |  3 -
>>  OvmfPkg/Include/Library/PciHostBridgeUtilityLib.h                   | 56 ++++++++++--------
>>  OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c                 |  5 ++
>>  OvmfPkg/Library/PciHostBridgeLib/XenSupport.c                       |  1 +
>>  OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c   | 62 +++++++++++---------
>>  6 files changed, 73 insertions(+), 55 deletions(-)
>>
>> diff --git a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf
>> index d09429d9f0fb..463c05c94b07 100644
>> --- a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf
>> +++ b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf
>> @@ -49,4 +49,5 @@ [Pcd]
>>    gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio32Size
>>    gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Base
>>    gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Size
>> +  gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId
>>    gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration
>> diff --git a/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf b/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf
>> index 32a10e99c3e0..4d6764b702f4 100644
>> --- a/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf
>> +++ b/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf
>> @@ -39,6 +39,3 @@ [LibraryClasses]
>>    DebugLib
>>    DevicePathLib
>>    MemoryAllocationLib
>> -
>> -[Pcd]
>> -  gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId
> 
> (1) According to my feedback under patch#3 in this series, I think the
> present patch will have to undo the PcdLib dependency as well(both INF
> file and #include).
> 

Will fix it.

Thanks,
Jiahui

> Please extend this patch accordingly; I'm ready to R-b then.
> 
> Thanks
> Laszlo
> 
> .
>