From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mx.groups.io with SMTP id smtpd.web10.4321.1610517698154243627 for ; Tue, 12 Jan 2021 22:01:38 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: huawei.com, ip: 45.249.212.190, mailfrom: cenjiahui@huawei.com) Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DFxcx3YKcz15rMB; Wed, 13 Jan 2021 14:00:33 +0800 (CST) Received: from [10.174.184.155] (10.174.184.155) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.498.0; Wed, 13 Jan 2021 14:01:26 +0800 Subject: Re: [edk2-devel] [PATCH v4 4/9] OvmfPkg/PciHostBridgeUtilityLib: Extend parameter list of InitRootBridge To: Laszlo Ersek , CC: Jordan Justen , Ard Biesheuvel , Rebecca Cran , Peter Grehan , Anthony Perard , "Julien Grall" , Leif Lindholm , Sami Mujawar , , , "Yubo Miao" References: <20210112094549.10238-1-cenjiahui@huawei.com> <20210112094549.10238-5-cenjiahui@huawei.com> <999d1820-08b7-5f57-75bc-2311b93f4b7d@redhat.com> From: "Jiahui Cen" Message-ID: Date: Wed, 13 Jan 2021 14:01:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <999d1820-08b7-5f57-75bc-2311b93f4b7d@redhat.com> X-Originating-IP: [10.174.184.155] X-CFilter-Loop: Reflected Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Laszlo, On 2021/1/13 9:51, Laszlo Ersek wrote: > On 01/12/21 10:45, Jiahui Cen via groups.io wrote: >> Extend parameter list of PciHostBridgeUtilityInitRootBridge() with >> DmaAbove4G and NoExtendedConfigSpace to prepare for support of ArmVirtPkg. >> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059 >> >> Cc: Jordan Justen >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: Anthony Perard >> Cc: Julien Grall >> Signed-off-by: Jiahui Cen >> Signed-off-by: Yubo Miao >> --- >> OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 1 + >> OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf | 3 - >> OvmfPkg/Include/Library/PciHostBridgeUtilityLib.h | 56 ++++++++++-------- >> OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 5 ++ >> OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 1 + >> OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c | 62 +++++++++++--------- >> 6 files changed, 73 insertions(+), 55 deletions(-) >> >> diff --git a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf >> index d09429d9f0fb..463c05c94b07 100644 >> --- a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf >> +++ b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf >> @@ -49,4 +49,5 @@ [Pcd] >> gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio32Size >> gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Base >> gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Size >> + gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId >> gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration >> diff --git a/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf b/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf >> index 32a10e99c3e0..4d6764b702f4 100644 >> --- a/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf >> +++ b/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf >> @@ -39,6 +39,3 @@ [LibraryClasses] >> DebugLib >> DevicePathLib >> MemoryAllocationLib >> - >> -[Pcd] >> - gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId > > (1) According to my feedback under patch#3 in this series, I think the > present patch will have to undo the PcdLib dependency as well(both INF > file and #include). > Will fix it. Thanks, Jiahui > Please extend this patch accordingly; I'm ready to R-b then. > > Thanks > Laszlo > > . >