From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web08.4197.1622104536965710939 for ; Thu, 27 May 2021 01:35:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ab/B/+Sp; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622104536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Te8pR0f8ez5F3aILm/YwV4KjHXZAzyEMnOBezzegJS8=; b=ab/B/+SperoQoAM4Fe9b9zk1T2bne+FzmzNIDqsdZ8Ql3jv7EzB54UL/SDBxpbkqzGK1nH UJXGtikyEa48DltK6rIVIcojLQe4uRJ76fYQ+zsDOcoNt/LbjTligivaIjPv4/cwgJ0nmH +8mGrA4XbpAC8SjQNfvTvKqPS45Z2cg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-604-sl1r3qdAPoinI7-KdoCZVw-1; Thu, 27 May 2021 04:35:34 -0400 X-MC-Unique: sl1r3qdAPoinI7-KdoCZVw-1 Received: by mail-wm1-f70.google.com with SMTP id j71-20020a1c234a0000b0290192d5ad58d9so1074864wmj.4 for ; Thu, 27 May 2021 01:35:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Te8pR0f8ez5F3aILm/YwV4KjHXZAzyEMnOBezzegJS8=; b=WVTBREGCKwLtaoYQ77E3kcUrHTVGZGpsdUy9RSi5VPU+j++GxBfu8FhslNWaeoq3Gb Mh3OiOakQ0StN56crTC8RPQRtuSRdaxvNs9C3p2bnvTP9kFDWEJvWpmjuYaNDY+Lu8Ob icPiWklVWzCsX0LtUQDPAFhpn91qsNVdHWq1RWcyUCKneCkD+fiYyuPKwDaiQECU905d 3rXvuAZPAN8r+4cxLmoC61qrCNaGoUqCFnn6pt/Y9fOsB/6N/snfMpt07FxcEe02fAcO PKckO2GAhVuJKPCrXWQiRgVqmERIqKybHdpGlFiqBLEeZ6XUcmgN0kCrpMK1Ha5wesdY 9RZA== X-Gm-Message-State: AOAM530VNL+zrERxz+Tp3UxvvHaoJP66IMZxaYDfXgAmA+Fo7AoUb84c jHnccDtcZVr06QkZKWUuJxi/XbGie/QrH5wgSvbqihX7myP7u+6/flIcoSdeS8tLJnipyJFNb1e VBdd32DofQ3XjPA== X-Received: by 2002:a1c:dc0b:: with SMTP id t11mr2291154wmg.89.1622104533176; Thu, 27 May 2021 01:35:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPjjLbNu4sRQeH40VjwH3uprd/DqQ1QZcN7gOlsoF11Pg10KJApLgvBNYUr9OhxjnmCyDyMg== X-Received: by 2002:a1c:dc0b:: with SMTP id t11mr2291142wmg.89.1622104533039; Thu, 27 May 2021 01:35:33 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id y6sm9690521wmy.23.2021.05.27.01.35.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 01:35:32 -0700 (PDT) Subject: Re: [PATCH 38/43] OvmfPkg/SmbiosPlatformDxe: locate SMBIOS protocol in InstallAllStructures() To: Laszlo Ersek , devel@edk2.groups.io Cc: Ard Biesheuvel , Jordan Justen References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-39-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Thu, 27 May 2021 10:35:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-39-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > Locate the SMBIOS protocol internally to the InstallAllStructures() > function. This has no performance impact (InstallAllStructures() is only > called once), but moving the code from the entry point function makes the > latter smaller. And that will be useful when we split the entry point > function to two versions. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 30 +++++++++----------- > 1 file changed, 14 insertions(+), 16 deletions(-) Reviewed-by: Philippe Mathieu-Daude