public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Pierre Gondois <pierre.gondois@arm.com>, devel@edk2.groups.io
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Zhiguang Liu <zhiguang.liu@intel.com>, Ray Ni <ray.ni@intel.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	"nd@arm.com" <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions
Date: Fri, 22 Dec 2023 15:29:39 +0000	[thread overview]
Message-ID: <a5bd62f9-4232-4137-8580-50175a87f8c6@arm.com> (raw)
In-Reply-To: <20231130110953.16550-2-pierre.gondois@arm.com>

Hi Pierre,

Thank you for this patch.

I just have one comment marked inline as [SAMI].

Otherwise this patch looks good to me.

With that addressed,

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 30/11/2023 11:09 am, Pierre Gondois wrote:
> Add definitions for:
> - _PSD version: added in ACPI 3.0
> - C-state Coordination Types: added in ACPI 3.0
> - _CPC version: added in ACPI 5.0
>
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
>   MdePkg/Include/IndustryStandard/Acpi30.h | 14 ++++++++++++++
>   MdePkg/Include/IndustryStandard/Acpi40.h |  5 +++++
>   MdePkg/Include/IndustryStandard/Acpi50.h | 10 ++++++++++
>   MdePkg/Include/IndustryStandard/Acpi51.h | 10 ++++++++++
>   MdePkg/Include/IndustryStandard/Acpi60.h | 10 ++++++++++
>   MdePkg/Include/IndustryStandard/Acpi61.h | 10 ++++++++++
>   MdePkg/Include/IndustryStandard/Acpi62.h | 10 ++++++++++
>   MdePkg/Include/IndustryStandard/Acpi63.h | 10 ++++++++++
>   MdePkg/Include/IndustryStandard/Acpi64.h | 10 ++++++++++
>   MdePkg/Include/IndustryStandard/Acpi65.h | 10 ++++++++++
>   10 files changed, 99 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi30.h b/MdePkg/Include/IndustryStandard/Acpi30.h
> index 29f0d5535593..cb50b1d8f71a 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi30.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi30.h
> @@ -17,6 +17,20 @@
>   
>
>   #define ACPI_EXTENDED_ADDRESS_SPACE_DESCRIPTOR  0x8B
>
>   
>
> +///
>
> +/// C-state Coordination Types
>
> +/// See s8.4.2.2 _CSD (C-State Dependency)
>
> +///
>
> +#define ACPI_AML_COORD_TYPE_SW_ALL  0xFC
>
> +#define ACPI_AML_COORD_TYPE_SW_ANY  0xFD
>
> +#define ACPI_AML_COORD_TYPE_HW_ALL  0xFE
>
> +
>
> +///
>
> +/// _PSD Revision for ACPI 3.0
>
> +// See s8.4.4.5 _PSD (P-State Dependency)
>
> +///
>
> +#define EFI_ACPI_3_0_AML_PSD_REVISION  0
>
> +
>
>   //
>
>   // Ensure proper structure formats
>
>   //
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi40.h b/MdePkg/Include/IndustryStandard/Acpi40.h
> index a2da09346f1c..0e30f4f8417d 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi40.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi40.h
> @@ -10,6 +10,11 @@
>   
>
>   #include <IndustryStandard/Acpi30.h>
>
>   
>
> +///
>
> +/// _PSD Revision for ACPI 4.0
>
> +///
>
> +#define EFI_ACPI_4_0_AML_PSD_REVISION  0
>
> +
>
>   //
>
>   // Ensure proper structure formats
>
>   //
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi50.h b/MdePkg/Include/IndustryStandard/Acpi50.h
> index 76706aa640f8..a00b8259b8f7 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi50.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi50.h
> @@ -23,6 +23,16 @@
>   #define ACPI_GPIO_CONNECTION_DESCRIPTOR                0x8C
>
>   #define ACPI_GENERIC_SERIAL_BUS_CONNECTION_DESCRIPTOR  0x8E
>
>   
>
> +///
>
> +/// _PSD Revision for ACPI 5.0
>
> +///
>
> +#define EFI_ACPI_5_0_AML_PSD_REVISION  0
>
> +
>
> +///
>
> +/// _CPC Revision for ACPI 5.0
>
> +///
>
> +#define EFI_ACPI_5_0_AML_CPC_REVISION  1
>
> +
>
>   #pragma pack(1)
>
>   
>
>   ///
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h b/MdePkg/Include/IndustryStandard/Acpi51.h
> index 01ef544c3a29..19dd7b4f864c 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi51.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi51.h
> @@ -13,6 +13,16 @@
>   
>
>   #include <IndustryStandard/Acpi50.h>
>
>   
>
> +///
>
> +/// _PSD Revision for ACPI 5.1
>
> +///
>
> +#define EFI_ACPI_5_1_AML_PSD_REVISION  0
>
> +
>
> +///
>
> +/// _CPC Revision for ACPI 5.1
>
> +///
>
> +#define EFI_ACPI_5_1_AML_CPC_REVISION  1
[SAMI] I believe the CPC revision value is 2 in this revision of the 
specification. See Table 8-228 in 
https://uefi.org/sites/default/files/resources/ACPI_5_1_Errata_B.PDF
>
> +
>
>   //
>
>   // Ensure proper structure formats
>
>   //
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h b/MdePkg/Include/IndustryStandard/Acpi60.h
> index 5ac3be6ad71c..3757d3f82792 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi60.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi60.h
> @@ -12,6 +12,16 @@
>   
>
>   #include <IndustryStandard/Acpi51.h>
>
>   
>
> +///
>
> +/// _PSD Revision for ACPI 6.0
>
> +///
>
> +#define EFI_ACPI_6_0_AML_PSD_REVISION  0
>
> +
>
> +///
>
> +/// _CPC Revision for ACPI 6.0
>
> +///
>
> +#define EFI_ACPI_6_0_AML_CPC_REVISION  2
>
> +
>
>   //
>
>   // Ensure proper structure formats
>
>   //
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h b/MdePkg/Include/IndustryStandard/Acpi61.h
> index 7af67d832bb2..c3facc6e376e 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi61.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi61.h
> @@ -12,6 +12,16 @@
>   
>
>   #include <IndustryStandard/Acpi60.h>
>
>   
>
> +///
>
> +/// _PSD Revision for ACPI 6.1
>
> +///
>
> +#define EFI_ACPI_6_1_AML_PSD_REVISION  0
>
> +
>
> +///
>
> +/// _CPC Revision for ACPI 6.1
>
> +///
>
> +#define EFI_ACPI_6_1_AML_CPC_REVISION  2
>
> +
>
>   //
>
>   // Ensure proper structure formats
>
>   //
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h
> index e27775a85ade..4dd3e21c2325 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi62.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi62.h
> @@ -29,6 +29,16 @@
>   #define ACPI_PIN_GROUP_FUNCTION_DESCRIPTOR       0x91
>
>   #define ACPI_PIN_GROUP_CONFIGURATION_DESCRIPTOR  0x92
>
>   
>
> +///
>
> +/// _PSD Revision for ACPI 6.2
>
> +///
>
> +#define EFI_ACPI_6_2_AML_PSD_REVISION  0
>
> +
>
> +///
>
> +/// _CPC Revision for ACPI 6.2
>
> +///
>
> +#define EFI_ACPI_6_2_AML_CPC_REVISION  3
>
> +
>
>   #pragma pack(1)
>
>   
>
>   ///
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h b/MdePkg/Include/IndustryStandard/Acpi63.h
> index 10bdf5fe5a57..7582dccf649b 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi63.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi63.h
> @@ -12,6 +12,16 @@
>   
>
>   #include <IndustryStandard/Acpi62.h>
>
>   
>
> +///
>
> +/// _PSD Revision for ACPI 6.3
>
> +///
>
> +#define EFI_ACPI_6_3_AML_PSD_REVISION  0
>
> +
>
> +///
>
> +/// _CPC Revision for ACPI 6.3
>
> +///
>
> +#define EFI_ACPI_6_3_AML_CPC_REVISION  3
>
> +
>
>   //
>
>   // Ensure proper structure formats
>
>   //
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h
> index 575ca0430c13..faf069a0454e 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi64.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi64.h
> @@ -12,6 +12,16 @@
>   
>
>   #include <IndustryStandard/Acpi63.h>
>
>   
>
> +///
>
> +/// _PSD Revision for ACPI 6.4
>
> +///
>
> +#define EFI_ACPI_6_4_AML_PSD_REVISION  0
>
> +
>
> +///
>
> +/// _CPC Revision for ACPI 6.4
>
> +///
>
> +#define EFI_ACPI_6_4_AML_CPC_REVISION  3
>
> +
>
>   //
>
>   // Ensure proper structure formats
>
>   //
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi65.h b/MdePkg/Include/IndustryStandard/Acpi65.h
> index d79d0b2b5f9c..b9616a3e29c2 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi65.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi65.h
> @@ -18,6 +18,16 @@
>   //
>
>   #pragma pack(1)
>
>   
>
> +///
>
> +/// _PSD Revision for ACPI 6.5
>
> +///
>
> +#define EFI_ACPI_6_5_AML_PSD_REVISION  0
>
> +
>
> +///
>
> +/// _CPC Revision for ACPI 6.5
>
> +///
>
> +#define EFI_ACPI_6_5_AML_CPC_REVISION  3
>
> +
>
>   ///
>
>   /// ACPI 6.5 Generic Address Space definition
>
>   ///
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112847): https://edk2.groups.io/g/devel/message/112847
Mute This Topic: https://groups.io/mt/102891569/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      parent reply	other threads:[~2023-12-22 15:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-30 11:09 [edk2-devel] [PATCH 0/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions PierreGondois
2023-11-30 11:09 ` [edk2-devel] [PATCH 1/1] " PierreGondois
2023-12-01 10:22   ` Ni, Ray
2023-12-01 12:26     ` PierreGondois
2023-12-06  9:42       ` PierreGondois
2023-12-12  0:36         ` 回复: " gaoliming via groups.io
2023-12-22 15:29   ` Sami Mujawar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5bd62f9-4232-4137-8580-50175a87f8c6@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox