From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 575787803CF for ; Fri, 22 Dec 2023 15:30:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2xtDcu+DZrive1c+1SGrWVmK48ITk0ouRF4hauu+2h4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1703259009; v=1; b=HNDKRhVcP1u/d+B6II+2QtOCakNoLDI2o4Qwjs0rgoI/R+Nkd5ddrEMKlp2f9xnIcOkV/JB6 qAW1UBMwtGeZquQq+hM7DUElilV9JXx73aW1T49Lz0uwmmi4E5rvVmUmlPsyms+AUo+oqYSZLN0 61F7eib2lgOw8vp2VMyx/IGY= X-Received: by 127.0.0.2 with SMTP id vONlYY7687511xTYTHoVoXwe; Fri, 22 Dec 2023 07:30:09 -0800 X-Received: from EUR01-DB5-obe.outbound.protection.outlook.com (EUR01-DB5-obe.outbound.protection.outlook.com [40.107.15.44]) by mx.groups.io with SMTP id smtpd.web11.25388.1703259008069392494 for ; Fri, 22 Dec 2023 07:30:09 -0800 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XmclaxLGyxXejRZGx4RU2e5cidbFlEa7gfR90kTTukz05Mh73BTwrnvwl910e03tIxSM96KRyvyl9swWReItFdXJAWiqsM6MKSg0MdqkxKniaPYG3SplTFd4RoONp1TnhEAg+LQySSBvWDAOskHh1U7fag9WMIBCI0M4lvRU3y5Xu0bhuyJ/J1YLrGjNwOc85HxxDD0+pHVYeafWnrkwAS3JKRzIotcMEy46Tr3I3piyk2G/eS2A+MoSOD/q39CrP+a+hC4kuna9lD/KB4trPXG2WTwliInkUg+9BqxAI2t09NL3ghUsWp3srlvBaJHdneJhUqIOCIh/ZztPUYb0cQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+cDEZC3+nrQ0KCg84KrI5LCUWd8Vs3YEJAE+pyghVQY=; b=RgGDzHd/j7VEdVpJCE3M6scKtkrLwlau0yFT0UYeYvyc1IIVufnlnvPlItunBSBpX/wOvTktOOUAlIWEm8RvRvrMIFd7GTMTP62B91aDM8LJyMmZ9KpAURuV4V9sPdgcAARbhfNi0SCb9+3iXz4lxzXW2gpihxsgVSIomgdfhx1yYloUeQriAJB8S3a2qhZ7if/DJg07ajd6KH8jkarqklevQGFw8twxu0oUjUict+wgPEiZp/EX1oUWyJGD0MHNDujtcFsoUYLDFGxGPMIJjfJkimossPE9LNH1ghy8Oi0SnsU4lvzukTwRuvLYZ5eeCCkxTh1y1afbrG0YfTTtHw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from AM5PR1001CA0024.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::37) by DB9PR08MB9948.eurprd08.prod.outlook.com (2603:10a6:10:3d0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.21; Fri, 22 Dec 2023 15:29:56 +0000 X-Received: from AM3PEPF00009B9C.eurprd04.prod.outlook.com (2603:10a6:206:2:cafe::17) by AM5PR1001CA0024.outlook.office365.com (2603:10a6:206:2::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.21 via Frontend Transport; Fri, 22 Dec 2023 15:29:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM3PEPF00009B9C.mail.protection.outlook.com (10.167.16.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.14 via Frontend Transport; Fri, 22 Dec 2023 15:29:55 +0000 X-Received: ("Tessian outbound 20615a7e7970:v228"); Fri, 22 Dec 2023 15:29:55 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d02aacf90dc5b655 X-CR-MTA-TID: 64aa7808 X-Received: from 1105f34faa7f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 26BB67B0-0AEB-4A3C-A7F6-E1E11CAE2CEF.1; Fri, 22 Dec 2023 15:29:44 +0000 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1105f34faa7f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 22 Dec 2023 15:29:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zh2OezEnmlq9pBnrXx50mQt5C79JwqvJC8n3fg3Ip7B9DX6DyM7qV/QYvHjX4dvcYJfRkxp34vsAHfNM1shfeu5TTGV/LLCJ3FSamWtDqupngUbKKgrMXktUiMZjDJ8AtT0xIvaL1qft0zCRG750L8N9AmVEIh4lXtELE2wVQYMLgcgCXEOyv1NeH60bI0J3piEP75EuCSQ0/ldmJWxjaJj1ErUVy0Y3Fn1fUFWV5gUJvFJQzx+c10V2/e/m4kBB71jsM/7SQ9Z0t68CfRb4KKUDQW/a/PPHPosMCMp2acPre2YBjKvDZ/phBQpQL+/pq71j5j3ylA5oIVy+7tIXbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+cDEZC3+nrQ0KCg84KrI5LCUWd8Vs3YEJAE+pyghVQY=; b=IqKGhroGx+f1vFZGwbAJzeIZktqbTAdQv0bgVb6+UJ3jk4qp2c9reACSN14mDDwkwZs+z1VxYaqpMENYIKmHWsrUWakVaTj8WWMeqLLs0IHdSkOHHX2qQaMq1G8q7n9kXw5098jIbwn9RNBn4fXwlLFrHOs5bvARGFpkOHj0MM43dLbdP3QJ5umPYfd4aiuOxJ2Vikljq0rTbjeJLgl6J7TDC3MBaomjdi4so+QEVrYMcHMFH8eP+cR6pdbxRaoRPisl0jF/ZgYPldqe3Gntm7fvCHxpAHe6+tcYYL9lTukzkU85ausxWgud9NH9OdTg/SfdsIc9m1o08Hw4m6cckQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DU2PR08MB9991.eurprd08.prod.outlook.com (2603:10a6:10:493::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.20; Fri, 22 Dec 2023 15:29:42 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775%4]) with mapi id 15.20.7113.019; Fri, 22 Dec 2023 15:29:42 +0000 Message-ID: Date: Fri, 22 Dec 2023 15:29:39 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions To: Pierre Gondois , devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Ray Ni , Leif Lindholm , "nd@arm.com" References: <20231130110953.16550-1-pierre.gondois@arm.com> <20231130110953.16550-2-pierre.gondois@arm.com> From: "Sami Mujawar" In-Reply-To: <20231130110953.16550-2-pierre.gondois@arm.com> X-ClientProxiedBy: LO4P265CA0189.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:311::15) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DU2PR08MB9991:EE_|AM3PEPF00009B9C:EE_|DB9PR08MB9948:EE_ X-MS-Office365-Filtering-Correlation-Id: 784f9be4-ee50-4074-d771-08dc0302d9b1 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Eop+9IAAdGgqGo7bfVpzhERhnWp/lKaQzTA2i2Wyd1qE22m81IMIurKcjOTCQMAC7/5I7XF84BhNNxWqRKsaA23tWi8/Mao0WF2qGfc5knMaQQYmrT7OguNcUVZkiBLwpdWPSaqW93SawuarXdEXxXugKHVDv5ffpdqKEX0+SQwBDpuqPiCz78OlYFuw/M9UvSTv1sGpq5rY+1QTT2cxpcsQXyjhm4unXQZolA6rp5+WrAfVptW0iqRdjVazqmtf8+mGTdVJjP7VZpBCtcCECUXMnHGwNGELVLNt6gHQj5RYibagsLUjJud/Xy9UjOo6qTvEEZHe5o9YRgZi9fSyEaFY8AOAG/h5mIs7uHdNYuQL3v4HPq2yvNorFMutsMdJYItBGWT+UBHd63HB+MnGnGXSUnsS+PuReOnRJor0M1Yt6Twjyj5cH5dcWUndSDPEiVhQJaLesY4GCZFBHcdrvLNkXbyiH7h6TZ4t2y2ezLS5EO5Cr6K0g2yz6mF39JPnHJcdZBOBw4jjSZouNpj00T2qrOYTWl6BkMTh6Llcm4xfq9RkjXn1tIvUD4ubkffcwVySc8WpFD2bhFtHvtV97JcLjdlQpmQdOw2yj9wpXqo5X1nY3zG0ndWSV9QWl/N7 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(396003)(366004)(346002)(376002)(39850400004)(230922051799003)(64100799003)(1800799012)(186009)(451199024)(6486002)(6666004)(478600001)(966005)(31686004)(38100700002)(26005)(2616005)(6512007)(53546011)(6506007)(41300700001)(4326008)(8676002)(2906002)(5660300002)(86362001)(36756003)(31696002)(8936002)(44832011)(54906003)(66946007)(66556008)(316002)(66476007)(19627235002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB9991 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM3PEPF00009B9C.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 444fac3c-7441-4714-b131-08dc0302d19a X-Microsoft-Antispam-Message-Info: 4JKZp03wlaH0/hr8fsjOTijM+TGCLyvfKjLfzDo5DHG42LvQhZGroHW4CI1MoosaTlihUBHjERr62fKKXS/OEg/YVIlkxxRwfyuULo0HeRWJfXHP2a8mxIEFPVrtbbBcI8cfMB8lYFJvYcbHeRuubktLDQApAVaqq46zH7zFge5IW1Ki8ODH0v/I3/iTZIsneqt4oSvYCTUQY4yIxlVfB/75XFcT7Q8UgFmMw/cC29MxFjqoAXsm515XHcJhJd4Gsw6B2NG03KTTNkpwQH2NEIY1e1l3M9XLRwLxPSeZ3SbVtZxtH/6mRjG32JPALlpTQ9UG0G2tKx7q2UHBIKItbhrt2TUS1RkChNAjoYVC4G9rDlNKR2agZy/PlXN53o5SWAEwkfQdOYn/wOahuYEoS6kBIec6oZtNfUHeQT0lhs26K5ZICuLlLNQq5zpl3w1+xOq5I6YANRu8cLAEW1Tf8ypxZIGc9+6oMa8AHyRYztY7qYhrj8KmwgDw2GUuTnQGFGrOFzEBNA14FwlPQUAJ50r0my2F2g0wARPCP2AxHMPoMcP6cLZtAQLhy51qVo64ujeKKbuNtaO+ugeRqXc4xJKP/fsPzvuQ0sW5gArhqKpz42uFNX8Y92/tZqmgZCdKIA1gdEcVKJKuaGRGPGCZl3biZgjYAPb36jrFbfJVOBJ+u7dk0510qlbbFohnSd8i8as2cCr2x3oWVcSNrZGm3VMQc7tJd0kxcu01cvWPuyk3/FOVMRIPbfX7oT5WgXhf X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2023 15:29:55.6115 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 784f9be4-ee50-4074-d771-08dc0302d9b1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF00009B9C.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9948 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: fSf9hbW8SuQGzVlR0UKtAS4Qx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=HNDKRhVc; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Pierre, Thank you for this patch. I just have one comment marked inline as [SAMI]. Otherwise this patch looks good to me. With that addressed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 30/11/2023 11:09 am, Pierre Gondois wrote: > Add definitions for: > - _PSD version: added in ACPI 3.0 > - C-state Coordination Types: added in ACPI 3.0 > - _CPC version: added in ACPI 5.0 > > Signed-off-by: Pierre Gondois > --- > MdePkg/Include/IndustryStandard/Acpi30.h | 14 ++++++++++++++ > MdePkg/Include/IndustryStandard/Acpi40.h | 5 +++++ > MdePkg/Include/IndustryStandard/Acpi50.h | 10 ++++++++++ > MdePkg/Include/IndustryStandard/Acpi51.h | 10 ++++++++++ > MdePkg/Include/IndustryStandard/Acpi60.h | 10 ++++++++++ > MdePkg/Include/IndustryStandard/Acpi61.h | 10 ++++++++++ > MdePkg/Include/IndustryStandard/Acpi62.h | 10 ++++++++++ > MdePkg/Include/IndustryStandard/Acpi63.h | 10 ++++++++++ > MdePkg/Include/IndustryStandard/Acpi64.h | 10 ++++++++++ > MdePkg/Include/IndustryStandard/Acpi65.h | 10 ++++++++++ > 10 files changed, 99 insertions(+) > > diff --git a/MdePkg/Include/IndustryStandard/Acpi30.h b/MdePkg/Include/In= dustryStandard/Acpi30.h > index 29f0d5535593..cb50b1d8f71a 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi30.h > +++ b/MdePkg/Include/IndustryStandard/Acpi30.h > @@ -17,6 +17,20 @@ > =20 > > #define ACPI_EXTENDED_ADDRESS_SPACE_DESCRIPTOR 0x8B > > =20 > > +/// > > +/// C-state Coordination Types > > +/// See s8.4.2.2 _CSD (C-State Dependency) > > +/// > > +#define ACPI_AML_COORD_TYPE_SW_ALL 0xFC > > +#define ACPI_AML_COORD_TYPE_SW_ANY 0xFD > > +#define ACPI_AML_COORD_TYPE_HW_ALL 0xFE > > + > > +/// > > +/// _PSD Revision for ACPI 3.0 > > +// See s8.4.4.5 _PSD (P-State Dependency) > > +/// > > +#define EFI_ACPI_3_0_AML_PSD_REVISION 0 > > + > > // > > // Ensure proper structure formats > > // > > diff --git a/MdePkg/Include/IndustryStandard/Acpi40.h b/MdePkg/Include/In= dustryStandard/Acpi40.h > index a2da09346f1c..0e30f4f8417d 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi40.h > +++ b/MdePkg/Include/IndustryStandard/Acpi40.h > @@ -10,6 +10,11 @@ > =20 > > #include > > =20 > > +/// > > +/// _PSD Revision for ACPI 4.0 > > +/// > > +#define EFI_ACPI_4_0_AML_PSD_REVISION 0 > > + > > // > > // Ensure proper structure formats > > // > > diff --git a/MdePkg/Include/IndustryStandard/Acpi50.h b/MdePkg/Include/In= dustryStandard/Acpi50.h > index 76706aa640f8..a00b8259b8f7 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi50.h > +++ b/MdePkg/Include/IndustryStandard/Acpi50.h > @@ -23,6 +23,16 @@ > #define ACPI_GPIO_CONNECTION_DESCRIPTOR 0x8C > > #define ACPI_GENERIC_SERIAL_BUS_CONNECTION_DESCRIPTOR 0x8E > > =20 > > +/// > > +/// _PSD Revision for ACPI 5.0 > > +/// > > +#define EFI_ACPI_5_0_AML_PSD_REVISION 0 > > + > > +/// > > +/// _CPC Revision for ACPI 5.0 > > +/// > > +#define EFI_ACPI_5_0_AML_CPC_REVISION 1 > > + > > #pragma pack(1) > > =20 > > /// > > diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h b/MdePkg/Include/In= dustryStandard/Acpi51.h > index 01ef544c3a29..19dd7b4f864c 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi51.h > +++ b/MdePkg/Include/IndustryStandard/Acpi51.h > @@ -13,6 +13,16 @@ > =20 > > #include > > =20 > > +/// > > +/// _PSD Revision for ACPI 5.1 > > +/// > > +#define EFI_ACPI_5_1_AML_PSD_REVISION 0 > > + > > +/// > > +/// _CPC Revision for ACPI 5.1 > > +/// > > +#define EFI_ACPI_5_1_AML_CPC_REVISION 1 [SAMI] I believe the CPC revision value is 2 in this revision of the=20 specification. See Table 8-228 in=20 https://uefi.org/sites/default/files/resources/ACPI_5_1_Errata_B.PDF > > + > > // > > // Ensure proper structure formats > > // > > diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h b/MdePkg/Include/In= dustryStandard/Acpi60.h > index 5ac3be6ad71c..3757d3f82792 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi60.h > +++ b/MdePkg/Include/IndustryStandard/Acpi60.h > @@ -12,6 +12,16 @@ > =20 > > #include > > =20 > > +/// > > +/// _PSD Revision for ACPI 6.0 > > +/// > > +#define EFI_ACPI_6_0_AML_PSD_REVISION 0 > > + > > +/// > > +/// _CPC Revision for ACPI 6.0 > > +/// > > +#define EFI_ACPI_6_0_AML_CPC_REVISION 2 > > + > > // > > // Ensure proper structure formats > > // > > diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h b/MdePkg/Include/In= dustryStandard/Acpi61.h > index 7af67d832bb2..c3facc6e376e 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi61.h > +++ b/MdePkg/Include/IndustryStandard/Acpi61.h > @@ -12,6 +12,16 @@ > =20 > > #include > > =20 > > +/// > > +/// _PSD Revision for ACPI 6.1 > > +/// > > +#define EFI_ACPI_6_1_AML_PSD_REVISION 0 > > + > > +/// > > +/// _CPC Revision for ACPI 6.1 > > +/// > > +#define EFI_ACPI_6_1_AML_CPC_REVISION 2 > > + > > // > > // Ensure proper structure formats > > // > > diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/In= dustryStandard/Acpi62.h > index e27775a85ade..4dd3e21c2325 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi62.h > +++ b/MdePkg/Include/IndustryStandard/Acpi62.h > @@ -29,6 +29,16 @@ > #define ACPI_PIN_GROUP_FUNCTION_DESCRIPTOR 0x91 > > #define ACPI_PIN_GROUP_CONFIGURATION_DESCRIPTOR 0x92 > > =20 > > +/// > > +/// _PSD Revision for ACPI 6.2 > > +/// > > +#define EFI_ACPI_6_2_AML_PSD_REVISION 0 > > + > > +/// > > +/// _CPC Revision for ACPI 6.2 > > +/// > > +#define EFI_ACPI_6_2_AML_CPC_REVISION 3 > > + > > #pragma pack(1) > > =20 > > /// > > diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h b/MdePkg/Include/In= dustryStandard/Acpi63.h > index 10bdf5fe5a57..7582dccf649b 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi63.h > +++ b/MdePkg/Include/IndustryStandard/Acpi63.h > @@ -12,6 +12,16 @@ > =20 > > #include > > =20 > > +/// > > +/// _PSD Revision for ACPI 6.3 > > +/// > > +#define EFI_ACPI_6_3_AML_PSD_REVISION 0 > > + > > +/// > > +/// _CPC Revision for ACPI 6.3 > > +/// > > +#define EFI_ACPI_6_3_AML_CPC_REVISION 3 > > + > > // > > // Ensure proper structure formats > > // > > diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/In= dustryStandard/Acpi64.h > index 575ca0430c13..faf069a0454e 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi64.h > +++ b/MdePkg/Include/IndustryStandard/Acpi64.h > @@ -12,6 +12,16 @@ > =20 > > #include > > =20 > > +/// > > +/// _PSD Revision for ACPI 6.4 > > +/// > > +#define EFI_ACPI_6_4_AML_PSD_REVISION 0 > > + > > +/// > > +/// _CPC Revision for ACPI 6.4 > > +/// > > +#define EFI_ACPI_6_4_AML_CPC_REVISION 3 > > + > > // > > // Ensure proper structure formats > > // > > diff --git a/MdePkg/Include/IndustryStandard/Acpi65.h b/MdePkg/Include/In= dustryStandard/Acpi65.h > index d79d0b2b5f9c..b9616a3e29c2 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi65.h > +++ b/MdePkg/Include/IndustryStandard/Acpi65.h > @@ -18,6 +18,16 @@ > // > > #pragma pack(1) > > =20 > > +/// > > +/// _PSD Revision for ACPI 6.5 > > +/// > > +#define EFI_ACPI_6_5_AML_PSD_REVISION 0 > > + > > +/// > > +/// _CPC Revision for ACPI 6.5 > > +/// > > +#define EFI_ACPI_6_5_AML_CPC_REVISION 3 > > + > > /// > > /// ACPI 6.5 Generic Address Space definition > > /// > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112847): https://edk2.groups.io/g/devel/message/112847 Mute This Topic: https://groups.io/mt/102891569/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-