public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@Intel.com>
To: Hao Wu <hao.a.wu@intel.com>, edk2-devel@lists.01.org
Cc: Eric Dong <eric.dong@intel.com>,
	Chao Zhang <chao.b.zhang@intel.com>,
	Jiewen Yao <jiewen.yao@intel.com>
Subject: Re: [PATCH v1 1/1] SecurityPkg/HddPassword: Add Security feature set support for ATA dev
Date: Wed, 20 Feb 2019 21:10:38 +0800	[thread overview]
Message-ID: <a613ea81-2cbf-1ca8-dfbc-61e53d7bd89c@Intel.com> (raw)
In-Reply-To: <20190215024911.7704-2-hao.a.wu@intel.com>


> +
> +/**
> +  Entry point of the notification callback function itself within the PEIM.
> +  It is to unlock HDD password for S3.
> +
> +  @param  PeiServices      Indirect reference to the PEI Services Table.
> +  @param  NotifyDescriptor Address of the notification descriptor data structure.
> +  @param  Ppi              Address of the PPI that was installed.
> +
> +  @return Status of the notification.
> +          The status code returned from this function is ignored.
> +**/
> +EFI_STATUS
> +EFIAPI
> +HddPasswordAtaPassThruNotify (
> +  IN EFI_PEI_SERVICES          **PeiServices,
> +  IN EFI_PEI_NOTIFY_DESCRIPTOR *NotifyDesc,
> +  IN VOID                      *Ppi
> +  )
> +{
> +  HDD_PASSWORD_PEI_DRIVER_PRIVATE_DATA    *Private;
> +
> +  DEBUG ((DEBUG_INFO, "%a() - enter at S3 resume\n", __FUNCTION__));
> +
> +  Private = HDD_PASSWORD_PEI_PRIVATE_DATA_FROM_THIS_NOTIFY (NotifyDesc);
> +  UnlockHddPassword (Private);

Similar comments as that I gave to 13/13 OpalPasswordPei change,
we could use the 3rd parameter "Ppi" to simplify the code.


      parent reply	other threads:[~2019-02-20 13:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15  2:49 [PATCH v1 0/1] Add Security feature set support for ATA devices Hao Wu
2019-02-15  2:49 ` [PATCH v1 1/1] SecurityPkg/HddPassword: Add Security feature set support for ATA dev Hao Wu
2019-02-18  7:47   ` Dong, Eric
2019-02-19  2:52     ` Wu, Hao A
2019-02-20 13:10   ` Ni, Ray [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a613ea81-2cbf-1ca8-dfbc-61e53d7bd89c@Intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox