From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web09.6735.1620986514118864295
 for <devel@edk2.groups.io>;
 Fri, 14 May 2021 03:01:54 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TZg9IJrB;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1620986513;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=VUIc04Ra2VDodsxsZACOAu5CaLQzNjhiDdaasJLNOFk=;
	b=TZg9IJrB1Cn+ThVX4Ir4FIFU44rzFriSwNFN9jiZXZX9B0KCQWUQpdRQPsOwQEAEPGgsX9
	l55xivsw4KkM0KFWVIJjoEkuSyAYhwhA76XIn6LVSonhGyXTNhN+dgDCOXc6ZD0zgmfBvP
	bJsWJLZhAQ4caDEeMXGMTzukr/dNbLo=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-380-f0AYcG_dNSW551MqOCa8pQ-1; Fri, 14 May 2021 06:01:50 -0400
X-MC-Unique: f0AYcG_dNSW551MqOCa8pQ-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CF3948005AD;
	Fri, 14 May 2021 10:01:48 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-190.ams2.redhat.com [10.36.112.190])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 998B710016F9;
	Fri, 14 May 2021 10:01:47 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v1 0/2] "maybe-uninitialized" warnings emitted by
To: sergei@posteo.net
References: <20210511225616.5942-1-sergei@posteo.net>
From: "Laszlo Ersek" <lersek@redhat.com>
Cc: devel@edk2.groups.io, Ray Ni <ray.ni@intel.com>,
 Zhichao Gao <zhichao.gao@intel.com>
Message-ID: <a62e0ae4-14ad-1935-32d5-b5f59af51637@redhat.com>
Date: Fri, 14 May 2021 12:01:45 +0200
MIME-Version: 1.0
In-Reply-To: <20210511225616.5942-1-sergei@posteo.net>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 05/12/21 00:56, Sergei Dmitrouk wrote:
> Compiling for IA32 target with gcc-5.5.0 emits "maybe-uninitialized" warnings.
> Compilation command: build -a IA32 -p OvmfPkg/OvmfPkgIa32.dsc -t GCC49
> 
> Sergei Dmitrouk (2):
>   ShellPkg/UefiShellCommandLib: suppress incorrect gcc warning
>   OvmfPkg/VirtioFsDxe: suppress incorrect gcc warnings
> 
>  OvmfPkg/VirtioFsDxe/SimpleFsOpen.c                    | 11 +++++++++++
>  .../Library/UefiShellCommandLib/UefiShellCommandLib.c |  5 +++++
>  2 files changed, 16 insertions(+)
> 

Merged as commit range 22ac5cc9d9db..d82c4693f8d5, via
<https://github.com/tianocore/edk2/pull/1643>.

I've gone ahead and merged the ShellPkg patch too, with only my R-b. I
had written the original code, and I've carefully verified Sergei's
patch too. Sergei learned the edk2 contribution process, and got it
right, at the first posting attempt; I wouldn't like to make him wait
several days for a ShellPkg ACK, with such a small patch.

Thanks for the contribution!
Laszlo