From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.49]) by mx.groups.io with SMTP id smtpd.web08.32306.1620042127662955311 for ; Mon, 03 May 2021 04:42:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=Y8ncE4bG; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.49, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QFno1/sjcymE5+dYJoQJzD41ttFWDNjsOpRbM9dURvmcLZTbIAhkmck/9xLeg4GtgmbbbtMLcTOIqLblFVmE9Eb9rvLcDtp4cfKDCpGxoYv3tLPz51dxCX5b9nmZyaL2oh6EfgsoW/UFmw4o4K5wd56wG1xlsWLOPUpQHdOY2ruy8Gfh/JdawIoeTS4vsVBgTubRRGlfOAiokauGyI+UbZGZdWc4c9YSLjci/iQVp6uUiDaGlcNd0jBR/OV7cQ+NZ3BuH5TA3WQBNKqV8/v/4cYTyb9CEnSPEiuBCOgHyvJFa5vTdNG+mUYjTcfpKoTz94JE7DJYiuQMRgNGC85fYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jUhItX0lOX3vNwPsOpOqDtjkRANhJWuRyIwWKh+tQz4=; b=VT72Q9S1w01dpNBBZ0JunAfTA2Bo3+E1NFAHpvWNRN8Bg3LxVLeOYg9+azYOEXZcCSDM4sE1Z7Agi9LBPmvcwclmQ8tgf11+5a9L4twQUr/wbsWF6GklHU45TGmrvKMQhqVIua7kfUNvJa6EmUla3EJfBuZizWHjZj0cLAQF/QnKhz+vzDjhhGTgm8qHmrUEflz0PtyTk+Mx47ilqzpVpqhTJkl1JFA5uM9CPvHvGDfGng0uhdSYN6WOpL2SeWsqqMkNrFadJax+B/UrmZngm4gQFdMLdPzyMnYtKEipwYVpQxlBCjHrTIQW9+vf2sELAIhf1FZPTcixcC9fw42Tvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jUhItX0lOX3vNwPsOpOqDtjkRANhJWuRyIwWKh+tQz4=; b=Y8ncE4bGZen9JMn+Ws9W/gBGJW/P1yeJEYDzXfyspNB8Uj07kx3wnVKAP8CnD8iHvuppIhQzXBU4o2Wg6XZNZYdeVtyeOrncuu8gEj6etyz8yR7rfFCv9kSMIvox7iP4B3geCPokT6qcIyTwJebkZx+lcKBKuuRHvaWZN8QAmO0= Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN6PR12MB2766.namprd12.prod.outlook.com (2603:10b6:805:78::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.41; Mon, 3 May 2021 11:42:04 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::9898:5b48:a062:db94%6]) with mapi id 15.20.4087.044; Mon, 3 May 2021 11:42:04 +0000 Cc: brijesh.singh@amd.com, James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Erdem Aktas Subject: Re: [edk2-devel] [PATCH RFC v2 01/28] MdePkg: Expand the SEV MSR to include the SNP definition To: Laszlo Ersek , devel@edk2.groups.io References: <20210430115148.22267-1-brijesh.singh@amd.com> <20210430115148.22267-2-brijesh.singh@amd.com> From: "Brijesh Singh" Message-ID: Date: Mon, 3 May 2021 06:42:02 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 In-Reply-To: X-Originating-IP: [70.112.153.56] X-ClientProxiedBy: SN7PR04CA0006.namprd04.prod.outlook.com (2603:10b6:806:f2::11) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from Brijeshs-MacBook-Pro.local (70.112.153.56) by SN7PR04CA0006.namprd04.prod.outlook.com (2603:10b6:806:f2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.27 via Frontend Transport; Mon, 3 May 2021 11:42:03 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0db1412d-b5de-45b3-e980-08d90e287936 X-MS-TrafficTypeDiagnostic: SN6PR12MB2766: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Njmqg6aYXR1ScRhm6FI3LM0uYpuXtbf247LZMFkLb/0lR5oGSLag0Og2+I6VgFJRhA7npYGpQbga2S6MYn6cQhJyKrq0UvAuUnxFthZeotD0TwyGYp9lLVW/ciAh0WkURqAN6qp1/bD3SaEiRH/H1UGyvOZfWihG///zqUumJq5diN6ZJtedLnbNZaIa7y3KlwBT2jcFj5rsdyHgBQibPDVFH/eA42wU3lcQRjvU/wXAysZALPaym3FmHl4E8j6zi6US57+1QBwU0HnOuBbTE8JCGpYjDzjjbxNzL21dMiPeZkiJgYYAonjeG3ZepI+ZjFtjW6nPOQBPjcthwJUnn60NAc/jwPotY1iu0r1rus5Iq7hmY1GC8d4N7xB97u5GXY260hJ0tzF5o5gh+WCXssgPTnpBOBd9P+nYmS02VUM9EBCJuPQV1435M3yt/WbJ8pObN+iskBnlWHLU0M5P6sLDlISZglPH4ClIWB36QJBOydayWO5aV/2DA7GLDe0L27W7NN7L/N/DcL/ZxV3ltitWtpxJptFoMoPl0t0nD18d4PGObuaWRwq4sSRc7VgSeYue7sCWrsFfdnSMg1Y3QjWZiuXPE2hrF1XMfTXwViRUAEpD576YiFqejn3gUoS7ua6yOtEAh1+fLCgy4KPjo7RWpG3TAEzE9CGhcLz5id28kuEPPYhT6w5jdoVrGp87483NmyPnMBcFeTCAnYIRqcDGqvTYlRgc/xzNb9RQyz7zZiHqgRoeHKWbFwwpa3BnYmtR4owYSvucbdnOE/8sIS0KbqCSB3Y32VPSWfNbOtY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(396003)(39860400002)(346002)(2616005)(45080400002)(956004)(19627235002)(66476007)(66556008)(966005)(31686004)(478600001)(44832011)(6486002)(66946007)(36756003)(52116002)(6506007)(16526019)(86362001)(83380400001)(6512007)(5660300002)(26005)(4326008)(8936002)(54906003)(8676002)(31696002)(316002)(186003)(38350700002)(38100700002)(2906002)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bkVwME5NSzRpc2dONWxHbmVDUVhEbTZlZUtCWjB1d2pMNHJLY0ZtRnptYUNO?= =?utf-8?B?TG44RHVzY1JZUFBaS2RWeFV2cW8xYWhZUHhubWhHZ3FDNE1NMklKZXlUUE4z?= =?utf-8?B?WlRjZDRCM3RiNHJkUG9hT1JFYkFTVHRKMEhzRTJiUlVGTHdaR3QwclE5K2pr?= =?utf-8?B?aUlwOENSSjZYWDFkUUlDM3V4ZktyNGNFMVhabFM1emlQbW1TTGJ1ejU5SEQ3?= =?utf-8?B?VTJyU0xrdG1oVVhEWnZ4MnpnK2kwcFlIUlIrOU0vYmI0STE1L0p6aEtSanpt?= =?utf-8?B?UFlicjdDYVlGN1B2SmtCcFQyTG1iSDBBdElSeTdGc1lSR0k5bndVSGN0TlZR?= =?utf-8?B?NmFXQ2xjRVI1alhPa1pKdUJSZjFneDdZdmRZc1RYbEtKZHlvUjk2Um5vb3hz?= =?utf-8?B?TjhhM3dmeGtWa1hsTzZiRjIvZUpmVDNNMEEwNXV0OGlyaEpGSjc3NFNyc0h2?= =?utf-8?B?Y1lHaENNK2ZzUGRXTTRLd0hjOGpZZzVBVWVrU1BVbDBqeDJKRDhWRkpuMWNF?= =?utf-8?B?SmNydGZuVGZwczBJYWlEcGVlMkxWNS9mS3ZWb000RUk0b3ZYMTZTYjAvUXht?= =?utf-8?B?NC9iQ0pHemRackRSVmFVK1NTbStmZU1waW13VmJ6OWZ3U2JqYVpyUzhRVzZH?= =?utf-8?B?dnEwNytYYTN5dEs3eG82bVdYRmhxWER3OFdGZFFQYStlbmdDYSt2ekROQ2Jn?= =?utf-8?B?TmlVZ1hlUmJXc3dmVEhjWThkR1VNK2Jic3ptTXFkZU12alZhcnQ4SDNmZVVv?= =?utf-8?B?YWU0S3BQMVFPend0RFdJNFVIZ3Vxb0NRVzVFNzJnRlg1N2ZBUUlMa25oaFFK?= =?utf-8?B?Vm0yd0hxMXF5NjJlcmEyUkxQaVd2ZEN1TU9lQlpDekpyVmxnZ2JUdXVSS09D?= =?utf-8?B?WFlMTTJmdFhPRGcrTnE2WXZTZ0xZREljMmUxcGkwRkJYdXplOThvTHNkc3E4?= =?utf-8?B?QW1iNURIQlhLc3JtS2ZyWG9EQyszSFhGck1kd20vdWdqOXY1Qm1XQm9KQmg4?= =?utf-8?B?d29jdXRoS3J5cEROUUtVL200elFzNDBUVUNPVm5sdHZWTW9qMG5HK29pNS9q?= =?utf-8?B?UzB5UlNCTmZkZXUyaERZRlZjQWhuVGNiWFhvZ0I1Q3Z1OVZnT0NmSngxYlVB?= =?utf-8?B?Zlc4MjJuR1NQbHkxcW05M3F0VFl4KzIzby9HKzRsM21FV2VlSzlFK01SQS9m?= =?utf-8?B?ZmhrZnVWTXpaNUwwSitSZFNlektkZG8zMXRRR3hGaHUxdmhkcTJPVXNZN0th?= =?utf-8?B?aTQxWmYwTk5USFowY0RCWlk3ODNua29CcTNWV3RCd3EvS1oxWUdFZit1R1Ry?= =?utf-8?B?c1pmM2tIemNZcnVDeWg0Vjg2bHA1WjJUU0wvbTVGSml5NTVzajJhVytxUkVr?= =?utf-8?B?ZGU2TXZnNDV3c1hFQ0Vma2Z2dlI5RTRZUEhwdTBIZXlhTzRud2JsUmdJdTJl?= =?utf-8?B?S0x1T3FkeitPUWY3MU9TL2pZd1RPTll4UXliMkpYRlZpNnZEVEh2YTBneDJ1?= =?utf-8?B?N0hBYVhYUXNDWnkxd1JTb0NxUU1nMms0OXBhRDlFaWtiZ0xSd2pwRVV2ZlZp?= =?utf-8?B?ZzlQckFXenIvVXlxeUpDcTlUby8rN0VzZ1hpK25oSVdJUnBta1gyM3JOUDN5?= =?utf-8?B?YU1HNk40TkxPejEvdjcvRk43Qmp0K204alRwZmlTODViVFA5YXNpK0Q4RGYr?= =?utf-8?B?SjBoaWwwc3QrUnVnMXVFRjBaU1Z2b1lzd2pack1Mck45WVJGNUdXQXh1MStT?= =?utf-8?Q?/dMj8MGING39LKzZt7oTgPUC0PBs0y3WbklpzPT?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0db1412d-b5de-45b3-e980-08d90e287936 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2021 11:42:04.6447 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qMrAYx/qMjMnVM5xTuAiW916gHMdloUu2+vwS9TncQWdHIBcrMNOhWeb+gTC/MtzkWF3x1MIW2qNcaTu5xrXOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2766 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 5/3/21 3:39 AM, Laszlo Ersek wrote: > On 04/30/21 13:51, Brijesh Singh wrote: >> BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7Ceea6f3b3eab148c16fdf08d90e0ef790%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637556279729207954%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=i4WYjB4hqOLiQR8dZyCLjSd8iUrE0QILyRavcHAEmGY%3D&reserved=0 >> >> Define the SEV-SNP MSR bits. >> >> Cc: James Bottomley >> Cc: Min Xu >> Cc: Jiewen Yao >> Cc: Tom Lendacky >> Cc: Jordan Justen >> Cc: Ard Biesheuvel >> Cc: Laszlo Ersek >> Cc: Erdem Aktas >> Signed-off-by: Brijesh Singh >> --- >> MdePkg/Include/Register/Amd/Fam17Msr.h | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h b/MdePkg/Include/Register/Amd/Fam17Msr.h >> index e4db09c518..4d33bef220 100644 >> --- a/MdePkg/Include/Register/Amd/Fam17Msr.h >> +++ b/MdePkg/Include/Register/Amd/Fam17Msr.h >> @@ -87,7 +87,12 @@ typedef union { >> /// >> UINT32 SevEsBit:1; >> >> - UINT32 Reserved:30; >> + /// >> + /// [Bit 2] Secure Nested Paging (SevSnp) is enabled >> + /// >> + UINT32 SevSnpBit:1; >> + >> + UINT32 Reserved:29; >> } Bits; >> /// >> /// All bit fields as a 32-bit value >> > (1) When changing a Reserved field's meaning, the field should be > renamed. Usually we do this by numbering, and the numbers only ever > increase. This is because code might exist that uses a Reserved field. > Such code should be prevented from compiling, because that's much better > than silently breaking its behavior. So the new name of the field should > be Reserved2. > > (If we modify Reserved2 later, it should be renamed to Reserved3, and so > on -- we should never return to a field name used before.) Noted, I will fix it in next rev. thanks