From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pcacjr@zytor.com>
Received: from mail.zytor.com (terminus.zytor.com [65.50.211.136])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 0D90B20958BD8
 for <edk2-devel@lists.01.org>; Thu,  7 Sep 2017 17:56:02 -0700 (PDT)
Received: from [IPv6:2804:7f4:c480:9cd0::2] ([IPv6:2804:7f4:c480:9cd0:0:0:0:2])
 (authenticated bits=0)
 by mail.zytor.com (8.15.2/8.15.2) with ESMTPSA id v880uR3a008496
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO);
 Thu, 7 Sep 2017 17:56:29 -0700
To: edk2-devel@lists.01.org
Cc: Laszlo Ersek <lersek@redhat.com>,
 Jordan Justen <jordan.l.justen@intel.com>, Andrew Fish <afish@apple.com>,
 Michael D Kinney <michael.d.kinney@intel.com>,
 Liming Gao <liming.gao@intel.com>, Star Zeng <star.zeng@intel.com>,
 Eric Dong <eric.dong@intel.com>, Mark Doran <mark.doran@intel.com>,
 Ruiyu Ni <ruiyu.ni@intel.com>, hao.a.wu@intel.com
References: <cover.1504825081.git.pcacjr@zytor.com>
From: Paulo Alcantara <pcacjr@zytor.com>
Message-ID: <a6503830-ab44-ae5c-7e44-1d26507f3627@zytor.com>
Date: Thu, 7 Sep 2017 21:56:25 -0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <cover.1504825081.git.pcacjr@zytor.com>
Subject: Re: [PATCH v5 0/6] read-only UDF file system support
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Sep 2017 00:56:02 -0000
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Ray,

On 07/09/2017 20:13, Paulo Alcantara wrote:
> v5:
>   - Fixed OVMF IA32 build.
>   - Fixed a typo in UdfDriveBindingStop() ("This" -> "SimpleFs") which
>     broke retrieval of private fs data from SimpleFs protocol --
>     identified by 'reconnect -r' command in UEFI shell.

Follow the diff between v4 and v5 for Mde*Pkg changes (forgot to include 
it when resending):

diff --git a/MdeModulePkg/Universal/Disk/UdfDxe/File.c 
b/MdeModulePkg/Universal/Disk/UdfDxe/File.c
index 8ad14fe594..2dbcff0be4 100644
--- a/MdeModulePkg/Universal/Disk/UdfDxe/File.c
+++ b/MdeModulePkg/Universal/Disk/UdfDxe/File.c
@@ -372,7 +372,7 @@ UdfRead (
        PrivFileData->FileSize,
        &PrivFileData->FilePosition,
        Buffer,
-      BufferSize
+      (UINT64 *)(UINTN)BufferSize^M
        );
    } else if (IS_FID_DIRECTORY_FILE (Parent->FileIdentifierDesc)) {
      if (ReadDirInfo->FidOffset == 0 && PrivFileData->FilePosition > 0) {
diff --git a/MdeModulePkg/Universal/Disk/UdfDxe/Udf.c 
b/MdeModulePkg/Universal/Disk/UdfDxe/Udf.c
index 9f10c78ca9..49dc7077b7 100644
--- a/MdeModulePkg/Universal/Disk/UdfDxe/Udf.c
+++ b/MdeModulePkg/Universal/Disk/UdfDxe/Udf.c
@@ -264,7 +264,7 @@ UdfDriverBindingStop (
      EFI_OPEN_PROTOCOL_GET_PROTOCOL
      );
    if (!EFI_ERROR (Status)) {
-    PrivFsData = PRIVATE_UDF_SIMPLE_FS_DATA_FROM_THIS (This);
+    PrivFsData = PRIVATE_UDF_SIMPLE_FS_DATA_FROM_THIS (SimpleFs);^M

      //
      // Uninstall child handle


Thanks,
Paulo