From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 22 Jul 2019 12:10:02 -0700 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3050230821AE; Mon, 22 Jul 2019 19:10:02 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-23.ams2.redhat.com [10.36.117.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 668C41001B23; Mon, 22 Jul 2019 19:10:00 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v3 00/35] Specific platform to run OVMF in Xen PVH and HVM guests To: Anthony PERARD Cc: devel@edk2.groups.io, xen-devel@lists.xenproject.org, Ard Biesheuvel , Jordan Justen , Julien Grall , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20190704144233.27968-1-anthony.perard@citrix.com> <20190719164223.GE1208@perard.uk.xensource.com> From: "Laszlo Ersek" Message-ID: Date: Mon, 22 Jul 2019 21:09:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190719164223.GE1208@perard.uk.xensource.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Mon, 22 Jul 2019 19:10:02 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/19/19 18:42, Anthony PERARD wrote: > On Fri, Jul 05, 2019 at 02:21:13PM +0200, Laszlo Ersek wrote: >> The patches on the list are malformed. They have >> >> Content-Transfer-Encoding: quoted-printable >> >> which is fine, in itself; however, they have CR-CR-LF line terminators. >> >> For example, from the first patch: >> >> diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf b/OvmfPkg/L= >> ibrary/ResetSystemLib/ResetSystemLib.inf >> index 7c44f99a5c..2f24dac87f 100644 >> --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf >> +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf >> @@ -30,4 +30,5 @@ [Packages] >> [LibraryClasses]=0D=0D >> DebugLib=0D=0D >> IoLib=0D=0D >> + PciLib=0D=0D >> TimerLib=0D=0D >> >> Note "=0D=0D". >> >> Now, if I try to apply this full set with git-am like that, the first >> patch in the series applies, but the second still fails: >> >>> error: corrupt patch at line 23 >>> Patch failed at 0002 OvmfPkg: Create platform OvmfXen >> >> Based on the email headers, the "iphmx.com" references suggest (via a >> google search) "Cisco's Ironport Cloud email service". >> >> I think that email service (MTA) is broken. >> >> If you could use a different MTA (or get the current one fixed), that >> would be helpful. (Yes, yes: if the edk2 project didn't use CRLF line >> terminators, that would be *even more* helpful.) > > I'm not sure that using a different MTA is going to help. I don't think > I can find a patch on the list that I can apply (without using unix2dos). > I did send a patch to my gmail address, and it looks fine (=0D in the > expected places and nowhere else). So maybe when a patch is sent through > a mailing list, some more formating is done? > > Anyway, can I try sending patch encoded in base64 instead of > quoted-printable? That would probably work better. > > I found <20190704040731.5303-1-glin@suse.com> on the list that is base64 > encoded, that I can easily apply and patchew too. That patch ("[edk2-devel] [PATCH v2] OvmfPkg: use DxeTpmMeasurementLib if and only if TPM2_ENABLE") worked fine for me as well. However, Gary confirmed elsewhere that he had to tweak the posting process manually, for that patch: http://mid.mail-archive.com/20190704085826.GD32340@GaryWorkstation Thanks Laszlo