public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: gua.guo@intel.com
To: devel@edk2.groups.io
Cc: gua.guo@intel.com, Guo Dong <guo.dong@intel.com>,
	Ray Ni <ray.ni@intel.com>, James Lu <james.lu@intel.com>
Subject: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec
Date: Mon, 27 Jun 2022 11:09:30 +0800	[thread overview]
Message-ID: <a68793c376b3dde9f0c9c0b0ccade5b7114c1722.1656299313.git.gua.guo@intel.com> (raw)

From: Gua Guo <gua.guo@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3963

Based on UPL spec 2.12.2. Universal Payload Information Section,
it defines item "Attribute" on UPLD_INFO_HEADER for Debug build
should be "1", and Release build should be "0".

Currently, The value of item "Attribute" is always "0"

Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: James Lu <james.lu@intel.com>
Signed-off-by: Gua Guo <gua.guo@intel.com>
---
 UefiPayloadPkg/UniversalPayloadBuild.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/UefiPayloadPkg/UniversalPayloadBuild.py b/UefiPayloadPkg/UniversalPayloadBuild.py
index ab4c977ba5..6003de36d1 100644
--- a/UefiPayloadPkg/UniversalPayloadBuild.py
+++ b/UefiPayloadPkg/UniversalPayloadBuild.py
@@ -111,6 +111,7 @@ def BuildUniversalPayload(Args, MacroList):
     #
     upld_info_hdr = UPLD_INFO_HEADER()
     upld_info_hdr.ImageId = Args.ImageId.encode()[:16]
+    upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0
     fp = open(UpldInfoFile, 'wb')
     fp.write(bytearray(upld_info_hdr))
     fp.close()
-- 
2.31.1.windows.1


             reply	other threads:[~2022-06-27  3:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-27  3:09 gua.guo [this message]
2022-06-27  3:43 ` [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec Ni, Ray
2022-06-27  4:06   ` Guo, Gua
2022-06-27  5:03     ` Guo, Gua
2022-06-27  6:52       ` Ni, Ray
2022-06-27  7:27         ` Guo, Gua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a68793c376b3dde9f0c9c0b0ccade5b7114c1722.1656299313.git.gua.guo@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox