public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, mikuback@linux.microsoft.com,
	sami.mujawar@arm.com, supreeth.venkatesh@arm.com,
	ardb+tianocore@kernel.org, Jiewen Yao <jiewen.yao@intel.com>
Subject: Re: [edk2-devel] Duplicate Files for StandaloneMmDriverEntryPoint.h
Date: Tue, 23 Feb 2021 18:37:22 +0100	[thread overview]
Message-ID: <a6991160-035c-6726-79ad-34e7b272fefc@redhat.com> (raw)
In-Reply-To: <b59eebc8-beb8-9e0e-e0d3-6bc07aa77276@linux.microsoft.com>

Hi Michael,

On 02/22/21 23:11, Michael Kubacki wrote:
> Is there a particular reason two copies of
> StandaloneMmDriverEntryPoint.h exist in the edk2 repo?
> 
> 1. MdePkg
> https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h
> 
> 
> 2. StandaloneMmPkg
> https://github.com/tianocore/edk2/blob/master/StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h
> 
> 
> The only substantial difference (apart from copyright and comment
> differences) is that the StandaloneMmPkg instance contains a function
> declaration for EfiMain().

I believe this may have been an omission in commit d6253d2f9a33
("StandaloneMmPkg: remove redundant StandaloneMmDriverEntryPoint
driver", 2019-03-11).

At that point, both the library class & instance had been migrated to
MdePkg (commits 7df4764e6a81a and 5866d4992396).

Can you propose a patch (unless I'm wrong, of course)?

Thanks
Laszlo


  reply	other threads:[~2021-02-23 17:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-22 22:11 Duplicate Files for StandaloneMmDriverEntryPoint.h Michael Kubacki
2021-02-23 17:37 ` Laszlo Ersek [this message]
2021-02-24  7:51   ` [edk2-devel] " Ard Biesheuvel
2021-02-25  2:38     ` Michael Kubacki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6991160-035c-6726-79ad-34e7b272fefc@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox