From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124])
 by mx.groups.io with SMTP id smtpd.web12.69.1614101851606259909
 for <devel@edk2.groups.io>;
 Tue, 23 Feb 2021 09:37:31 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TOL+W7Ws;
 spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1614101850;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=EwPMfKUYqJzVuVmYwblpJlPDyzGuqKO/jNszPb9e080=;
	b=TOL+W7Wsp6umbVbo6u3SoExRRrIFXL4IVbdSu6ZlCRH99J1zjzFwdJng5P7eGhS0nNpg0j
	HqKjLUJx2AaIXeN/dBsHJ7gCDrtB+2GlilxILceAZFJf5eobDQ0WTwhuPNz5gYqe6BQIl6
	o7u1Xhf53FbODs5U25QNw5TKq7PETtQ=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-568-miO4zfZxMFmvQAy8Mc3IyQ-1; Tue, 23 Feb 2021 12:37:26 -0500
X-MC-Unique: miO4zfZxMFmvQAy8Mc3IyQ-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E5F9218B6144;
	Tue, 23 Feb 2021 17:37:24 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-109.ams2.redhat.com [10.36.113.109])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 5781110016F7;
	Tue, 23 Feb 2021 17:37:23 +0000 (UTC)
Subject: Re: [edk2-devel] Duplicate Files for StandaloneMmDriverEntryPoint.h
To: devel@edk2.groups.io, mikuback@linux.microsoft.com, sami.mujawar@arm.com,
 supreeth.venkatesh@arm.com, ardb+tianocore@kernel.org,
 Jiewen Yao <jiewen.yao@intel.com>
References: <b59eebc8-beb8-9e0e-e0d3-6bc07aa77276@linux.microsoft.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <a6991160-035c-6726-79ad-34e7b272fefc@redhat.com>
Date: Tue, 23 Feb 2021 18:37:22 +0100
MIME-Version: 1.0
In-Reply-To: <b59eebc8-beb8-9e0e-e0d3-6bc07aa77276@linux.microsoft.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Michael,

On 02/22/21 23:11, Michael Kubacki wrote:
> Is there a particular reason two copies of
> StandaloneMmDriverEntryPoint.h exist in the edk2 repo?
> 
> 1. MdePkg
> https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h
> 
> 
> 2. StandaloneMmPkg
> https://github.com/tianocore/edk2/blob/master/StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h
> 
> 
> The only substantial difference (apart from copyright and comment
> differences) is that the StandaloneMmPkg instance contains a function
> declaration for EfiMain().

I believe this may have been an omission in commit d6253d2f9a33
("StandaloneMmPkg: remove redundant StandaloneMmDriverEntryPoint
driver", 2019-03-11).

At that point, both the library class & instance had been migrated to
MdePkg (commits 7df4764e6a81a and 5866d4992396).

Can you propose a patch (unless I'm wrong, of course)?

Thanks
Laszlo