public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Min Xu" <min.m.xu@intel.com>
To: devel@edk2.groups.io
Cc: Min Xu <min.m.xu@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>,
	Rahul Kumar <rahul1.kumar@intel.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: [PATCH V11 07/47] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception
Date: Mon, 28 Mar 2022 16:07:46 +0800	[thread overview]
Message-ID: <a69ee068a68ea3b4cf8c687dbf3cf7bea60621b0.1648454440.git.min.m.xu@intel.com> (raw)
In-Reply-To: <cover.1648454440.git.min.m.xu@intel.com>

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429

Add base support to handle #VE exceptions. Update the common exception
handlers to invoke the VmTdExitHandleVe () function of the VmgExitLib
library when a #VE is encountered. A non-zero return code will propagate
to the targeted exception handler.

Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Erdem Aktas <erdemaktas@google.com>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
Signed-off-by: Min Xu <min.m.xu@intel.com>
---
 .../PeiDxeSmmCpuException.c                   | 53 ++++++++++++-----
 .../SecPeiCpuException.c                      | 57 +++++++++++++------
 2 files changed, 79 insertions(+), 31 deletions(-)

diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
index 762ea2460f91..f47a80dcab8f 100644
--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
@@ -24,25 +24,48 @@ CommonExceptionHandlerWorker (
   IN EXCEPTION_HANDLER_DATA  *ExceptionHandlerData
   )
 {
+  EFI_STATUS                 Status;
   EXCEPTION_HANDLER_CONTEXT  *ExceptionHandlerContext;
   RESERVED_VECTORS_DATA      *ReservedVectors;
   EFI_CPU_INTERRUPT_HANDLER  *ExternalInterruptHandler;
 
-  if (ExceptionType == VC_EXCEPTION) {
-    EFI_STATUS  Status;
-    //
-    // #VC needs to be handled immediately upon enabling exception handling
-    // and therefore can't use the RegisterCpuInterruptHandler() interface.
-    //
-    // Handle the #VC:
-    //   On EFI_SUCCESS - Exception has been handled, return
-    //   On other       - ExceptionType contains (possibly new) exception
-    //                    value
-    //
-    Status = VmgExitHandleVc (&ExceptionType, SystemContext);
-    if (!EFI_ERROR (Status)) {
-      return;
-    }
+  switch (ExceptionType) {
+    case VC_EXCEPTION:
+      //
+      // #VC needs to be handled immediately upon enabling exception handling
+      // and therefore can't use the RegisterCpuInterruptHandler() interface.
+      //
+      // Handle the #VC:
+      //   On EFI_SUCCESS - Exception has been handled, return
+      //   On other       - ExceptionType contains (possibly new) exception
+      //                    value
+      //
+      Status = VmgExitHandleVc (&ExceptionType, SystemContext);
+      if (!EFI_ERROR (Status)) {
+        return;
+      }
+
+      break;
+
+    case VE_EXCEPTION:
+      //
+      // #VE needs to be handled immediately upon enabling exception handling
+      // and therefore can't use the RegisterCpuInterruptHandler() interface.
+      //
+      // Handle the #VE:
+      //   On EFI_SUCCESS - Exception has been handled, return
+      //   On other       - ExceptionType contains (possibly new) exception
+      //                    value
+      //
+      Status = VmTdExitHandleVe (&ExceptionType, SystemContext);
+      if (!EFI_ERROR (Status)) {
+        return;
+      }
+
+      break;
+
+    default:
+      break;
   }
 
   ExceptionHandlerContext  = (EXCEPTION_HANDLER_CONTEXT *)(UINTN)(SystemContext.SystemContextIa32);
diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuException.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuException.c
index c614d5b0b6f1..6e5216380da8 100644
--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuException.c
+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuException.c
@@ -25,22 +25,47 @@ CommonExceptionHandler (
   IN EFI_SYSTEM_CONTEXT  SystemContext
   )
 {
-  if (ExceptionType == VC_EXCEPTION) {
-    EFI_STATUS  Status;
-    //
-    // #VC needs to be handled immediately upon enabling exception handling
-    // and therefore can't use the RegisterCpuInterruptHandler() interface
-    // (which isn't supported under Sec and Pei anyway).
-    //
-    // Handle the #VC:
-    //   On EFI_SUCCESS - Exception has been handled, return
-    //   On other       - ExceptionType contains (possibly new) exception
-    //                    value
-    //
-    Status = VmgExitHandleVc (&ExceptionType, SystemContext);
-    if (!EFI_ERROR (Status)) {
-      return;
-    }
+  EFI_STATUS  Status;
+
+  switch (ExceptionType) {
+    case VC_EXCEPTION:
+      //
+      // #VC needs to be handled immediately upon enabling exception handling
+      // and therefore can't use the RegisterCpuInterruptHandler() interface
+      // (which isn't supported under Sec and Pei anyway).
+      //
+      // Handle the #VC:
+      //   On EFI_SUCCESS - Exception has been handled, return
+      //   On other       - ExceptionType contains (possibly new) exception
+      //                    value
+      //
+      Status = VmgExitHandleVc (&ExceptionType, SystemContext);
+      if (!EFI_ERROR (Status)) {
+        return;
+      }
+
+      break;
+
+    case VE_EXCEPTION:
+      //
+      // #VE needs to be handled immediately upon enabling exception handling
+      // and therefore can't use the RegisterCpuInterruptHandler() interface
+      // (which isn't supported under Sec and Pei anyway).
+      //
+      // Handle the #VE:
+      //   On EFI_SUCCESS - Exception has been handled, return
+      //   On other       - ExceptionType contains (possibly new) exception
+      //                    value
+      //
+      Status = VmTdExitHandleVe (&ExceptionType, SystemContext);
+      if (!EFI_ERROR (Status)) {
+        return;
+      }
+
+      break;
+
+    default:
+      break;
   }
 
   //
-- 
2.29.2.windows.2


  parent reply	other threads:[~2022-03-28  8:09 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28  8:07 [PATCH V11 00/47] Enable Intel TDX in OvmfPkg (Config-A) Min Xu
2022-03-28  8:07 ` [PATCH V11 01/47] MdePkg: Add Tdx.h Min Xu
2022-03-28  8:07 ` [PATCH V11 02/47] MdePkg: Update Cpuid.h for Tdx Min Xu
2022-03-28  8:07 ` [PATCH V11 03/47] MdePkg: Introduce basic Tdx functions in BaseLib Min Xu
2022-03-28  8:07 ` [PATCH V11 04/47] MdePkg: Add TdxLib to wrap Tdx operations Min Xu
2022-03-28  8:07 ` [PATCH V11 05/47] UefiCpuPkg: Extend VmgExitLibNull to handle #VE exception Min Xu
2022-03-28  8:07 ` [PATCH V11 06/47] OvmfPkg: Extend VmgExitLib " Min Xu
2022-03-28  8:07 ` Min Xu [this message]
2022-03-28  8:07 ` [PATCH V11 08/47] MdePkg: Add helper functions for Tdx guest in BaseIoLibIntrinsic Min Xu
2022-03-28  8:07 ` [PATCH V11 09/47] MdePkg: Support mmio " Min Xu
2022-03-28  8:07 ` [PATCH V11 10/47] MdePkg: Support IoFifo " Min Xu
2022-03-28  8:07 ` [PATCH V11 11/47] MdePkg: Support IoRead/IoWrite " Min Xu
2022-03-28  8:07 ` [PATCH V11 12/47] UefiCpuPkg: Support TDX in BaseXApicX2ApicLib Min Xu
2022-03-28  8:07 ` [PATCH V11 13/47] MdePkg: Add macro to check SEV / TDX guest Min Xu
2022-03-28  8:07 ` [PATCH V11 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib Min Xu
2022-03-28  8:24   ` Ni, Ray
2022-03-29 12:03     ` Min Xu
2022-03-28  8:07 ` [PATCH V11 15/47] OvmfPkg: Add IntelTdx.h in OvmfPkg/Include/IndustryStandard Min Xu
2022-03-28  8:07 ` [PATCH V11 16/47] OvmfPkg: Add TdxMailboxLib Min Xu
2022-03-28  8:07 ` [PATCH V11 17/47] OvmfPkg: Create initial version of PlatformInitLib Min Xu
2022-03-28  8:07 ` [PATCH V11 18/47] OvmfPkg/PlatformInitLib: Add hob functions Min Xu
2022-03-28  8:07 ` [PATCH V11 19/47] OvmfPkg/PlatformPei: Move global variables to PlatformInfoHob Min Xu
2022-03-28  8:07 ` [PATCH V11 20/47] OvmfPkg/PlatformPei: Refactor MiscInitialization Min Xu
2022-03-28  8:08 ` [PATCH V11 21/47] OvmfPkg/PlatformPei: Refactor MiscInitialization for CloudHV Min Xu
2022-03-28  8:08 ` [PATCH V11 22/47] OvmfPkg/PlatformPei: Refactor AddressWidthInitialization Min Xu
2022-03-28  8:08 ` [PATCH V11 23/47] OvmfPkg/PlatformPei: Refactor MaxCpuCountInitialization Min Xu
2022-03-28  8:08 ` [PATCH V11 24/47] OvmfPkg/PlatformPei: Refactor QemuUc32BaseInitialization Min Xu
2022-03-28  8:08 ` [PATCH V11 25/47] OvmfPkg/PlatformPei: Refactor InitializeRamRegions Min Xu
2022-03-28  8:08 ` [PATCH V11 26/47] OvmfPkg/PlatformPei: Refactor MemMapInitialization Min Xu
2022-03-28  8:08 ` [PATCH V11 27/47] OvmfPkg/PlatformPei: Refactor NoexecDxeInitialization Min Xu
2022-03-28  8:08 ` [PATCH V11 28/47] OvmfPkg/PlatformPei: Refactor MiscInitialization Min Xu
2022-03-28  8:08 ` [PATCH V11 30/47] OvmfPkg/PlatformInitLib: Move functions to Platform.c Min Xu
2022-03-28  8:08 ` [PATCH V11 31/47] OvmfPkg: Update PlatformInitLib to process Tdx hoblist Min Xu
2022-03-28  8:08 ` [PATCH V11 32/47] OvmfPkg/Sec: Declare local variable as volatile in SecCoreStartupWithStack Min Xu
2022-03-28  8:08 ` [PATCH V11 33/47] OvmfPkg: Update Sec to support Tdx Min Xu
2022-03-28  8:08 ` [PATCH V11 34/47] OvmfPkg: Check Tdx in QemuFwCfgPei to avoid DMA operation Min Xu
2022-03-28  8:08 ` [PATCH V11 35/47] MdeModulePkg: Skip setting IA32_ERER.NXE if it has already been set Min Xu
2022-03-28  8:08 ` [PATCH V11 36/47] MdeModulePkg: Add PcdTdxSharedBitMask Min Xu
2022-03-28  8:08 ` [PATCH V11 37/47] UefiCpuPkg: Update AddressEncMask in CpuPageTable Min Xu
2022-03-28  8:08 ` [PATCH V11 38/47] OvmfPkg: Update PlatformInitLib for Tdx guest Min Xu
2022-03-28  8:08 ` [PATCH V11 39/47] OvmfPkg: Update PlatformPei to support " Min Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a69ee068a68ea3b4cf8c687dbf3cf7bea60621b0.1648454440.git.min.m.xu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox