From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web09.10711.1615390425132245912 for ; Wed, 10 Mar 2021 07:33:45 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=ET9EGOlh; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: jejb@linux.ibm.com) Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12AFUSRh141417; Wed, 10 Mar 2021 10:33:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : reply-to : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=BgqHoxN36/cJN4uB6NKtbUc7SxnSJycIQrGSjO5d3Ws=; b=ET9EGOlhe5w0mHagCgMvVeYUC3JUSia833aybTrjUPb1WTfPjp1rh7IvCaeJp4jJD5zg H6r/G/lz5zco1NBVI4bRkvE7zA3uDIaDti56Wak0s8qd1hs6T3nZvS+VMQG+rNN4Bao8 +6DXZokh754n03ZY/cknDDVxdDxJ7KnwytE3pQFafZcMi2/Q9DF+DkLrbtGmqdefkgKH j2SH26E3LIprwOCigVx/UsmPYZWaicC4zQymZMDYtknoSO8lsAPWttvb1asL9QuJ27mw 72CTjU6YV+jv8FoedsHCpG4Kz/aBRnH7ORszOzHa2g/APcWS1IXzkzBNX2hqcFPqVn0D 2Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 376gwthk6a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Mar 2021 10:33:40 -0500 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 12AFUieA143297; Wed, 10 Mar 2021 10:33:40 -0500 Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com with ESMTP id 376gwthk5y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Mar 2021 10:33:40 -0500 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 12AFRbE9019200; Wed, 10 Mar 2021 15:33:39 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma02dal.us.ibm.com with ESMTP id 3768rbk0uc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Mar 2021 15:33:39 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 12AFXcgh26608040 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Mar 2021 15:33:38 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 27A4D78060; Wed, 10 Mar 2021 15:33:38 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6217C7805F; Wed, 10 Mar 2021 15:33:36 +0000 (GMT) Received: from jarvis.int.hansenpartnership.com (unknown [9.80.211.242]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 10 Mar 2021 15:33:36 +0000 (GMT) Message-ID: Subject: Re: [PATCH 2/2] Maintainers.txt: Add reviewers for Confidential Computing related modules From: "James Bottomley" Reply-To: jejb@linux.ibm.com To: Laszlo Ersek , Min Xu , Jiewen Yao , Brijesh Singh , Tom Lendacky Cc: devel@edk2.groups.io, Andrew Fish , Leif Lindholm , Michael D Kinney Date: Wed, 10 Mar 2021 07:33:35 -0800 In-Reply-To: <72834ef3-8916-3364-4942-9cc24e4e1d21@redhat.com> References: <20210310025532.2108-1-min.m.xu@intel.com> <20210310025532.2108-3-min.m.xu@intel.com> <72834ef3-8916-3364-4942-9cc24e4e1d21@redhat.com> User-Agent: Evolution 3.34.4 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-03-10_09:2021-03-10,2021-03-10 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 mlxscore=0 mlxlogscore=999 clxscore=1011 bulkscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103100076 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Wed, 2021-03-10 at 15:20 +0100, Laszlo Ersek wrote: [...] > (2) Reviewing this patch makes me realize we've missed some > "Maintainers.txt" updates in the past, in relation to SEV and/or > confidential computing. > > Namely, we did not designated any reviewers for the following > pathnames: > > OvmfPkg/AmdSev/ > OvmfPkg/Include/Guid/ConfidentialComputingSecret.h > OvmfPkg/Library/PlatformBootManagerLibGrub/ > > (from ;), also > > OvmfPkg/ResetVector/ > > (from ;). > > That should be fixed up before adding anything TDX related (I can > submit a patch series, but first, the next point needs to be > cleared.) I'm happy to be added for all of it ... the first three are all me and the last one I added something to. > (3) After racking my brain for half an hour, I can find no good way > to have TDX/SEV separation *plus* a Confidential Computing section in > "Maintainers.txt". Whatever I managed to think of requires us to > either duplicate email addresses, or duplicate pathnames ("F:" > patterns) -- or even both. > > So... can we simply rename the current SEV subsystem to "Confidential > Computing", and keep both TDX and SEV modules under it? We could > place a unified email address list there, with Brijesh, James, > Jiewen, Min, Tom. > > I don't think this should cause any confusion, because: > > - @intel.com emails are clearly closely associated with TDX, and > @amd.com emails are clearly closely associated with SEV, > > - most filenames will (or do already) include "AmdSev" or "Tdx", > > - future patches should clearly label themselves as "SEV only", "TDX > only", or "confidential computing in general" -- this should be clear > from the patch subjects. That should work ... it's entirely possible that SecretDxe and SecretPei can work for Intel as well ... we don't know yet, so they may not need a prefix. > IOW, there should be no confusion as to who's required to review > what, but at the same time we'd have a simple solution for cross- > posting all interested parties. > > Thoughts? Works for me ... IBM is interested in both SEV and TDX and having them be as similar as posisble. James