From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) by mx.groups.io with SMTP id smtpd.web10.31492.1620652851898350641 for ; Mon, 10 May 2021 06:20:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=kXa6BVpw; spf=pass (domain: nuviainc.com, ip: 209.85.222.182, mailfrom: rebecca@nuviainc.com) Received: by mail-qk1-f182.google.com with SMTP id l129so15199019qke.8 for ; Mon, 10 May 2021 06:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yi8UVUdKrRKLSdcJxyDCOPkmeZKiciFJmezHkDxbLyY=; b=kXa6BVpwpU6JMxEmN05jDGS0/aOi/bXApZ9UdxXIwKqQjsMOL0KgyoWuv6N3Y9AIKX L7zYit3L6CgzggfdJJd7fnhETS6fouM8GlbwGAhpYCSLLF65E0hYSowKEulXvS+RKvUS BKmP+l1moMByZpWAGo63yIWEpiak9WVjQe0Hhudhw40LWHHfrWE8mVhn65FlZ+GYwvVa 9NGYarEddKvcohFyIoF2BF487LkY4gHltpCkqojuuL2Ssu49tUt0mBkRmj8UJg7ncHTQ WdnrGrha7jxZv1PKdbXvkp9pItj7QsuEdh46Zc2QVAbOdHPN7vqxYpMuevXjK8qawXjT IAjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yi8UVUdKrRKLSdcJxyDCOPkmeZKiciFJmezHkDxbLyY=; b=NeajwKvYFAEJ/FRqlHlKH2M+vsULPwTQafa6yVB4DtJuEhtQcfzAWcDZztSEqu2tXl muc3+6rMwHyatUXmphd94530o73Bf3MiG26Njubza/v93JcvPVtrsCtYVnP+n8fGZPVl uaYAOPz44FDLm6eA0VbWTvmyS3eBf0SHCCpieMnAV24DCPl31/knhOSz3MlsNWVbvj5H Yj0xghwUR1l53frlDOKerSg1vJ6NpK3cMDQ7qNU4Fu4SJN/dMQb6Nna89mPSrTkAm0nB RUUJbGZYhuyqPkBRW2c7igMGv9bKcxUED6Ffwulis/KILuTi1rriSdplMUeilpjgpaiN Khug== X-Gm-Message-State: AOAM530FAH7u07P/gl8U8ZmN7K/xJp8nEOyNoJV4wGmaecyBRQcHlgRB iJzIoyrYMDIf0b9ZF1H9cwCCJA== X-Google-Smtp-Source: ABdhPJxYQhViGcTqT4LXgv/ANqatPXPdGXUGFlgjan7p06bLDAaU6DKZ6u/eGPJE+Jtxi2/UBKyUYw== X-Received: by 2002:ae9:dc47:: with SMTP id q68mr22701236qkf.197.1620652850989; Mon, 10 May 2021 06:20:50 -0700 (PDT) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id n136sm11488734qka.133.2021.05.10.06.20.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 May 2021 06:20:50 -0700 (PDT) Subject: Re: [edk2-devel] Build fails with VS2012 To: devel@edk2.groups.io, lersek@redhat.com, rebecca@bsdio.com Cc: Michael D Kinney , Tom Lendacky References: <298de55b-7cbd-22be-b584-9b83ccfe2b06@bsdio.com> <0ef244cf-7100-4f1b-29f5-607e9e243061@redhat.com> From: "Rebecca Cran" Message-ID: Date: Mon, 10 May 2021 07:20:48 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <0ef244cf-7100-4f1b-29f5-607e9e243061@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 5/10/21 5:56 AM, Laszlo Ersek wrote: > Hi Rebecca > > +Tom > > On 05/08/21 21:47, Rebecca Cran wrote: >> I'm setting up a new Jenkins server to do Bhyve builds and run on >> platforms that aren't currently tested with the GitHub/Azure system. >> >> Since VS2012 appears to be a supported toolchain, I tried building >> OvmfPkgX64 with it (I'm also planning on testing VS2013, VS2015, VS2017 >> and VS2019), but it fails with: >> >> >> Building ... >> c:\users\administrator\src\edk2\NetworkPkg\Library\DxeUdpIoLib\DxeUdpIoLib.inf >> [X64] >> c:\users\administrator\src\edk2\UefiCpuPkg\Library\MpInitLib\MpLib.c(1268) >> : error C2220: warning treated as error - no 'object' file generated >> c:\users\administrator\src\edk2\UefiCpuPkg\Library\MpInitLib\MpLib.c(1268) >> : warning C4306: 'type cast' : conversion from 'int' to >> 'SEV_ES_AP_JMP_FAR *' of greater size > > I think the compiler is justified to complain here: > > 7b7508ad784d1 (Tom Lendacky 2020-08-12 15:21:42 -0500 1268) JmpFar = (SEV_ES_AP_JMP_FAR *) FixedPcdGet32 (PcdSevEsWorkAreaBase); > > The proper way to spell such casts is with (UINTN) in the middle. > > Can you please file a new BZ? I've created https://bugzilla.tianocore.org/show_bug.cgi?id=3385 >> I know the GitHub/Azure system only tests with VS2017 and VS2019: are >> there plans to drop the older VS versions, or should they still work? >> And would it be considered useful to _check_ that they still work, or >> should they be considered unsupported? > > I'd suggest dropping them. > > Earlier, Ard raised a similar question for gcc too -- IIRC, Ard suggested that GCC4* be removed. I agree with the idea. Thanks. If we're ready to go ahead, should I create a patch to remove them? Do you know what the new minimum version of gcc should then be? I'd like to run builds with it so we can catch any issues. Would we remove all VS versions except VS2017 and VS2019, or would we keep others like VS2015 for now? -- Rebecca Cran