From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.2263.1571785053363523400 for ; Tue, 22 Oct 2019 15:57:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QqLaJ6Yf; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571785052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UljJv4tvtTQ8gBf57zJ45M+4nTHWz0vnpLvqgZUOIhc=; b=QqLaJ6Yf22gYT7qCFy2Ycx57d3Tk8QiShqrDZ9YMRlpWobACvmD8lC5zJLSXJUi267gjVq ifE7p2P1pcH22nxPVEEixMzJvaMrJBIfIu1PwybN8YqJqTST/8UE7RI527zjz3lvfpYidD 2Sdq0BmU1/NmBkplFUSYUOf3snqCpCU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-267-ofemLWMeOzmFwCZfph-qIA-1; Tue, 22 Oct 2019 18:57:28 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 63C40107AD31; Tue, 22 Oct 2019 22:57:27 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 304163CCA; Tue, 22 Oct 2019 22:57:25 +0000 (UTC) Subject: Re: [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc To: Michael D Kinney , devel@edk2.groups.io Cc: Sean Brogan , Eric Dong , Ray Ni References: <20191022190659.26912-1-michael.d.kinney@intel.com> From: "Laszlo Ersek" Message-ID: Date: Wed, 23 Oct 2019 00:57:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191022190659.26912-1-michael.d.kinney@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: ofemLWMeOzmFwCZfph-qIA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/22/19 21:06, Michael D Kinney wrote: > From: Sean Brogan >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2255 >=20 > Update UefiCpuPkg.dsc to guarantee all libraries and > modules are always built. Add the following components. >=20 > * UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf > * UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf >=20 > ResetVector.inf is a binary INF, so no source builds are > triggered from adding this line. However, a build with > this component does verify the contents of the INF file. >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Michael D Kinney > --- > UefiCpuPkg/UefiCpuPkg.dsc | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc > index e7dfe30eda..d28cb5cccb 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dsc > +++ b/UefiCpuPkg/UefiCpuPkg.dsc > @@ -121,6 +121,7 @@ [Components.IA32, Components.X64] > UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf > UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf > UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf > + UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf > UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.in= f > UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLib= .inf > UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.in= f > @@ -146,6 +147,7 @@ [Components.IA32, Components.X64] > SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeatu= resLibStm.inf > } > UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf > + UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf > =20 > [BuildOptions] > *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES >=20 Can we retire UefiCpuPkg/ResetVector/Vtf0/Bin/ instead (in a separate patch)? Because, according to git log --stat master -- UefiCpuPkg/ResetVector/Vtf0/Bin/ the most recent commit in which we updated the *.raw files has been f7bb98019a71 ("UefiCpuPkg VTF0: Fix support for finding SEC image of type TE.", 2011-09-28). I doubt anyone consumes this (binary) module, since Jordan's commits - 5a1f324d946c ("UefiCpuPkg: Support building VTF0 ResetVector during the EDK II build", 2014-08-18) - eee1d2ca9078 ("UefiCpuPkg VTF0 X64: Build page tables in NASM code", 2014-08-18). We've by now dropped all top-level *BinPkg package directories too. If we remove the Bin subdir, then we should probably remove: - Build.py - Tools/ too. For the other addition (CpuCommonFeaturesLib): if that gets its own patch (after the removal of UefiCpuPkg/ResetVector/Vtf0/Bin/), then please add Reviewed-by: Laszlo Ersek to it. Thanks Laszlo