From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web12.49376.1598864290034699628 for ; Mon, 31 Aug 2020 01:58:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UE/eM9yL; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598864289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tIlfBrDmpE9CidGZo2O0m2oxeh0JGV4YHzn+qh4tDsw=; b=UE/eM9yLAZP6U1O2hlSx/cDxmYtzh8sPfl/lyEWgp0z8sz4nfany3YlgO6kEHiOn8tAbWA iLs+W4MgACUnxRRy4zXswSi8HUckh1zygroRcYgpFdoopZM87dwWjOqf7NPGwMxjRHUTpV aFqLAZOkN/fERSWBdO09vAX+aD0txb4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-171-WqklQftzPOSGd_lPmOIJHA-1; Mon, 31 Aug 2020 04:58:07 -0400 X-MC-Unique: WqklQftzPOSGd_lPmOIJHA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 862F5425D3; Mon, 31 Aug 2020 08:58:05 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-125.ams2.redhat.com [10.36.113.125]) by smtp.corp.redhat.com (Postfix) with ESMTP id 18DEB60C04; Mon, 31 Aug 2020 08:58:03 +0000 (UTC) Subject: Re: [PATCH 1/1] Maintainers.txt: Update reviewers of */RiscV64 To: Leif Lindholm , Abner Chang Cc: devel@edk2.groups.io, Andrew Fish , Michael D Kinney , Leif Lindholm References: <20200830080306.17769-1-abner.chang@hpe.com> <20200830114401.GB20124@vanye> From: "Laszlo Ersek" Message-ID: Date: Mon, 31 Aug 2020 10:58:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200830114401.GB20124@vanye> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 08/30/20 13:44, Leif Lindholm wrote: > On Sun, Aug 30, 2020 at 16:03:06 +0800, Abner Chang wrote: >> Add reviewers for all /RiscV64 folders. >> >> Signed-off-by: Abner Chang >> Cc: Andrew Fish >> Cc: Laszlo Ersek >> Cc: Leif Lindholm >> Cc: Michael D Kinney >> Cc: Leif Lindholm >> --- >> Maintainers.txt | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Maintainers.txt b/Maintainers.txt >> index 57cd2fc662..ff34a24abd 100644 >> --- a/Maintainers.txt >> +++ b/Maintainers.txt >> @@ -98,6 +98,11 @@ F: */Arm/ >> M: Leif Lindholm >> M: Ard Biesheuvel >> >> +RISCV64 >> +F: */RiscV64/ >> +R: Abner Chang >> +R: Daniel Schaefer > > I think we want an M: entry for this, and I think that should be you > (since you have the access privileges). It signifies that you are the > one responsible for patches that have been reviewed actually get > pushed. > > This doesn't always mean you need to do it yourself, especially for > this entry which will always overlap with other entries (like MdePkg, > MdeModulePkg, ...), but it does make it clear that you need to make > sure it doesn't get dropped. > > With that change: > Reviewed-by: Leif Lindholm > >> + >> EDK II Continuous Integration: >> ------------------------------ >> .azurepipelines/ >> -- >> 2.25.0 >> > The placement and the contents of the addition look good to me. I don't know what the best approach is regarding R vs M. With or without the modification suggested by Leif: Acked-by: Laszlo Ersek Thanks Laszlo