From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 73E99AC16DD for ; Mon, 4 Sep 2023 20:14:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=gCizS88CjmJ89OJK7xZJz5UMPVEdkHobruGGtZ+1AFc=; c=relaxed/simple; d=groups.io; h=Feedback-ID:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1693858478; v=1; b=J+h18xw0H1S2jhYY0zvIiRo5IyEX0cCk2J8RaRbuM3I+zGcwZCK6BOae8OMvAUlKuv5exq/R UNBANiCleG/M4qhoSk7ZJPpe/3wdP/lnQiul4W2KAyfn8Bw9UxrFgcoeHBUHaxCvkrjaaQqNtzJ 9U+Pze9T0oIn7ZaFrB133TJs= X-Received: by 127.0.0.2 with SMTP id g8luYY7687511x9KpBD7VoVW; Mon, 04 Sep 2023 13:14:38 -0700 X-Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mx.groups.io with SMTP id smtpd.web10.6117.1693858476957659525 for ; Mon, 04 Sep 2023 13:14:37 -0700 X-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 960AD320014C; Mon, 4 Sep 2023 16:14:35 -0400 (EDT) X-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 04 Sep 2023 16:14:36 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudegkedgudegkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomheptfgv sggvtggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrf grthhtvghrnhepjeejkeekgfeuvdfhiedtudfhvedvleduieelgffhvddttdejieegffek hfevffegnecuffhomhgrihhnpehtihgrnhhotghorhgvrdhorhhgpdhgrhhouhhpshdrih honecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhgv sggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 4 Sep 2023 16:14:34 -0400 (EDT) Message-ID: Date: Mon, 4 Sep 2023 14:14:24 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then running QEMU To: devel@edk2.groups.io, mjsbeaton@gmail.com, devel@edk2.groups.io, mjsbeaton@gmail.com Cc: Rebecca Cran , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann References: <20230208180138.430549-1-rebecca@quicinc.com> From: "Rebecca Cran" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 11GTDuYFBgrNaSCSfHx4r0ajx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=J+h18xw0; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Sorry I've not responded to your emails before now. I don't normally use the build.sh script, so I'm fine with reverting to=20 the previous behavior. --=20 Rebecca Cran On 9/4/23 08:24, Mike Beaton wrote: >> -----Original Message----- >> From: Rebecca Cran >> Sent: Wednesday, February 8, 2023 6:02 PM >> To: devel@edk2.groups.io >> Cc: Rebecca Cran ; Ard Biesheuvel ; Jiewen Yao ; Jordan Justen ; Gerd Hoffmann >> Subject: [PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF the= n running QEMU >> >> Allow users to build OVMF then run QEMU by moving the build block above >> the run block and removing the exit line. >> >> Signed-off-by: Rebecca Cran >> Cc: Ard Biesheuvel >> Cc: Jiewen Yao >> Cc: Jordan Justen >> Cc: Gerd Hoffmann >> --- >> OvmfPkg/build.sh | 13 +++++-------- >> 1 file changed, 5 insertions(+), 8 deletions(-) >> >> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh >> index 91b1442ade6b..b0334fb76e74 100755 >> --- a/OvmfPkg/build.sh >> +++ b/OvmfPkg/build.sh >> @@ -245,6 +245,11 @@ else >> echo using prebuilt tools >> fi >> >> +# >> +# Build the edk2 OvmfPkg >> +# >> +echo Running edk2 build for OvmfPkg$Processor >> +build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS = -n $THREADNUMBER -DDEBUG_ON_SERIAL_PORT=3DTRUE >> >> if [[ "$RUN_QEMU" =3D=3D "yes" ]]; then >> if [[ ! -d $QEMU_FIRMWARE_DIR ]]; then >> @@ -260,11 +265,3 @@ if [[ "$RUN_QEMU" =3D=3D "yes" ]]; then >> $QEMU_COMMAND "$@" >> exit $? >> fi >> - >> -# >> -# Build the edk2 OvmfPkg >> -# >> -echo Running edk2 build for OvmfPkg$Processor >> -build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS = -n $THREADNUMBER >> -exit $? >> - >> -- >> 2.30.2 > Hi, > > I was trying to raise the issue that I believe this change from Feb. > of this year breaks intended and useful previous behaviour. It > occurred to me that replying to the original post might make most > sense. I've raised what I think are the issues here: > https://bugzilla.tianocore.org/show_bug.cgi?id=3D4528 . > > WIth many thanks in advance for your attention. > > Mike Beaton > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108265): https://edk2.groups.io/g/devel/message/108265 Mute This Topic: https://groups.io/mt/96836052/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-