From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.50]) by mx.groups.io with SMTP id smtpd.web09.5912.1658407330722481305 for ; Thu, 21 Jul 2022 05:42:11 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=7IpBOj7x; spf=pass (domain: arm.com, ip: 40.107.6.50, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=WS2yUFAX0Q1Df+OMocWamk/sipf8oJRolIXIqk0S19CcB/WbmA/0oXJCNHp7cwZbxN8yKGzNtf343+rIERKpNlI4G9Nbvz3tz3eq2uIM4MuMVodPsJlgCN1CVJJ6PcCL2bepr8e18+i8QEG5aMRHEPNw6VfqnKkJ9h03HQYXmoFzO+RGNsj3te7Ix7RnB38MjuKArD/41dzSLcdzmsVC3r3DJK4NGK+vZ48mbAmPpOpKt64rU2a7DWLuWg7Tur8p4iB2sOKJMvy2Wvs6UDO0JzMi51WkOq9No29CWfUCOxvE+KeRUqPTV24adV2ZMWgPQt+dIQrGEE9vTTifG9/FvA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wvojS/pa7oLcofJLChzUAx680uQWh0cuapxsDy8+YQQ=; b=gWIMIlIvmchuvrTCR2WQOqxqIB34/QrB9gy+1GvcxBgX+Z4ZloyC4FLi9Bl0iqKJ0EVfCLnw3spYiiOPR+VO1xkLEW+Gt9R2OVje6YsmgKLx6TrPBo1pNfzjinLFK2oz7hswk0qM4z3iM0G8anKA3CjTA7sjtHAHgeQZ9wRl8XHJaeNWwYQkYv1FEmAtDXxs2UJE8NYHp7Ft6aQ7RdEbe8npWK6KRAzceGo/yO8MCHwlyaEQWuqJHAKyEUVVwRxOo/IRiuIvL8RzDpt0NiSl3OhirPx1EVhLDk1cHslUoeSfWkcAz60R4RgM427/Tjvl3Xg7xn6A1vrbC4elWtyBUQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wvojS/pa7oLcofJLChzUAx680uQWh0cuapxsDy8+YQQ=; b=7IpBOj7xfRlBQBiQsyjo35u+8z+rRaWm6AkjSA06VXBE/jt9gxcc0274HfBujz1qDHPigMKNw/RnRZT9Tt+EZLFIa2+i1Q+nr0/eaFGvEsNaU0fHx+VEPDlW3VMr5Q9zPEW/pVQMWnpQLmovzY3Z+ebNuLq5aP+3UqOacxnQvq8= Received: from DB8P191CA0017.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::27) by VI1PR08MB3376.eurprd08.prod.outlook.com (2603:10a6:803:7a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Thu, 21 Jul 2022 12:42:07 +0000 Received: from DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:130:cafe::e9) by DB8P191CA0017.outlook.office365.com (2603:10a6:10:130::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18 via Frontend Transport; Thu, 21 Jul 2022 12:42:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT059.mail.protection.outlook.com (100.127.142.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Thu, 21 Jul 2022 12:42:07 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Thu, 21 Jul 2022 12:42:07 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d862f65dac2c51ef X-CR-MTA-TID: 64aa7808 Received: from 2b1842a0160b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9584BF37-F1A4-4240-B9F3-3F9A2A0E21F8.1; Thu, 21 Jul 2022 12:41:58 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2b1842a0160b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Jul 2022 12:41:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IYByti7s7MZ9T28Zu5mSZQr2VOPvKsMZTTwk4TekDtlPTuXETPD/yHRa5+7IBvZeG1dKJh2D96Nc0V4mml2Y5n8GvN9PPCaIL/xRWUa7y1mLUAEeEpoTWVcHd72OkKz1WKZ2Zu4jsES0UW35H1f3+t1OJT0U8BFpUoqVwo+NPMC8O+BIOSrwdjRvGydEjtKvDs9BmDDuhcIetKReJ7UX20KVxGSIEBPwycMnUSM910ukcGP6lZjYZzC2TYLXN7Gojitwb7r3YHk2MEJ8irQVxZtk6GZ46MAOul/cY4lBY5uphE8mCB70y91aaa70/B53LspscJsjw+uw96+s3hsr7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wvojS/pa7oLcofJLChzUAx680uQWh0cuapxsDy8+YQQ=; b=KyOjw2L+8YS/9se/2i/LqanS9G0o9D91pb6bqRx1GqXDQzCZaz6qGL17EvpdjfJytF7rpU0qQsqEGdFrbDY4A9n/qUgOLPimAIEKjghaG77KKZ6qjDLagwWuXlSEXOqh08PyJOaPlF7rUScxlRraEFUdwlHAeZIAKF0HEqR5BcAVuShJdXZ+JgftC5Mfy5E1djbVeb3wcbzMA3lb1eadjzMY6ZiDOTk3+8OW9RmgRZKBMG37tDq26YfqZ0I2grziRNl2tJBHuW4hqfXbnyjPa6fpiVpDFjOjGngRszsmHhSS8q3EECvIthsx5SmS3fDH8aHO8qa28HwIOmBfXpVGxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wvojS/pa7oLcofJLChzUAx680uQWh0cuapxsDy8+YQQ=; b=7IpBOj7xfRlBQBiQsyjo35u+8z+rRaWm6AkjSA06VXBE/jt9gxcc0274HfBujz1qDHPigMKNw/RnRZT9Tt+EZLFIa2+i1Q+nr0/eaFGvEsNaU0fHx+VEPDlW3VMr5Q9zPEW/pVQMWnpQLmovzY3Z+ebNuLq5aP+3UqOacxnQvq8= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by HE1PR0801MB2010.eurprd08.prod.outlook.com (2603:10a6:3:4b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 21 Jul 2022 12:41:53 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9%4]) with mapi id 15.20.5458.018; Thu, 21 Jul 2022 12:41:53 +0000 Message-ID: Date: Thu, 21 Jul 2022 13:41:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT To: Rohit Mathew , devel@edk2.groups.io CC: Ard Biesheuvel , Thomas Abraham , nd@arm.com References: <20220704165909.17895-1-rohit.mathew@arm.com> <20220704165909.17895-3-rohit.mathew@arm.com> From: "Sami Mujawar" In-Reply-To: <20220704165909.17895-3-rohit.mathew@arm.com> X-ClientProxiedBy: LO4P123CA0608.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:314::8) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: ef920f96-cc54-42de-4a00-08da6b166c2a X-MS-TrafficTypeDiagnostic: HE1PR0801MB2010:EE_|DBAEUR03FT059:EE_|VI1PR08MB3376:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: L/6OK80xqvezyNtLlapq/EonFlCSRCuK+icHCSJX8+Nj/Wyr+sjoxRlX04g9WkCiiSJwcFWDn1EUlSz8mYv2z6GX7N9ov4HpncjjTn4avwRnCdk00hhnPx1jrvTCrnlm0dkTntzTTMwv8TQHqFRzBQPvzE1psEspM5HqvWtNpOz135PifpxJIsx702D1SMyQmi3qvhiG93F8p8ogYoDWP9GyRAJTyIHKmdsWTxuwYYwh5ffs0Z6BPxdGfP1BqAdrp/8oRu1sEfYxSaZ8820lZukAL8ptsba2FNc5Da5RVEUWKgIk18zPGKRX9to1hQX7KBhiJGSMoD8NcPk6HmmfGyYXEaXco7Ejg1m3+HO9khZKCERbPps/rW7yGhTDv0rZPZ6FR02t/y+g0xPYv/XUSY7uUbTXKQZLdLpPv2W2Nt6cnxIVRuflCUUI9xQeRLo04YscgHWIJYebkHCJLBQMh/vkR75l8GxMedqETE8RfizRVS1eey4jZ2ar4KX8zNZJNTNHU6TF4XiTsUrkTASfw40Z2Q9DUN0dAz4sMDi2Th7fuIt/Nn42mqoeIkUPe6xR6BH9Qoc9diKi5RY9SknCKinU2BsR8lOT98PAMWL8AA4g4vYdZSCZAXTDuXZF3+bhm7SDVGdi6ekNJTn5/HfYXYzsjKF+d7nYSZgzOZ1vlecJNRWUJmIoj4EkfHx3BRBYhMiRSxke/9Iir9fwn3zzmq75wMsRWAAS1iFOyJk621884SK9wcWcmSyvgM/je2Kvl7KYTwZwnsosC+aQRimPgpE4mhit6cKYzV2l7pM1HSwebGWxOgXGv7MvpHQH+nFHQ7kYHHUmSHif6DElGBJqBA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(396003)(39860400002)(346002)(376002)(54906003)(31686004)(38100700002)(2906002)(66946007)(36756003)(316002)(5660300002)(4326008)(66556008)(8936002)(44832011)(19627235002)(8676002)(41300700001)(26005)(6512007)(478600001)(6486002)(31696002)(66476007)(6506007)(186003)(83380400001)(86362001)(53546011)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2010 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 65bef7be-db70-4822-410e-08da6b1663a1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EtHuuFFYZbhQDRFxRDu0l3sPdS6fsQuJfZl1ItZ6M83adY3SpCPa2k1CICEwmlDleGYuV8KqYNu3aj6TJ5fdHCPuPMD/0Hk8pqTA8G34iRhz4uGB8EOBNFUIDrw1axjjYwrWhw+zEt4smso7wNYF5ae3zCYAGbJX5ZxIqctZlrSXqIj4mPOODXKNPuK51Fe9mOt15N3nCUCrQC1KSoD4M3Fw2eCOZ3UgIm/jEPA5Hay/vfCkuOpFJhEe9MypWxM93KsM7TopgLh56UhcTl0fzbOeY/zj+Eu/Rt4TMmWbL14fRvon6NITD2iQokXHI4bGkHkdXScurPzLRHnnKQqYdTH9E16NpERBYgPABGyHHeEuA/npihMyMw4vI+qtGciwjHWFopWIHz62dJvlL28DmoNHHbOWpJE3bcLLTRLyfUHMsgZo0+k1Dc1zfzaZLlIHONNz4tjnFDShH51DNuSaOq368KmFHWQA9IumSdMJ9xxcqZnt8k9QGKFzhNxJAo+wEuhCucExba3BcNR3/EEz/AldChRZdw7fE51apZyMFoCCEAnzIuFqPkTbyLtMQDAfC1/9mNTonZwhcr+7YE5iW9Q59WEddhFPBJ+ocbwjr2CKAdZlUG1PlmsIKFS1bhIlJlgzRdy7MRQnJUgLUfXK2FHdozl+Cx7wLeWE7g0lUhArmugSsAiqidh883bWK2hjrXqssdphPRuJU8ANxpp86M3fdBdBL9y4SLDK812flj4GcM82EhGeiI3kKzINk8BzvxIuxIkvpzhzQWxh6AxQCQXQLPyVJcSlLJxQbsMgzc6A+rXUaByY+oRFV7EOUgZXlqhXvo6SwjELZ1lTx1PxMg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(396003)(136003)(40470700004)(46966006)(36840700001)(86362001)(36860700001)(31696002)(356005)(8936002)(81166007)(8676002)(2906002)(82740400003)(6512007)(40480700001)(44832011)(5660300002)(53546011)(6506007)(36756003)(40460700003)(478600001)(316002)(26005)(41300700001)(82310400005)(54906003)(6486002)(83380400001)(70586007)(2616005)(70206006)(19627235002)(186003)(4326008)(336012)(31686004)(47076005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 12:42:07.4509 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ef920f96-cc54-42de-4a00-08da6b166c2a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3376 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Rohit, Have you considered moving to use Dynamic Tables Framework? There is=20 just too much repetition in this series which can be easily avoided. It=20 will also make the code more maintainable. Apart from this I have a comment marked inline as [SAMI]. Regards, Sami Mujawar On 04/07/2022 05:59 pm, Rohit Mathew wrote: > Add a new device entry in the SSDT ACPI table to describe the serial > port used as the debug port. On the Neoverse reference design platforms, > the UART0 port of the SoC is used as the debug port. > > Signed-off-by: Rohit Mathew > --- > Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf | 1 + > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf | 1 + > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 1 + > Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf | 1 + > Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf | 1 + > Platform/ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf | 1 + > Platform/ARM/SgiPkg/AcpiTables/RdV1McAcpiTables.inf | 1 + > Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf | 1 + > Platform/ARM/SgiPkg/AcpiTables/SsdtRos.asl | 15 ++++++++++= +++++ > 9 files changed, 23 insertions(+) > > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf b/Plat= form/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf > index d2935f1e73e1..d46ae0274d90 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf > @@ -39,6 +39,7 @@ [Packages] > [FixedPcd] > gArmPlatformTokenSpaceGuid.PcdCoreCount > gArmPlatformTokenSpaceGuid.PcdClusterCount > + gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt > gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase > gArmPlatformTokenSpaceGuid.PL011UartInterrupt > =20 > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf b/Plat= form/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf > index 73f47ece7718..4bf681d3bc2e 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf > @@ -39,6 +39,7 @@ [Packages] > [FixedPcd] > gArmPlatformTokenSpaceGuid.PcdCoreCount > gArmPlatformTokenSpaceGuid.PcdClusterCount > + gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt > gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase > gArmPlatformTokenSpaceGuid.PL011UartInterrupt > =20 > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Pl= atform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf > index da14120bde69..89f532217ceb 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf > @@ -41,6 +41,7 @@ [Packages] > [FixedPcd] > gArmPlatformTokenSpaceGuid.PcdCoreCount > gArmPlatformTokenSpaceGuid.PcdClusterCount > + gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt > gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase > gArmPlatformTokenSpaceGuid.PL011UartInterrupt > =20 > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf b/Platform= /ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf > index 90976250445e..66d5422df36b 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf > @@ -37,6 +37,7 @@ [Packages] > Platform/ARM/SgiPkg/SgiPlatform.dec > =20 > [FixedPcd] > + gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt > gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase > gArmPlatformTokenSpaceGuid.PL011UartInterrupt > gArmPlatformTokenSpaceGuid.PcdCoreCount > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf b/Plat= form/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf > index 95fb446c105d..742734ab7348 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf > @@ -37,6 +37,7 @@ [Packages] > Platform/ARM/SgiPkg/SgiPlatform.dec > =20 > [FixedPcd] > + gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt > gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase > gArmPlatformTokenSpaceGuid.PcdCoreCount > gArmPlatformTokenSpaceGuid.PcdClusterCount > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf b/Platform= /ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf > index 3540575dd641..cc41dda1a135 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf > @@ -37,6 +37,7 @@ [Packages] > Platform/ARM/SgiPkg/SgiPlatform.dec > =20 > [FixedPcd] > + gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt > gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase > gArmPlatformTokenSpaceGuid.PL011UartInterrupt > gArmPlatformTokenSpaceGuid.PcdCoreCount > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdV1McAcpiTables.inf b/Platfo= rm/ARM/SgiPkg/AcpiTables/RdV1McAcpiTables.inf > index c6bd69b4a538..ecb42bf3cc33 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdV1McAcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdV1McAcpiTables.inf > @@ -39,6 +39,7 @@ [Packages] > Platform/ARM/SgiPkg/SgiPlatform.dec > =20 > [FixedPcd] > + gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt > gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase > gArmPlatformTokenSpaceGuid.PL011UartInterrupt > gArmPlatformTokenSpaceGuid.PcdCoreCount > diff --git a/Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf b/Platfo= rm/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf > index cb3f3fcdb9b6..379b5c9e6122 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf > @@ -39,6 +39,7 @@ [Packages] > [FixedPcd] > gArmPlatformTokenSpaceGuid.PcdCoreCount > gArmPlatformTokenSpaceGuid.PcdClusterCount > + gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt > gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase > gArmPlatformTokenSpaceGuid.PL011UartInterrupt > =20 > diff --git a/Platform/ARM/SgiPkg/AcpiTables/SsdtRos.asl b/Platform/ARM/Sg= iPkg/AcpiTables/SsdtRos.asl > index fd20c67e1225..ab8578072836 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/SsdtRos.asl > +++ b/Platform/ARM/SgiPkg/AcpiTables/SsdtRos.asl > @@ -29,6 +29,21 @@ DefinitionBlock ("SsdtRosTable.aml", "SSDT", 2, "ARMLT= D", "ARMSGI", > }) > } > =20 > + Device (COM1) { > + Name (_HID, "ARMH0011") > + Name (_CID, "ARMH0011") [SAMI] Any reason for not using=C2=A0 ARMHB000 (see Section 2.3 of the ACPI= =20 for Arm Components 1.1 specification)? > + Name (_UID, One) > + Name (_STA, 0xF) > + Name (_CRS, ResourceTemplate () { > + Memory32Fixed ( > + ReadWrite, > + FixedPcdGet64 (PcdSerialDbgRegisterBase), > + 0x1000 > + ) > + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { Fix= edPcdGet32 (PcdSerialDbgInterrupt) } > + }) > + } > + > // VIRTIO DISK > Device (VR00) { > Name (_HID, "LNRO0005")