From: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, edk2-devel@lists.01.org
Cc: Achin Gupta <achin.gupta@arm.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
Jagadeesh Ujja <jagadeesh.ujja@arm.com>,
Thomas Panakamattam Abraham <thomas.abraham@arm.com>,
Sami Mujawar <Sami.Mujawar@arm.com>
Subject: Re: [PATCH 1/8] StandaloneMmPkg/StandaloneMmCpu: fix typo Standlone -> Standalone
Date: Fri, 04 Jan 2019 11:48:01 -0600 [thread overview]
Message-ID: <a6e9e45cda30078cb91e44c3ca6057003ae33a1b.camel@arm.com> (raw)
In-Reply-To: <20190104110315.18339-2-ard.biesheuvel@linaro.org>
On Fri, 2019-01-04 at 12:03 +0100, Ard Biesheuvel wrote:
> Fix a couple of occurrences of typo Standlone -> Standalone. Since
> _PiMmStandloneArmTfCpuDriverEntry() is never referenced, drop it
> altogether.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> ---
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c
> | 2 +-
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c
> | 6 +++---
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h
> | 8 +-------
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
> | 4 ++--
> 4 files changed, 7 insertions(+), 13 deletions(-)
>
> diff --git
> a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c
> b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c
> index 2814577b3fcc..25114821448a 100644
> --- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c
> +++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c
> @@ -65,7 +65,7 @@ EFI_MM_CONFIGURATION_PROTOCOL mMmConfig = {
> STATIC EFI_MM_ENTRY_POINT mMmEntryPoint = NULL;
>
> EFI_STATUS
> -PiMmStandloneArmTfCpuDriverEntry (
> +PiMmStandaloneArmTfCpuDriverEntry (
> IN UINTN EventId,
> IN UINTN CpuNumber,
> IN UINTN NsCommBufferAddr
> diff --git
> a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c
> b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c
> index 85a9c108aea4..203a32baaaf9 100644
> ---
> a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c
> +++
> b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c
> @@ -74,7 +74,7 @@ GetGuidedHobData (
> }
>
> EFI_STATUS
> -StandloneMmCpuInitialize (
> +StandaloneMmCpuInitialize (
> IN EFI_HANDLE ImageHandle, // not actual imagehandle
> IN EFI_MM_SYSTEM_TABLE *SystemTable // not actual systemtable
> )
> @@ -147,8 +147,8 @@ StandloneMmCpuInitialize (
> // Share the entry point of the CPU driver
> DEBUG ((DEBUG_INFO, "Sharing Cpu Driver EP *0x%lx = 0x%lx\n",
> (UINT64) CpuDriverEntryPointDesc->ArmTfCpuDriverEpPtr,
> - (UINT64) PiMmStandloneArmTfCpuDriverEntry));
> - *(CpuDriverEntryPointDesc->ArmTfCpuDriverEpPtr) =
> PiMmStandloneArmTfCpuDriverEntry;
> + (UINT64) PiMmStandaloneArmTfCpuDriverEntry));
> + *(CpuDriverEntryPointDesc->ArmTfCpuDriverEpPtr) =
> PiMmStandaloneArmTfCpuDriverEntry;
>
> // Find the descriptor that contains the whereabouts of the buffer
> for
> // communication with the Normal world.
> diff --git
> a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h
> b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h
> index 7b38b65e1242..543467f67576 100644
> ---
> a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h
> +++
> b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h
> @@ -40,7 +40,7 @@ extern
> MP_INFORMATION_HOB_DATA *mMpInformationHobData;
> extern EFI_MM_CONFIGURATION_PROTOCOL mMmConfig;
>
> EFI_STATUS
> -PiMmStandloneArmTfCpuDriverEntry (
> +PiMmStandaloneArmTfCpuDriverEntry (
> IN UINTN EventId,
> IN UINTN CpuNumber,
> IN UINTN NsCommBufferAddr
> @@ -55,10 +55,4 @@ PiMmCpuTpFwRootMmiHandler (
> IN OUT UINTN *CommBufferSize OPTIONAL
> );
>
> -EFI_STATUS _PiMmStandloneArmTfCpuDriverEntry (
> - IN UINTN EventId,
> - IN UINTN CpuNumber,
> - IN UINTN NsCommBufferAddr
> - );
> -
> #endif
> diff --git
> a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
> b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
> index 9e6bbabdb103..d261e51ebc75 100644
> ---
> a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
> +++
> b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
> @@ -18,12 +18,12 @@
>
> [Defines]
> INF_VERSION = 0x0001001A
> - BASE_NAME = StandloneMmCpu
> + BASE_NAME = StandaloneMmCpu
> FILE_GUID = 58F7A62B-6280-42A7-BC38-
> 10535A64A92C
> MODULE_TYPE = MM_STANDALONE
> VERSION_STRING = 1.0
> PI_SPECIFICATION_VERSION = 0x00010032
> - ENTRY_POINT = StandloneMmCpuInitialize
> + ENTRY_POINT = StandaloneMmCpuInitialize
>
> [Sources]
> StandaloneMmCpu.c
next prev parent reply other threads:[~2019-01-04 17:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 11:03 [PATCH 0/8] StandaloneMmPkg: assorted fixes and improvements Ard Biesheuvel
2019-01-04 11:03 ` [PATCH 1/8] StandaloneMmPkg/StandaloneMmCpu: fix typo Standlone -> Standalone Ard Biesheuvel
2019-01-04 17:48 ` Supreeth Venkatesh [this message]
2019-01-04 11:03 ` [PATCH 2/8] StandaloneMmPkg/StandaloneMmCoreEntryPoint: add missing SerialPortLib ref Ard Biesheuvel
2019-01-04 17:49 ` Supreeth Venkatesh
2019-01-04 11:03 ` [PATCH 3/8] StandaloneMmPkg/StandaloneMmCoreEntryPoint: use %a modifier for ASCII strings Ard Biesheuvel
2019-01-04 17:51 ` Supreeth Venkatesh
2019-01-04 11:03 ` [PATCH 4/8] StandaloneMmPkg/StandaloneMmCoreEntryPoint: remove bogus ASSERT_EFI_ERROR()s Ard Biesheuvel
2019-01-04 17:52 ` Supreeth Venkatesh
2019-01-04 11:03 ` [PATCH 5/8] StandaloneMmPkg/StandaloneMmPeCoffExtraActionLib: ignore runtime attribute Ard Biesheuvel
2019-01-04 11:03 ` [PATCH 6/8] StandaloneMmPkg/Core/Dispatcher: don't copy dispatched image twice Ard Biesheuvel
2019-01-04 11:03 ` [PATCH 7/8] StandaloneMmPkg/StandaloneMmCoreEntryPoint: permit the use of TE images Ard Biesheuvel
2019-01-04 11:03 ` [PATCH 8/8] StandaloneMmPkg/Core: permit encapsulated firmware volumes Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6e9e45cda30078cb91e44c3ca6057003ae33a1b.camel@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox