From: "Rebecca Cran" <quic_rcran@quicinc.com>
To: Tinh Nguyen OS <tinhnguyen@os.amperecomputing.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"quic_rcran@quicinc.com" <quic_rcran@quicinc.com>
Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Remove whitespace in doxygen param passing direction [in,out]
Date: Mon, 20 Feb 2023 19:03:58 -0700 [thread overview]
Message-ID: <a6f01f73-64fc-45fa-e4a6-3fb1d151025d@quicinc.com> (raw)
In-Reply-To: <d9073506-3a27-a4f4-5a60-9f8e1525b17a@amperemail.onmicrosoft.com>
On 2/20/23 18:58, Tinh Nguyen OS wrote:
> On 2/21/2023 1:45 AM, Rebecca Cran via groups.io wrote:
>> There isn't supposed to be whitespace for "@param [in,out]" between "in"
>> and "out". clang generates the following warning:
>>
>> test.c:8:9: warning: whitespace is not allowed in parameter passing direction [-Wdocumentation-pedantic]
>> @param [in, out] argv Array of arguments.
>> ^~~~~~~~~
>> [in,out]
>>
>> Update the documentation blocks in MdePkg.
>>
>> Signed-off-by: Rebecca Cran <rebecca@quicinc.com>
>> ---
>>
> Hi Rebecca,
>
> It is just a personal question, not relevant to patch review, which tool
> do you use?
I used Visual Studio Code to do the search/replace.
--
Rebecca Cran
next prev parent reply other threads:[~2023-02-21 2:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 18:45 [PATCH 1/1] MdePkg: Remove whitespace in doxygen param passing direction [in,out] Rebecca Cran
2023-02-21 1:58 ` [edk2-devel] " Tinh Nguyen
2023-02-21 2:03 ` Rebecca Cran [this message]
2023-03-10 3:03 ` 回复: " gaoliming
2023-03-14 18:06 ` Rebecca Cran
2023-03-14 20:38 ` Michael D Kinney
2023-03-14 21:00 ` Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6f01f73-64fc-45fa-e4a6-3fb1d151025d@quicinc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox