From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.32648.1676945041787111289 for ; Mon, 20 Feb 2023 18:04:02 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=jezG3YxP; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31KN914Q012915; Tue, 21 Feb 2023 02:04:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=ILLmgHGXRGx2c7jqZ9tPKtF1xyEfOFWDEG6FWgyiURE=; b=jezG3YxPaHBPzb8we1qfEpTHsbK15m7X9XInA9yP0MHlK5peglH1WHfJrdXIdlTqcfB2 QTF189wpdYHOzSiWgHRwG0/2UHcBIt+1ae7Jf1a53gVwrf799xQdTuWpRGRSjTPKJs2z 6wqnj1xZjMp8dpfZCb/6vvAHu+zrj7oWfTzaht851rEwS85JSeyO3A08+y4HRU6df4Zb JBOU+Ndp3C/rrbDjzn0YuRqCLPDltImpMneJMP3c5BNoboMImL0JvCVEk1liVi3QnO5u WZh3pO2hnb+YBlWGA0z06CWPqTCgFUZPjDPJxT9NiwwhIlsK5EBY1g7e9BAgENqQaEhY nA== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ntq2ephbp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Feb 2023 02:04:00 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31L23xYR014942 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Feb 2023 02:03:59 GMT Received: from [10.110.69.180] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 20 Feb 2023 18:03:59 -0800 Message-ID: Date: Mon, 20 Feb 2023 19:03:58 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Remove whitespace in doxygen param passing direction [in,out] To: Tinh Nguyen OS , "devel@edk2.groups.io" , "quic_rcran@quicinc.com" References: <20230220184556.1024570-1-rebecca@quicinc.com> From: "Rebecca Cran" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: wRW-MTN81AAi5DL3Ns-VyWm9iNGnUGgu X-Proofpoint-GUID: wRW-MTN81AAi5DL3Ns-VyWm9iNGnUGgu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-20_19,2023-02-20_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 impostorscore=0 spamscore=0 mlxscore=0 mlxlogscore=987 malwarescore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302210016 Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 2/20/23 18:58, Tinh Nguyen OS wrote: > On 2/21/2023 1:45 AM, Rebecca Cran via groups.io wrote: >> There isn't supposed to be whitespace for "@param [in,out]" between "in" >> and "out". clang generates the following warning: >> >> test.c:8:9: warning: whitespace is not allowed in parameter passing direction [-Wdocumentation-pedantic] >> @param [in, out] argv Array of arguments. >> ^~~~~~~~~ >> [in,out] >> >> Update the documentation blocks in MdePkg. >> >> Signed-off-by: Rebecca Cran >> --- >> > Hi Rebecca, > > It is just a personal question, not relevant to patch review, which tool > do you use? I used Visual Studio Code to do the search/replace. -- Rebecca Cran