From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Jordan Justen <jordan.l.justen@intel.com>, devel@edk2.groups.io
Cc: Laszlo Ersek <lersek@redhat.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: Re: [RFC PATCH 4/4] BaseTools/PatchCheck.py: Check the committer email address
Date: Sat, 4 Jan 2020 12:38:19 +0100 [thread overview]
Message-ID: <a6ff2f98-f4bc-68cd-4707-b39676cbfbb6@redhat.com> (raw)
In-Reply-To: <157809234606.2557980.3513866584435812764@jljusten-skl>
On 1/3/20 11:59 PM, Jordan Justen wrote:
> On 2020-01-02 07:25:53, Philippe Mathieu-Daude wrote:
>> To avoid patches committed with incorrect email address,
>> use the EmailAddressCheck class on the committer email too.
>>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
>> ---
>> RFC because I haven't checked --pretty="%cn <%ce>" works on Windows shell.
>>
>> BaseTools/Scripts/PatchCheck.py | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py
>> index f0e661bfd6e3..3baeb3de7ba2 100755
>> --- a/BaseTools/Scripts/PatchCheck.py
>> +++ b/BaseTools/Scripts/PatchCheck.py
>> @@ -560,6 +560,8 @@ class CheckGitCommits:
>> else:
>> blank_line = True
>> print('Checking git commit:', commit)
>> + email = self.read_committer_email_address_from_git(commit)
>> + self.ok &= EmailAddressCheck(email, 'Committer').ok
>> patch = self.read_patch_from_git(commit)
>> self.ok &= CheckOnePatch(commit, patch).ok
>> if not commits:
>> @@ -578,6 +580,10 @@ class CheckGitCommits:
>> # Run git to get the commit patch
>> return self.run_git('show', '--pretty=email', '--no-textconv', commit)
>>
>> + def read_committer_email_address_from_git(self, commit):
>> + # Run git to get the committer email
>> + return self.run_git('show', '--pretty="%cn <%ce>"', '--no-patch', commit)
>
> I think '--pretty=%cn <%ce>' ought to work without double-quotes
> because the argument is separately sent via the subprocess.Popen call.
> I'm not certain it will work, but it ought to. :)
Oh, this works like charm on Linux :)
Thanks for the tip (and review)!
Phil.
>> +
>> def run_git(self, *args):
>> cmd = [ 'git' ]
>> cmd += args
>> --
>> 2.21.0
>>
>
next prev parent reply other threads:[~2020-01-04 11:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 15:25 [PATCH 0/4] BaseTools/PatchCheck: Check committer/author email addresses Philippe Mathieu-Daudé
2020-01-02 15:25 ` [PATCH 1/4] BaseTools/PatchCheck.py: Extract email check code to EmailAddressCheck Philippe Mathieu-Daudé
2020-01-02 15:25 ` [PATCH 2/4] BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked Philippe Mathieu-Daudé
2020-01-02 15:25 ` [PATCH 3/4] BaseTools/PatchCheck.py: Check the patch author email address Philippe Mathieu-Daudé
2020-01-02 15:25 ` [RFC PATCH 4/4] BaseTools/PatchCheck.py: Check the committer " Philippe Mathieu-Daudé
2020-01-03 22:59 ` Jordan Justen
2020-01-04 11:38 ` Philippe Mathieu-Daudé [this message]
2020-01-03 13:11 ` [PATCH 0/4] BaseTools/PatchCheck: Check committer/author email addresses Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6ff2f98-f4bc-68cd-4707-b39676cbfbb6@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox