From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mx.groups.io with SMTP id smtpd.web11.82064.1674757764856764959 for ; Thu, 26 Jan 2023 10:29:24 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=TLYsEQ4v; spf=pass (domain: gmail.com, ip: 209.85.210.173, mailfrom: icegambit91@gmail.com) Received: by mail-pf1-f173.google.com with SMTP id 203so393790pfx.6 for ; Thu, 26 Jan 2023 10:29:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=09vC41amBFeyoeGIalHljDnyYIvZPrda99amk/jOH7k=; b=TLYsEQ4vpYqlQtq1erA+y+c89dymApWjG6yWyxQWIQOLQH1euj7g22QlaGSbtTQzCy YnpKqFZ9gnGawQ3Duui+aYcTKpgvJng3Q4n+ZR7nWAY7t1sIlpt1n5Y3QXDZMBOLhJr1 TN5UWrVX2qCRHnE5YlvOXIsovBQURNhHISfKF7FPsDLg+ZmZftP77gme11eiNl10FO0o Yf3pYB0R0RiEnk02tdxsEwtU2hO6YAKGPHh1k5/ok9tFlb0m2j76CZiA65s2JOxqU/cf idXJYpVH5UDAuVSN9AZzx1R7hiDPOTwrbrLyxTrJYlJNJQ9z3wi/fKWXFhUJvIRbaSlZ JwUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=09vC41amBFeyoeGIalHljDnyYIvZPrda99amk/jOH7k=; b=VIcU8strnN2j4Rv6yc0ylK92vHq/MfW66iI2XiRG56D9nOBM2bQvKvT5OP1NwH5ybx pjYZ8asEoN+ZkxpM5hCjhgqAVE88yQgdDR1kBGgH9KwK6s9PbwnTooATkJvfboKYEvqm Ihrmw/9ML4OWSxGLCWFl1DO+UB30tyDF7+B7MtZ4+q0vtDKTigTqV7DGCPUk15lWlU8S /9p/bRI0IscfR/KjRwguwevzr83XRhxj6qajfExgL0IWKbxpp3UHT/B4UC+q/q1gUqS1 kss7Ih31jHmyM1pyn+ll/jeNAzZloo/s6CouMY6EuceAY/4YMrLatxtClIYKNYxXqdGh GRug== X-Gm-Message-State: AFqh2kq86Plj7f19U78qx7J1SE4zfqhmMrjbIxFg40kySQKAAcgL48vo GQ7Kcq8EU5hNDOksyB3Z86uVB97tBFX/Wg== X-Google-Smtp-Source: AMrXdXsdSDeGt0ubFCugXqMR4dw1U8EGdHZhPoQq/bN4Yr1ugjt7c1tccUWVQhe5zh1WulAU0Q4gnA== X-Received: by 2002:a05:6a00:2a04:b0:582:26bc:a75b with SMTP id ce4-20020a056a002a0400b0058226bca75bmr37659127pfb.9.1674757764148; Thu, 26 Jan 2023 10:29:24 -0800 (PST) Return-Path: Received: from archlinux.bits-pilani.ac.in ([103.144.92.160]) by smtp.gmail.com with ESMTPSA id c136-20020a624e8e000000b005898fcb7c2bsm1150299pfb.170.2023.01.26.10.29.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 10:29:23 -0800 (PST) From: icegambit91@gmail.com To: devel@edk2.groups.io Cc: Sahil Siddiq Subject: [PATCH] MdeModulePkg/SmmLockBoxLib: Remove dead code Date: Thu, 26 Jan 2023 23:59:06 +0530 Message-Id: X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4317 The "if" condition on line 554 ensures that Guid won't be NULL (or 0) on li= ne 600. So, there will never be a situation where the "else" block on line 603 is e= xecuted. Signed-off-by: Sahil Siddiq --- MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.c b/MdeMod= ulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.c index 69d4c42ad1..9326158bd4 100644 --- a/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.c +++ b/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.c @@ -597,11 +597,7 @@ RestoreLockBox ( LockBoxParameterRestore->Header.Command =3D EFI_SMM_LOCK_BOX_COMMAN= D_RESTORE;=0D LockBoxParameterRestore->Header.DataLength =3D sizeof (*LockBoxParamet= erRestore);=0D LockBoxParameterRestore->Header.ReturnStatus =3D (UINT64)-1;=0D - if (Guid !=3D 0) {=0D - CopyMem (&LockBoxParameterRestore->Guid, Guid, sizeof (*Guid));=0D - } else {=0D - ZeroMem (&LockBoxParameterRestore->Guid, sizeof (*Guid));=0D - }=0D + CopyMem (&LockBoxParameterRestore->Guid, Guid, sizeof (*Guid));=0D =0D LockBoxParameterRestore->Buffer =3D (EFI_PHYSICAL_ADDRESS)(UINTN)Buffer;= =0D if (Length !=3D NULL) {=0D --=20 2.39.1