From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web10.8393.1685517789352390395
 for <devel@edk2.groups.io>;
 Wed, 31 May 2023 00:23:09 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QfjL2DQj;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1685517788;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ETNALs2CuJcAs8GZiOeGAs7UPKsXtILPK2oja7QZbDI=;
	b=QfjL2DQjGB3n8iwFlXFjo0fbVuHokPwrO01dlmT4IK8/yZplJX62bsYqwy3CqBSct7bIYA
	4Ug6dugfSmtlvT8Mcg3tEwaqvwS76HuZd8caT6izLrsNZi+878QiPA0DFuNIdzTy+W6F3p
	VQKYZfg0OWUUo0CV8QHohze/CwheOe0=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-664--IupVGZlOdGLKBA_FU_tRQ-1; Wed, 31 May 2023 03:23:04 -0400
X-MC-Unique: -IupVGZlOdGLKBA_FU_tRQ-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 077E7811E7F;
	Wed, 31 May 2023 07:23:04 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.102])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 800232029F6E;
	Wed, 31 May 2023 07:23:01 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 5A1A21800929; Wed, 31 May 2023 09:22:59 +0200 (CEST)
Date: Wed, 31 May 2023 09:22:59 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: "Tan, Dun" <dun.tan@intel.com>, "Ni, Ray" <ray.ni@intel.com>, 
	"devel@edk2.groups.io" <devel@edk2.groups.io>, "Yao, Jiewen" <jiewen.yao@intel.com>, 
	Taylor Beebe <t@taylorbeebe.com>, Oliver Smith-Denny <osd@smith-denny.com>, 
	"Bi, Dandan" <dandan.bi@intel.com>, "Gao, Liming" <gaoliming@byosoft.com.cn>, 
	"Kinney, Michael D" <michael.d.kinney@intel.com>, Leif Lindholm <quic_llindhol@quicinc.com>, 
	Sunil V L <sunilvl@ventanamicro.com>, "Warkentin, Andrei" <andrei.warkentin@intel.com>
Subject: Re: [RFC PATCH 09/10] MdeModulePkg/DxeIpl: Use memory attribute PPI to remap the stack NX
Message-ID: <a722lq5x36j3enawoyfvwkv2hzxlevzli2bniwifgsyu3wan7x@pk7eg2om5nl7>
References: <20230525143041.1172989-1-ardb@kernel.org>
 <20230525143041.1172989-10-ardb@kernel.org>
 <MN6PR11MB824455617A9618B624266D2B8C4B9@MN6PR11MB8244.namprd11.prod.outlook.com>
 <BN9PR11MB5483C7D22037571E71362201E54B9@BN9PR11MB5483.namprd11.prod.outlook.com>
 <CAMj1kXFkq-Z8+ojcJk7QWcOoevu385-A71nqxuWmP-mmB6=-jQ@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CAMj1kXFkq-Z8+ojcJk7QWcOoevu385-A71nqxuWmP-mmB6=-jQ@mail.gmail.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> However, I must admit that the X64 PEI logic is confusing to me, so I
> may have missed something here. It seems to me that creating an
> entirely new set of page tables in DxeIpl is both redundant (as PEI
> already executes in long mode, and therefore uses page tables)

Well, there is the 32bit PEI / 64bit DXE case.  Which might be the
reason why a new set of page tables is created (unconditionally) even
though it should not be needed in the 64bit PEI / 64bit DXE case.

take care,
  Gerd