From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.15162.1670420078014264101 for ; Wed, 07 Dec 2022 05:34:38 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6F53323A; Wed, 7 Dec 2022 05:34:44 -0800 (PST) Received: from [10.34.100.128] (pierre123.nice.arm.com [10.34.100.128]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E62233F73D; Wed, 7 Dec 2022 05:34:36 -0800 (PST) Message-ID: Date: Wed, 7 Dec 2022 14:34:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 From: "PierreGondois" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 3/6] Platform/Sgi: Initialize additional uart controllers To: devel@edk2.groups.io, vivek.gautam@arm.com Cc: Sami Mujawar , Ard Biesheuvel , Leif Lindholm References: <20220214121307.14608-1-vivek.gautam@arm.com> <20220214121307.14608-4-vivek.gautam@arm.com> In-Reply-To: <20220214121307.14608-4-vivek.gautam@arm.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello Vivek, I just have one minor comment, On 2/14/22 13:13, Vivek Kumar Gautam via groups.io wrote: > From: Shriram K > > The IO virtualization block on reference design platforms allow > connecting non-discoverable devices such as PL011 UART. On platforms > that support this, initialize the UART controller connected to the > IO virtualization block. > > Signed-off-by: Shriram K > Signed-off-by: Vivek Gautam > --- > Platform/ARM/SgiPkg/SgiPlatform.dec | 1 + > Platform/ARM/SgiPkg/RdN2/RdN2.dsc | 4 ++ > Platform/ARM/SgiPkg/RdN2Cfg1/RdN2Cfg1.dsc | 6 +- > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 7 +- > Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.inf | 8 ++- > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 73 +++++++++++++++++++- > Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c | 19 ++++- > 7 files changed, 112 insertions(+), 6 deletions(-) > [...] > diff --git a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c b/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c > index 8139b75d8ee4..26fd873fa647 100644 > --- a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c > +++ b/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c > @@ -1,6 +1,6 @@ > /** @file > * > -* Copyright (c) 2018-2020, ARM Limited. All rights reserved. > +* Copyright (c) 2018-2022, ARM Limited. All rights reserved. > * > * SPDX-License-Identifier: BSD-2-Clause-Patent > * > @@ -17,7 +17,8 @@ > > // Total number of descriptors, including the final "end-of-table" descriptor. > #define MAX_VIRTUAL_MEMORY_MAP_DESCRIPTORS \ > - (14 + (FixedPcdGet32 (PcdChipCount) * 2)) > + (14 + (FixedPcdGet32 (PcdChipCount) * 2)) + \ > + (FeaturePcdGet (PcdIoVirtBlkNonDiscoverable) * 2) Shouldn't it be dependent on PcdIoVirtBlkNonDiscoverable's value ?