Re: [edk2-devel] [RFC PATCH 0/3] add GetMaintainer.py helper script

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 6/14/19 10:21 PM, Leif Lindholm wrote:
> Changes are available directly from:
> https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=upstreaming/git-maintainer-rfc
> 
> This series adds new tags to the Maintainers.txt format, making it possible
> to describe which filesystem paths are looked after by which people, and
> hence automating the extraction of a list over who should be cc:d on a patch
> submission.
> 
> Remaining shorcomings in RFC:
> - Will still be misparsing OvmfPkg and MdeModulePkg due to non-tag lines
>   interspersed with the tag lines. These lines will be removed as areas of
>   responsibility is formally rewritten as tags.

Fix suggested on patch #1 (splitting sections).

> - * Wildcard support is not fully filesystem compliant except in first or
>   last position in the path (it translates as regex .* elsewhere). However,
>   actual cases of mismatch are expected to be unlikely, and they will be
>   false positives rather than false negatives - so I think this is good
>   enough at least for a start.
> - Provides no information of why certain people or meiling lists were
>   picked - it just bundles all recipients up, deduplicates them, and prints
>   them out.

Also good enough for a start :)

> 
> Using the script requires the gitpython module to be installed.
> 
> Changelog:
> rfc:
> - Split patches up
>   - one for new Maintainers.txt format (documentation and F: tags).
>   - one for adding a new wilcards responsibility area for */Arm, */AArch64
>   - one for the GetMaintainer.py script
> - Reworked wildcard handling based on Laszlo's explanation
>   - Trailing / covers everything under that directory
>   - Trailing * does not cover subdirectories
> - Added support for X: tag
> - Added support for magic '<default>' pathname
> - Also prints mailing list addresses for matching L: tags
> 
> Leif Lindholm (3):
>   Maintainers.txt: update for filesystem area descriptions
>   Maintainers.txt: add wildcard path association for Arm/AArch64
>   BaseTools: add GetMaintainer.py script
> 
>  BaseTools/Scripts/GetMaintainer.py | 181 +++++++++++++++++++++++++++++++++++++
>  Maintainers.txt                    |  58 ++++++++++++
>  2 files changed, 239 insertions(+)
>  create mode 100644 BaseTools/Scripts/GetMaintainer.py
> 

Series:
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daude <philmd@redhat.com>