From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.221.67, mailfrom: philmd@redhat.com) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by groups.io with SMTP; Fri, 14 Jun 2019 23:21:13 -0700 Received: by mail-wr1-f67.google.com with SMTP id p11so4612301wre.7 for ; Fri, 14 Jun 2019 23:21:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RpwFzEj2SNA0ATR7J4MO0A8DtfHcDF4nWuO4gOTG8PA=; b=YzY058H8BfggkH0wdPhRLEOr0hl/8odfX1VUXMyoDXugaSPjyPaYAJ3HQIfJhiuFsM japiJrJ9Cv3BL6aP8OfmKUN/Ll6ek7FOuU3thh2eskW9WwtqiLiA7xbyESA/lT7/ADcK WcTLXR9ZWdpe6/5wFuvauorp7xGq4ABtO1IyQa9mdMo4qjsJMhLa3qih6tFDx8k+3bvu 2SplLiodKgEnUn35QhmrvZpW1Uk9Xu+8LGL2CYH9/MsUk15AxcNuwtPqZEzs9O0IcMtd YX22UCUW4xNUbcd5r4TC+SM6fe3YGIOFtYEPBWln8svWD8YBvrHj+RGxPu9Cy9/FTFrI Ypfw== X-Gm-Message-State: APjAAAXXNy/ZgoauKRhddjrZiaAmeldXXiyE5b9QJctVRE2Bev+pOj3y Nodjx9F+FLDvxTpZf5Acb7qUeA== X-Google-Smtp-Source: APXvYqyKNBECG7UgVFEmV92ctBrOvtxduoDR68bnMUtnJbjXH4cD5H4SYsjifVPYVenyl6ERHq2XxA== X-Received: by 2002:a5d:4286:: with SMTP id k6mr5001627wrq.151.1560579671510; Fri, 14 Jun 2019 23:21:11 -0700 (PDT) Return-Path: Received: from [192.168.1.103] (183.red-88-21-202.staticip.rima-tde.net. [88.21.202.183]) by smtp.gmail.com with ESMTPSA id r131sm4408896wmf.4.2019.06.14.23.21.10 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 14 Jun 2019 23:21:11 -0700 (PDT) Subject: Re: [edk2-devel] [RFC PATCH 0/3] add GetMaintainer.py helper script To: devel@edk2.groups.io, leif.lindholm@linaro.org Cc: "Feng, Bob C" , Liming Gao , Andrew Fish , Laszlo Ersek , Michael D Kinney , "Wu, Hao A" References: <20190614202121.18952-1-leif.lindholm@linaro.org> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Sat, 15 Jun 2019 08:21:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190614202121.18952-1-leif.lindholm@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 6/14/19 10:21 PM, Leif Lindholm wrote: > Changes are available directly from: > https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=upstreaming/git-maintainer-rfc > > This series adds new tags to the Maintainers.txt format, making it possible > to describe which filesystem paths are looked after by which people, and > hence automating the extraction of a list over who should be cc:d on a patch > submission. > > Remaining shorcomings in RFC: > - Will still be misparsing OvmfPkg and MdeModulePkg due to non-tag lines > interspersed with the tag lines. These lines will be removed as areas of > responsibility is formally rewritten as tags. Fix suggested on patch #1 (splitting sections). > - * Wildcard support is not fully filesystem compliant except in first or > last position in the path (it translates as regex .* elsewhere). However, > actual cases of mismatch are expected to be unlikely, and they will be > false positives rather than false negatives - so I think this is good > enough at least for a start. > - Provides no information of why certain people or meiling lists were > picked - it just bundles all recipients up, deduplicates them, and prints > them out. Also good enough for a start :) > > Using the script requires the gitpython module to be installed. > > Changelog: > rfc: > - Split patches up > - one for new Maintainers.txt format (documentation and F: tags). > - one for adding a new wilcards responsibility area for */Arm, */AArch64 > - one for the GetMaintainer.py script > - Reworked wildcard handling based on Laszlo's explanation > - Trailing / covers everything under that directory > - Trailing * does not cover subdirectories > - Added support for X: tag > - Added support for magic '' pathname > - Also prints mailing list addresses for matching L: tags > > Leif Lindholm (3): > Maintainers.txt: update for filesystem area descriptions > Maintainers.txt: add wildcard path association for Arm/AArch64 > BaseTools: add GetMaintainer.py script > > BaseTools/Scripts/GetMaintainer.py | 181 +++++++++++++++++++++++++++++++++++++ > Maintainers.txt | 58 ++++++++++++ > 2 files changed, 239 insertions(+) > create mode 100644 BaseTools/Scripts/GetMaintainer.py > Series: Reviewed-by: Philippe Mathieu-Daude Tested-by: Philippe Mathieu-Daude