From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D7CEAD804EA for ; Wed, 21 Feb 2024 20:12:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=36efcy0xlQIVVv9m6MmPPeaos7KWN1ZJcO6b0tN5Ack=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708546345; v=1; b=pnrOH1R7+ddPfDwhZDUVCQSj/K5X6fQdbFd7Ymx5IC8x7Ik2eHaUuowN+yfiDColUze5we93 HRcsbz1xXqZduI6MXUJS2y70jgLoCo3h3EUa4lMVr6FzhaBLCbbvyxFAuyrLwEEUZRfY1YEn/lP 9ndyfbCVE0Qrw4aVNQ7N9MOs= X-Received: by 127.0.0.2 with SMTP id ztemYY7687511xW0ObIo9aqW; Wed, 21 Feb 2024 12:12:25 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.1259.1708546344777196297 for ; Wed, 21 Feb 2024 12:12:24 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-136-OIW9NChQO8qAByBkupQbUw-1; Wed, 21 Feb 2024 15:12:20 -0500 X-MC-Unique: OIW9NChQO8qAByBkupQbUw-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 680AF85A588; Wed, 21 Feb 2024 20:12:20 +0000 (UTC) X-Received: from [10.39.192.46] (unknown [10.39.192.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4A72C21121B5; Wed, 21 Feb 2024 20:12:19 +0000 (UTC) Message-ID: Date: Wed, 21 Feb 2024 21:12:18 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix IN OUT parameters marked as IN From: "Laszlo Ersek" To: "Ni, Ray" , "Zhou, Jianfeng" , "devel@edk2.groups.io" Cc: "Kumar, Rahul R" , Gerd Hoffmann References: <20240221012441.27406-1-jianfeng.zhou@intel.com> <5b38efb8-8d99-1540-afb0-b46be55e89cd@redhat.com> In-Reply-To: <5b38efb8-8d99-1540-afb0-b46be55e89cd@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: kQ9mC49ZqOK6oXyFuCOFiNyPx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=pnrOH1R7; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 2/21/24 21:06, Laszlo Ersek wrote: > On 2/21/24 06:46, Ni, Ray wrote: >> Reviewed-by: Ray Ni >=20 > Thank you Ray for reviewing this; I'm happy if this goes in with your > review. small suggestion: I think we could improve the subject line as follows: UefiCpuPkg/CpuPageTableLib: Fix IN OUT parameters marked as IN Thanks Laszlo >> Thanks, >> Ray >>> -----Original Message----- >>> From: Zhou, Jianfeng >>> Sent: Wednesday, February 21, 2024 9:25 AM >>> To: devel@edk2.groups.io >>> Cc: Zhou, Jianfeng ; Ni, Ray ; >>> Laszlo Ersek ; Kumar, Rahul R >>> ; Gerd Hoffmann >>> Subject: [PATCH] UefiCpuPkg: Fix IN OUT parameters marked as IN >>> >>> Some IN OUT parameters in CpuPageTableMap.c were mistakenly marked as >>> IN. >>> "IN" replaced with "IN OUT" in the following interfaces: >>> >>> PageTableLibSetPte4K(): Pte4K >>> PageTableLibSetPleB(): PleB >>> PageTableLibSetPle(): Ple >>> PageTableLibSetPnle(): Pnle >>> >>> Signed-off-by: Zhou Jianfeng >>> Cc: Ray Ni >>> Cc: Laszlo Ersek >>> Cc: Rahul Kumar >>> Cc: Gerd Hoffmann >>> --- >>> .../Library/CpuPageTableLib/CpuPageTableMap.c | 32 +++++++++---------- >>> 1 file changed, 16 insertions(+), 16 deletions(-) >>> >>> diff --git a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c >>> b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c >>> index ae4caf8dfe..2ea40666cc 100644 >>> --- a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c >>> +++ b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c >>> @@ -20,10 +20,10 @@ >>> **/ >>> >>> VOID >>> >>> PageTableLibSetPte4K ( >>> >>> - IN IA32_PTE_4K *Pte4K, >>> >>> - IN UINT64 Offset, >>> >>> - IN IA32_MAP_ATTRIBUTE *Attribute, >>> >>> - IN IA32_MAP_ATTRIBUTE *Mask >>> >>> + IN OUT IA32_PTE_4K *Pte4K, >>> >>> + IN UINT64 Offset, >>> >>> + IN IA32_MAP_ATTRIBUTE *Attribute, >>> >>> + IN IA32_MAP_ATTRIBUTE *Mask >>> >>> ) >>> >>> { >>> >>> IA32_PTE_4K LocalPte4K; >>> >>> @@ -94,10 +94,10 @@ PageTableLibSetPte4K ( >>> **/ >>> >>> VOID >>> >>> PageTableLibSetPleB ( >>> >>> - IN IA32_PAGE_LEAF_ENTRY_BIG_PAGESIZE *PleB, >>> >>> - IN UINT64 Offset, >>> >>> - IN IA32_MAP_ATTRIBUTE *Attribute, >>> >>> - IN IA32_MAP_ATTRIBUTE *Mask >>> >>> + IN OUT IA32_PAGE_LEAF_ENTRY_BIG_PAGESIZE *PleB, >>> >>> + IN UINT64 Offset, >>> >>> + IN IA32_MAP_ATTRIBUTE *Attribute, >>> >>> + IN IA32_MAP_ATTRIBUTE *Mask >>> >>> ) >>> >>> { >>> >>> IA32_PAGE_LEAF_ENTRY_BIG_PAGESIZE LocalPleB; >>> >>> @@ -171,11 +171,11 @@ PageTableLibSetPleB ( >>> **/ >>> >>> VOID >>> >>> PageTableLibSetPle ( >>> >>> - IN UINTN Level, >>> >>> - IN IA32_PAGING_ENTRY *Ple, >>> >>> - IN UINT64 Offset, >>> >>> - IN IA32_MAP_ATTRIBUTE *Attribute, >>> >>> - IN IA32_MAP_ATTRIBUTE *Mask >>> >>> + IN UINTN Level, >>> >>> + IN OUT IA32_PAGING_ENTRY *Ple, >>> >>> + IN UINT64 Offset, >>> >>> + IN IA32_MAP_ATTRIBUTE *Attribute, >>> >>> + IN IA32_MAP_ATTRIBUTE *Mask >>> >>> ) >>> >>> { >>> >>> if (Level =3D=3D 1) { >>> >>> @@ -195,9 +195,9 @@ PageTableLibSetPle ( >>> **/ >>> >>> VOID >>> >>> PageTableLibSetPnle ( >>> >>> - IN IA32_PAGE_NON_LEAF_ENTRY *Pnle, >>> >>> - IN IA32_MAP_ATTRIBUTE *Attribute, >>> >>> - IN IA32_MAP_ATTRIBUTE *Mask >>> >>> + IN OUT IA32_PAGE_NON_LEAF_ENTRY *Pnle, >>> >>> + IN IA32_MAP_ATTRIBUTE *Attribute, >>> >>> + IN IA32_MAP_ATTRIBUTE *Mask >>> >>> ) >>> >>> { >>> >>> IA32_PAGE_NON_LEAF_ENTRY LocalPnle; >>> >>> -- >>> 2.31.1.windows.1 >> >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115740): https://edk2.groups.io/g/devel/message/115740 Mute This Topic: https://groups.io/mt/104483605/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-