From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot0-x230.google.com (mail-ot0-x230.google.com [IPv6:2607:f8b0:4003:c0f::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DE6D021967BE6 for ; Thu, 8 Jun 2017 01:50:48 -0700 (PDT) Received: by mail-ot0-x230.google.com with SMTP id a2so19876288oth.2 for ; Thu, 08 Jun 2017 01:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :in-reply-to:content-language:content-transfer-encoding:mime-version; bh=j0eRuWZlu+vdkJYPyVAZ7WKAmhtgvh6Ypw190+u1k4M=; b=Ctwrle354EW6VlLGO8ZapyayQ6QxpwgiSJgM7Ga9FUYedQgRovSzxe7C3PbO3kH4In W/PLZzJGWuWanpqiEfdpmvl4FaKyGJeQzYbH3Yd7w01JFKz2MtCVjEcs9iXAn0DnEWa3 ZcUCs2Z5W9zTFHVLH6nC4PcPMmP/MdNFBXZ1I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:in-reply-to:content-language :content-transfer-encoding:mime-version; bh=j0eRuWZlu+vdkJYPyVAZ7WKAmhtgvh6Ypw190+u1k4M=; b=VPiP1VdBxYhG4DMfgbmQHjg0CyknkgF2fxBbeCRu2MuR9ZScxpkn9vcvZ/ebbNDN+R NzWgOxRLoeFLk9/IZweumT30fTYT3ObSeKVSTvbD9fOMyA4CmfL4ctk8+V4au4CyeVWI USGkbSi8e9ySn6kG4GpM6AeI+LcA7btEjg7o2HsYKCahAqxgjbJ4Gj1ASl008aPu2yQY CAeCXy01u3MhUEwbXxYaho7W9r0s8tJPWE9uULkSCTwnjJf1BX+8qutfXo2Feb8uF25r N2Dq+XT/LkuBw32efuxUN+neE1CNcGhXfhEj/T/LYZCjrugyT7caJNXYrG4CKojEDyJm usrg== X-Gm-Message-State: AKS2vOwIm7di40SnfB1dFfYxQMXB0erZQweXTB7lC33GYm/Lduv0YY+N 00lBDCirDJoIYq3n X-Received: by 10.157.43.180 with SMTP id u49mr21539816ota.182.1496911915906; Thu, 08 Jun 2017 01:51:55 -0700 (PDT) Received: from CY1PR15MB0730.namprd15.prod.outlook.com ([132.245.253.237]) by smtp.gmail.com with ESMTPSA id u76sm2354682ota.8.2017.06.08.01.51.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 08 Jun 2017 01:51:55 -0700 (PDT) Received: from BLU436-SMTP192 (10.173.177.12) by CY1PR15MB0730.namprd15.prod.outlook.com (10.169.21.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1157.12 via Mailbox Transport; Thu, 8 Jun 2017 08:40:03 +0000 Received: from [192.168.10.106] ([116.192.30.186]) by BLU436-SMTP192.smtp.hotmail.com over TLS secured channel with Microsoft SMTPSVC(8.0.9200.16384); Thu, 8 Jun 2017 01:40:02 -0700 Reply-To: haojian.zhuang@linaro.org To: Jun Nie , olivier.martin@arm.com, edk2-devel@lists.01.org Cc: shawn.guo@linaro.org, jason.liu@linaro.org References: <1496909547-16085-1-git-send-email-jun.nie@linaro.org> From: Haojian Zhuang Message-ID: Date: Thu, 8 Jun 2017 16:39:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 In-Reply-To: <1496909547-16085-1-git-send-email-jun.nie@linaro.org> X-OriginalArrivalTime: 08 Jun 2017 08:40:02.0528 (UTC) FILETIME=[D21D2E00:01D2E032] X-MS-Exchange-Organization-Network-Message-Id: dfdac922-46b3-4e22-8b6a-08d4ae49f534 X-MS-Exchange-Organization-AuthSource: CY1PR15MB0730.namprd15.prod.outlook.com X-MS-Exchange-Organization-AuthAs: Anonymous X-TMN: [XBPX7VpFMt0YQVnYFxrTe/zMrN9epte7] MIME-Version: 1.0 Subject: Re: [PATCH] EmbeddedPkg/MmcDxe: Add non-DDR timing mode support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jun 2017 08:50:49 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2017/6/8 16:12, Jun Nie wrote: > Only DDR mode is support for 8bit mode currently. Add > non-DDR case when configuring ECSD. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jun Nie > --- > EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > index 574a77e..5c0d7e7 100644 > --- a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > +++ b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > @@ -286,7 +286,10 @@ InitializeEmmcDevice ( > } > Status = Host->SetIos (Host, BusClockFreq, 8, TimingMode[Idx]); > if (!EFI_ERROR (Status)) { > - Status = EmmcSetEXTCSD (MmcHostInstance, EXTCSD_BUS_WIDTH, EMMC_BUS_WIDTH_DDR_8BIT); > + if (Idx < 2) It's better to avoid hardcoded value at here. Maybe you can use switch & case on TimingMode array at here. > + Status = EmmcSetEXTCSD (MmcHostInstance, EXTCSD_BUS_WIDTH, EMMC_BUS_WIDTH_DDR_8BIT); > + else > + Status = EmmcSetEXTCSD (MmcHostInstance, EXTCSD_BUS_WIDTH, EMMC_BUS_WIDTH_8BIT); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "InitializeEmmcDevice(): Failed to set EXTCSD bus width, Status:%r\n", Status)); > } > Best Regards Haojian