public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Min Xu" <min.m.xu@intel.com>
To: devel@edk2.groups.io
Cc: Min Xu <min.m.xu@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Sebastien Boeuf <sebastien.boeuf@intel.com>
Subject: [PATCH V11 28/47] OvmfPkg/PlatformPei: Refactor MiscInitialization
Date: Mon, 28 Mar 2022 16:08:07 +0800	[thread overview]
Message-ID: <a77ccd9745575a76295cafe63e820ec412bff673.1648454441.git.min.m.xu@intel.com> (raw)
In-Reply-To: <cover.1648454440.git.min.m.xu@intel.com>

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863

MiscInitialization is split into 2 functions:
 - PlatformMiscInitialization is for PlatformInitLib.
 - MiscInitialization calls PlatformMiscInitialization and then sets
   PCD. It is for PlatformPei.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Erdem Aktas <erdemaktas@google.com>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Sebastien Boeuf <sebastien.boeuf@intel.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Min Xu <min.m.xu@intel.com>
---
 OvmfPkg/PlatformPei/Platform.c | 43 ++++++++++++++++++++--------------
 1 file changed, 26 insertions(+), 17 deletions(-)

diff --git a/OvmfPkg/PlatformPei/Platform.c b/OvmfPkg/PlatformPei/Platform.c
index e91acca9f769..02697c473d01 100644
--- a/OvmfPkg/PlatformPei/Platform.c
+++ b/OvmfPkg/PlatformPei/Platform.c
@@ -57,12 +57,12 @@ PlatformMemMapInitialization (
   IN OUT EFI_HOB_PLATFORM_INFO  *PlatformInfoHob
   )
 {
-  UINT64         PciIoBase;
-  UINT64         PciIoSize;
-  UINT32         TopOfLowRam;
-  UINT64         PciExBarBase;
-  UINT32         PciBase;
-  UINT32         PciSize;
+  UINT64  PciIoBase;
+  UINT64  PciIoSize;
+  UINT32  TopOfLowRam;
+  UINT64  PciExBarBase;
+  UINT32  PciBase;
+  UINT32  PciSize;
 
   PciIoBase = 0xC000;
   PciIoSize = 0x4000;
@@ -360,17 +360,16 @@ MiscInitializationForMicrovm (
 }
 
 VOID
-MiscInitialization (
+PlatformMiscInitialization (
   IN EFI_HOB_PLATFORM_INFO  *PlatformInfoHob
   )
 {
-  UINTN          PmCmd;
-  UINTN          Pmba;
-  UINT32         PmbaAndVal;
-  UINT32         PmbaOrVal;
-  UINTN          AcpiCtlReg;
-  UINT8          AcpiEnBit;
-  RETURN_STATUS  PcdStatus;
+  UINTN   PmCmd;
+  UINTN   Pmba;
+  UINT32  PmbaAndVal;
+  UINT32  PmbaOrVal;
+  UINTN   AcpiCtlReg;
+  UINT8   AcpiEnBit;
 
   //
   // Disable A20 Mask
@@ -417,9 +416,6 @@ MiscInitialization (
       return;
   }
 
-  PcdStatus = PcdSet16S (PcdOvmfHostBridgePciDevId, PlatformInfoHob->HostBridgeDevId);
-  ASSERT_RETURN_ERROR (PcdStatus);
-
   if (PlatformInfoHob->HostBridgeDevId == CLOUDHV_DEVICE_ID) {
     DEBUG ((DEBUG_INFO, "%a: Cloud Hypervisor is done.\n", __FUNCTION__));
     return;
@@ -464,6 +460,19 @@ MiscInitialization (
   }
 }
 
+VOID
+MiscInitialization (
+  IN EFI_HOB_PLATFORM_INFO  *PlatformInfoHob
+  )
+{
+  RETURN_STATUS  PcdStatus;
+
+  PlatformMiscInitialization (PlatformInfoHob);
+
+  PcdStatus = PcdSet16S (PcdOvmfHostBridgePciDevId, PlatformInfoHob->HostBridgeDevId);
+  ASSERT_RETURN_ERROR (PcdStatus);
+}
+
 VOID
 BootModeInitialization (
   IN OUT EFI_HOB_PLATFORM_INFO  *PlatformInfoHob
-- 
2.29.2.windows.2


  parent reply	other threads:[~2022-03-28  8:10 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28  8:07 [PATCH V11 00/47] Enable Intel TDX in OvmfPkg (Config-A) Min Xu
2022-03-28  8:07 ` [PATCH V11 01/47] MdePkg: Add Tdx.h Min Xu
2022-03-28  8:07 ` [PATCH V11 02/47] MdePkg: Update Cpuid.h for Tdx Min Xu
2022-03-28  8:07 ` [PATCH V11 03/47] MdePkg: Introduce basic Tdx functions in BaseLib Min Xu
2022-03-28  8:07 ` [PATCH V11 04/47] MdePkg: Add TdxLib to wrap Tdx operations Min Xu
2022-03-28  8:07 ` [PATCH V11 05/47] UefiCpuPkg: Extend VmgExitLibNull to handle #VE exception Min Xu
2022-03-28  8:07 ` [PATCH V11 06/47] OvmfPkg: Extend VmgExitLib " Min Xu
2022-03-28  8:07 ` [PATCH V11 07/47] UefiCpuPkg/CpuExceptionHandler: Add base support for the " Min Xu
2022-03-28  8:07 ` [PATCH V11 08/47] MdePkg: Add helper functions for Tdx guest in BaseIoLibIntrinsic Min Xu
2022-03-28  8:07 ` [PATCH V11 09/47] MdePkg: Support mmio " Min Xu
2022-03-28  8:07 ` [PATCH V11 10/47] MdePkg: Support IoFifo " Min Xu
2022-03-28  8:07 ` [PATCH V11 11/47] MdePkg: Support IoRead/IoWrite " Min Xu
2022-03-28  8:07 ` [PATCH V11 12/47] UefiCpuPkg: Support TDX in BaseXApicX2ApicLib Min Xu
2022-03-28  8:07 ` [PATCH V11 13/47] MdePkg: Add macro to check SEV / TDX guest Min Xu
2022-03-28  8:07 ` [PATCH V11 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib Min Xu
2022-03-28  8:24   ` Ni, Ray
2022-03-29 12:03     ` Min Xu
2022-03-28  8:07 ` [PATCH V11 15/47] OvmfPkg: Add IntelTdx.h in OvmfPkg/Include/IndustryStandard Min Xu
2022-03-28  8:07 ` [PATCH V11 16/47] OvmfPkg: Add TdxMailboxLib Min Xu
2022-03-28  8:07 ` [PATCH V11 17/47] OvmfPkg: Create initial version of PlatformInitLib Min Xu
2022-03-28  8:07 ` [PATCH V11 18/47] OvmfPkg/PlatformInitLib: Add hob functions Min Xu
2022-03-28  8:07 ` [PATCH V11 19/47] OvmfPkg/PlatformPei: Move global variables to PlatformInfoHob Min Xu
2022-03-28  8:07 ` [PATCH V11 20/47] OvmfPkg/PlatformPei: Refactor MiscInitialization Min Xu
2022-03-28  8:08 ` [PATCH V11 21/47] OvmfPkg/PlatformPei: Refactor MiscInitialization for CloudHV Min Xu
2022-03-28  8:08 ` [PATCH V11 22/47] OvmfPkg/PlatformPei: Refactor AddressWidthInitialization Min Xu
2022-03-28  8:08 ` [PATCH V11 23/47] OvmfPkg/PlatformPei: Refactor MaxCpuCountInitialization Min Xu
2022-03-28  8:08 ` [PATCH V11 24/47] OvmfPkg/PlatformPei: Refactor QemuUc32BaseInitialization Min Xu
2022-03-28  8:08 ` [PATCH V11 25/47] OvmfPkg/PlatformPei: Refactor InitializeRamRegions Min Xu
2022-03-28  8:08 ` [PATCH V11 26/47] OvmfPkg/PlatformPei: Refactor MemMapInitialization Min Xu
2022-03-28  8:08 ` [PATCH V11 27/47] OvmfPkg/PlatformPei: Refactor NoexecDxeInitialization Min Xu
2022-03-28  8:08 ` Min Xu [this message]
2022-03-28  8:08 ` [PATCH V11 30/47] OvmfPkg/PlatformInitLib: Move functions to Platform.c Min Xu
2022-03-28  8:08 ` [PATCH V11 31/47] OvmfPkg: Update PlatformInitLib to process Tdx hoblist Min Xu
2022-03-28  8:08 ` [PATCH V11 32/47] OvmfPkg/Sec: Declare local variable as volatile in SecCoreStartupWithStack Min Xu
2022-03-28  8:08 ` [PATCH V11 33/47] OvmfPkg: Update Sec to support Tdx Min Xu
2022-03-28  8:08 ` [PATCH V11 34/47] OvmfPkg: Check Tdx in QemuFwCfgPei to avoid DMA operation Min Xu
2022-03-28  8:08 ` [PATCH V11 35/47] MdeModulePkg: Skip setting IA32_ERER.NXE if it has already been set Min Xu
2022-03-28  8:08 ` [PATCH V11 36/47] MdeModulePkg: Add PcdTdxSharedBitMask Min Xu
2022-03-28  8:08 ` [PATCH V11 37/47] UefiCpuPkg: Update AddressEncMask in CpuPageTable Min Xu
2022-03-28  8:08 ` [PATCH V11 38/47] OvmfPkg: Update PlatformInitLib for Tdx guest Min Xu
2022-03-28  8:08 ` [PATCH V11 39/47] OvmfPkg: Update PlatformPei to support " Min Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a77ccd9745575a76295cafe63e820ec412bff673.1648454441.git.min.m.xu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox