From: "Laszlo Ersek" <lersek@redhat.com>
To: Anthony PERARD <anthony.perard@citrix.com>, devel@edk2.groups.io
Cc: Jordan Justen <jordan.l.justen@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Julien Grall <julien.grall@arm.com>
Subject: Re: [PATCH v2] OvmfPkg/XenBusDxe: Close XenIoProtocol openned by children
Date: Mon, 1 Jul 2019 16:55:34 +0200 [thread overview]
Message-ID: <a786a291-55ed-cad0-30c3-0e8f19e60fdc@redhat.com> (raw)
In-Reply-To: <20190701105012.25758-1-anthony.perard@citrix.com>
On 07/01/19 12:50, Anthony PERARD wrote:
> In XenBusDxe, the XenBusAddDevice() opens the gXenIoProtocolGuid on
> behalf of child controllers. It is never closed and prevents us from
> uninstalling the protocol.
>
> Close it where we stop all the children in XenBusDxe->Stop().
>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> ---
> OvmfPkg/XenBusDxe/XenBusDxe.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/OvmfPkg/XenBusDxe/XenBusDxe.c b/OvmfPkg/XenBusDxe/XenBusDxe.c
> index 0e63707f50..7c07a96650 100644
> --- a/OvmfPkg/XenBusDxe/XenBusDxe.c
> +++ b/OvmfPkg/XenBusDxe/XenBusDxe.c
> @@ -453,6 +453,10 @@ XenBusDxeDriverBindingStop (
> continue;
> }
>
> + Status = gBS->CloseProtocol (Dev->ControllerHandle, &gXenIoProtocolGuid,
> + Dev->This->DriverBindingHandle, ChildData->Handle);
> + ASSERT_EFI_ERROR (Status);
> +
> Status = gBS->UninstallMultipleProtocolInterfaces (
> ChildData->Handle,
> &gEfiDevicePathProtocolGuid, ChildData->DevicePath,
>
Commit 64ef66ba8b41.
Thanks
Laszlo
prev parent reply other threads:[~2019-07-01 14:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 10:50 [PATCH v2] OvmfPkg/XenBusDxe: Close XenIoProtocol openned by children Anthony PERARD
2019-07-01 14:55 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a786a291-55ed-cad0-30c3-0e8f19e60fdc@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox